Repository navigation
Conversation
Group match results by series_id and add a dedicated Series tab with expandable rows and per-match details. This keeps related games together, preserves the existing single-match behavior for ungrouped matches, and adds compact summary metadata like teams, match count, and last played time.
Author
|
ryanab00
changed the title
ryanab00
changed the title
howardchung
reviewed
Oct 10, 2026
| }, | ||
| { | ||
| // `matches_series` isn't part of the strict `Strings` type yet. | ||
| name: (strings as any).matches_series || "Series", |
Member
There was a problem hiding this comment.
This should be fixed by adding to the json file
Author
There was a problem hiding this comment.
Thank you for this, push should fix this.
Update the matches tab to use the typed `matches_series` string instead of a temporary `any` fallback, and add the default English translation for the Series label.
howardchung
reviewed
Oct 12, 2026
Removed fallback values, would be tedious to update if we ever needed to.
howardchung
reviewed
Oct 15, 2026
Add English labels for the series table and use typed localization keys instead of an `any` cast.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Group match results by series_id and add a dedicated Series tab with expandable rows and per-match details. This keeps related games together, preserves the existing single-match behavior for ungrouped matches, and adds compact summary metadata like teams, match count, and last played time.
CSS isn't perfect so if anyone could help match with the styling in the Pro tab, that would be greatly appreciated.