Repository navigation
Conversation
geracosta
force-pushed
the
assists-log-docs
branch
from
October 3, 2026 00:51
69371be to
e6e935c
Compare
odota/parser#94 adds assists_log: one entry per assist, with the time of the death and the hero that died, the same shape as kills_log. Entries whose victim is not decidable carry ambiguous: true, which is documented alongside so a consumer knows it can filter them.
odota/parser#94 now pairs each assist with its death on the tick both counters move, so ambiguous only comes up on old replays without the combat log assist list. Key can also be a hero on the player's own side, since the game credits some assists on those deaths.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents
assists_log, which odota/parser#94 adds toplayer_matches. Same shape askills_log: one entry per assist, with the time of the death and the hero that died.The one addition worth calling out is
ambiguous. It marks an assist on a tick where two heroes died and the replay doesn't tell which of them it was for. With the tick pairing in odota/parser#94 that only comes up on old replays that predate the combat log assist list: none in 2770 assists on 25 current matches, 1 of 69 on the 2015 test replay.keycan also be a hero on the player's own side, since the game credits some assists on those deaths.The field is stored in the parsed blob, so nothing else in core has to change: no schema change, no new column.