Skip to content

Allow role without bracket on /benchmarks #2985

Closed

Description

@geracosta

Split out of #2984 so it doesn't ride along with the approved change. The role param there only works on top of a bracket, and ?role=core alone returns 400, because we only write the bracket x role sets.

It would be more useful standalone. Someone comparing a hero's core and support distributions across all ranks has no way to ask for that today, and a param that only works in combination with another one is awkward to document. That would mean 2 more sets per hero and metric (benchmarks:{epoch}:{metric}:{heroId}:::core), against the 16 that bracket x role already adds, so it's a small fraction of what's there.

Not sure it's worth the keyspace, which is why it's a separate issue rather than something I slipped into the PR. Happy to leave it if you'd rather keep things tight.

Activity

  1. howardchung commented on Sep 16, 2026

    @howardchung
    Member

    I do think we should support both filters independently (otherwise it's kind of weird behavior)

  2. geracosta commented on Sep 17, 2026

    @geracosta
    ContributorAuthor

    implemented in #2984. it touched the same line your review comment there was about, so it made more sense to fold it in than to open a second PR that would conflict with it.

  3. geracosta commented on Oct 6, 2026

    @geracosta
    ContributorAuthor

    done in #2984, role works without a bracket now: /benchmarks?hero_id=1&role=core returns its own set. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions