Repository navigation
feat(memory): enforce subject-bound atomic extraction - #2078
Conversation
# Conflicts: # e2e/bub/tests/test_harbor_job_config.py
hireview001
left a comment
There was a problem hiding this comment.
- Resolve merge conflicts with the target branch.
hidb4ai
left a comment
There was a problem hiding this comment.
The scorer still certifies instruction-bearing runs and rejects a valid attributed preference. See the inline finding and the follow-up in the existing attribution thread.
hidb4ai
left a comment
There was a problem hiding this comment.
The finite-attribution exemption can suppress a later independent directive, allowing an instruction-bearing run to be pinned as leak-free. See the inline reproduction.
hireview001
left a comment
There was a problem hiding this comment.
- CI failed: Upgrade release gate (failure).
- CI failed: tests (3.13, e2e) (failure).
- CI failed: tests (3.13, unit) (failure).
- CI failed: tests (3.14, e2e) (failure).
- CI failed: tests (3.11, e2e) (failure).
- CI failed: tests (3.14, unit) (failure).
- CI failed: tests (3.11, unit) (failure).
- CI failed: tests (3.12, unit) (failure).
- CI failed: tests (3.12, e2e) (failure).
- CI failed: upgrade-acceptance / Prepare upgrade artifacts and matrix (failure).
- Additional CI issues: PR checks.
hidb4ai
left a comment
There was a problem hiding this comment.
Re-reviewed c1485da1: the reported scoring regressions are fixed, and replay/pin rejects the prior instruction-bearing outputs while preserving valid attributed preferences. No remaining blocking findings within the reviewed scope. This change adds evaluation tooling without new HTTP/MCP/SDK business APIs, database tables, or migrations.
Which issue or RFC does this PR close?
Closes #2066.
Rationale for this change
Atomic Memory extraction could preserve imperative or second-person wording from historical evidence, causing durable preferences and constraints to be represented as instructions for a future agent.
This change strengthens the extraction contract so retained memories are subject-bound declarative propositions, while task-specific procedures remain outside Atomic Memory.
What changes are included in this PR?
codingandconversationAtomic Memory extraction prompts to.v2.The pinned live-run report used:
evaluation/memory/atomic_extraction/reports/atomic-extraction-20261019-03/report.mddeepseek/deepseek:deepseek-flash01024120s29/9passed6/600Are there any user-facing changes?
Atomic Memory extraction now produces subject-bound declarative statements instead of instruction-shaped memories.
There are no public API or schema changes. Existing Atomic Memory records are not rewritten or migrated, and search, ranking, reconciliation, lifecycle, and context preparation behavior remain unchanged.
How was this change tested?
make checkuv run pytest evaluation/memory/atomic_extraction/tests24 passeduv run pytest tests/builtin/artifacts/atomic_memory tests/builtin/artifacts/prompt tests/builtin/artifacts/memory208 passed, 3 skippedstatus=passed.AI usage statement
OpenAI Codex (GPT-5) was used to assist with implementation, tests, validation, and review fixes. DeepSeek
deepseek:deepseek-flashwas used only for the documented opt-in live generation evaluation.