Repository navigation
Conversation
AlexStocks
reviewed
Oct 15, 2026
| | Instance connection | plugin instance Runtime proves its own identity to management | | ||
| | External system | Stored and interpreted by plugins, optionally referenced in Config | | ||
|
|
||
| Before business execution, deployment verifies actual identities, registers Definitions, grants Scope permissions, records instance scope and connection identities, and checks access using execution credentials. Existing identity and Access interfaces are reused. Instances may be registered without Scope authorization but cannot accept work for that Scope. write has no separate execution credentials and does not borrow deployment authority for daily saves. Credentials are excluded from command arguments, catalogs, and ordinary logs; cross-machine connections use TLS or equivalent security. |
Contributor
There was a problem hiding this comment.
[P2] RFC 缺少模板要求的收尾章节,而它们恰好承载这个提案最需要的论证
对照 docs/en/rfcs/0000_example.md,本 RFC 只有 Summary / Motivation / Guide-level / Reference-level,缺 Drawbacks、Rationale and alternatives、Prior art、Unresolved questions、Future possibilities 五个章节。双语结构完全对齐(这点做得好),但两边同时缺。
这些不是格式仪式——对本提案恰好是最需要的部分:
- Drawbacks / 安全边界:框架要在 Server 侧加载并执行第三方插件代码(插件实例 Runtime 甚至跨机连接),这引入了任意外部代码执行面。文末「Permission responsibilities / Credentials」两节覆盖了授权与凭据,但没有一处集中讨论信任边界:插件代码以什么身份运行、崩溃/恶意行为的爆炸半径、是否需要进程隔离或 capability 降级。这是评审人必然会追问的问题。
- Rationale and alternatives:为什么不沿用 feat(sources): add Source Definition and Connector contracts #1400 已有的 Source Definition 注册表 + MCP 提交管线、只把「发现/加载第三方实现」做成一个薄扩展,而要引入独立的插件管理服务 + 实例 Runtime + 目标管理这三层?现有文中的论证散落在各节,缺少一个集中的方案对比表。
- Unresolved questions:插件签名/供应链校验、插件 API 的版本兼容承诺、collect 插件对 Server 稳定性的影响上限等,都还没交代由谁在何时决定。
作为 draft 这些可以后补;建议在转 Ready 之前补齐,尤其第 1 点。语言与结构质量本身没有问题。
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Proposes a new Source plugin framework RFC; no issue is closed.
Rationale for this change
Users need to develop custom Source plugins or use existing ones to support different data types, Projections, and collection logic without modifying PowerContext core. Applications and hosts need a common way to discover and use built-in and custom Source capabilities.
What changes are included in this PR?
Adds matching English and Chinese RFCs covering:
write: Server loads custom Definition and Projection implementations and synchronously saves complete content supplied by the caller.collect: plugins control collection timing and reuse the existing Worker, submission, and checkpoint pipeline.The RFC includes architecture and flow diagrams. Deployment guides and runnable plugin examples will accompany implementation.
Are there any user-facing changes?
Documentation only; no changes to runtime behavior or persisted data formats.
How was this change tested?
uv run prek run -a: all hooks, including type checking, passed.git diff --cached --check: passed before committing.Validation covers documentation only; the proposed functionality was not tested at runtime.
AI usage statement
Codex assisted with drafting, editing, and reviewing the bilingual RFCs based on the contributor's design decisions and feedback.