Repository navigation
Conversation
Implement issue01 of the Source evidence declarations specification. Bind trusted native and remote declarations to exact Source material and retain per-revision Atomic Memory snapshots in the existing transaction. Preserve neutral fallback, exact identities, scope authorization and public retrieval contracts. Add versioned p0004 migrations and SQLite persistence regressions. Refs oceanbase#1975. Full suite: 5255 passed, 431 skipped, 7 failed; introduced observability adapter failures fixed and its file passes 18 tests. Topic Memory vector failure also reproduces at the unchanged baseline.
Cover persisted declarations, scope isolation, historical neutrality, synthetic model trust claims, and unchanged recall consumers on SQLite and OceanBase.
MaoMengww
requested review from
AlexStocks,
PsiACE and
frostming
as code owners
October 14, 2026 17:47
Preserve the published p0004 artifact handle revision and introduce evidence as p0005. Retain both schema intents, recompute exact SQLite fingerprints, and update MySQL migration head expectations.
hidb4ai
requested changes
Oct 15, 2026
hidb4ai
left a comment
Contributor
There was a problem hiding this comment.
Please address the two native Source evidence issues below before merging. Both reproduce through public SQLite flows and break evidence inspection and projection rebuild after successful Memory generation.
hidb4ai
requested changes
Oct 15, 2026
hidb4ai
left a comment
Contributor
There was a problem hiding this comment.
Native Source evidence inspection and projection rebuild pass the input-alias and model-default scenarios. Remote observation ingestion still fails for serialization aliases; please address the inline P2 before merging.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue or RFC does this PR close?
Closes #1975.
Implements the Source authority and verification prerequisite in RFC #1652, while preserving the Source access and
lineage_onlysemantics in RFC #1458.Rationale for this change
Source generation eligibility does not describe the authority or verification of its material. Atomic Memory needs explicit, versioned evidence declarations that remain inspectable after registration changes, restarts, and projection rebuilds.
This change records those facts without introducing trust scores, ranking bonuses, or additional write authority.
What changes are included in this PR?
MemoryEvidenceDeclarationand exact Source material bindings through the existing Source Definition registry.untrusted/unknownvalues. Missing or corrupt authoritative Source material and database failures remain errors.p0005evidence schema migration for SQLite and MySQL-compatible backends, without backfilling historical trust.Are there any user-facing changes?
This adds optional Source Definition evidence declarations and a Python API for inspecting an exact Atomic Memory revision's evidence.
It does not change Atomic Memory bodies or content hashes, Artifact revision identities, HTTP/OpenAPI search schemas, public search scores, or citation identities. It introduces no quality ranking or new generation eligibility rules.
Persistence gains additive evidence tables. Existing Sources and Memory revisions without accepted declarations remain neutral; current configuration does not retroactively attest them.
How was this change tested?
make check: passed, including lock consistency, pre-commit checks, generated guidance checks, and type checking.make contract-test: 52 passed.make opendal-test: 8 passed; connector lint, formatting, and type checks passed.uv run --frozen --python 3.12 python -m pytest -n 6 --doctest-modules --require-dsh-config-runtimeThe initial full run under the local Python 3.11 / SQLite 3.37.2 environment exposed an existing Topic Memory vector-prefilter compatibility failure. A standalone SQLite reproducer isolated the cause: sqlite-vec's
rowid INKNN prefilter requires SQLite 3.38 or newer. The original test and full suite passed with the newer SQLite runtime, without changing code, assertions, or skip conditions.The complete GitHub Actions Python-version matrix has not been run locally.
AI usage statement
AI assistance was used through Oh My Pi with gpt-6.1sol for implementation, test design and consolidation, code inspection, and validation analysis.