Limit browser dock hang workaround to impacted Qt versions#527
Open
WizardCM wants to merge 1 commit into
Open
Conversation
WizardCM
added
the
kind/enhancement
RytoEX
requested changes
Jun 4, 2026
| bool QCefBrowserClient::OnSetFocus(CefRefPtr<CefBrowser>, CefFocusHandler::FocusSource source) | ||
| { | ||
| #if QT_VERSION >= QT_VERSION_CHECK(6, 8, 0) | ||
| #if QT_VERSION >= QT_VERSION_CHECK(6, 8, 0) && QT_VERSION < QT_VERSION_CHECK(6, 8, 8) |
Member
There was a problem hiding this comment.
All versions of Qt 6.9 would also be affected. While this was cherry-picked to the Qt 6.10 branch, it does not appear that it is part of any Qt 6.10.x release:
The earliest released version of Qt with a non-commercial release is Qt 6.11.1: qt/qtbase@b11acf4
Member
Author
There was a problem hiding this comment.
Ah, how frustrating. Fixed.
WizardCM
force-pushed
the
restore-dock-focus-qt
branch
from
e05142e to
6114a00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This restores prior behaviour of ignoring navigation events on startup to avoid the OBS window repeatedly stealing focus once for every browser dock being restored.
Motivation and Context
We've updated Qt. Qt have fixed the issue this code was meant to work around.
While working on #523 I was repeatedly impacted by this code not being run. I am thrilled to be able to re-enable it.
How Has This Been Tested?
Launched current OBS master with CEF 127 (our current shipping version) and ensured OBS doesn't hang and also doesn't repeatedly steal focus.
Types of changes
Checklist: