Repository navigation
Conversation
Ci-Attestation: {"at":1795126859,"gate":"data/all/compatibility","host":"linux-x86_64","key":"","lane":"client-checks","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":673,"stamp":"d622e44afa15dabd0b4296b87b1e5ce3","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126859,"gate":"data/all/flatpak-manifest","host":"linux-x86_64","key":"","lane":"client-checks","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":673,"stamp":"237e11a549ccd9fae337ea13383f0312","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126859,"gate":"data/all/qt-xml","host":"linux-x86_64","key":"","lane":"client-checks","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":673,"stamp":"69b7219fc330a424f4c7ce6ddc7b8476","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126859,"gate":"data/all/services-schema","host":"linux-x86_64","key":"","lane":"client-checks","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":673,"stamp":"42638a62d8e48f7143149fa55400147c","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126171,"gate":"general/all/client-lint","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"620a954bae1b582da575b47f4f3b21d9","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126859,"gate":"python/all/self-test","host":"linux-x86_64","key":"","lane":"client-checks","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":673,"stamp":"62caee4f052a2adbdc9cc28e4f35cf89","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126176,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"3ba2524ec358096e60640cca93f901af","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126176,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"780111b42dd53c8d37baf034d796ba21","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126174,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"93629964945fe2cde85de222b3174585","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126174,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"f43672d5ed11d5eb457d01617d31c20f","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126172,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"06d6ff0d8c74e4ac66f6ef24f69270fa","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126172,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"b687d7c4fe1cd3e2309e31840334ce37","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126175,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"fe59d24d14461e2977ff0bff063e58d9","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126175,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"e0bfd5419886f92e5d70379434df6532","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126173,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"a190269208cd9d65b873c262d7ed193b","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126173,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"9813ce13a9b78d6b85755591e767866c","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126172,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"81a9537911232f3ccd0a9a0254f31b09","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
Ci-Attestation: {"at":1795126172,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"97399461d404f95949d240f659a11cc670f1c8646f4d08c52327b8dc39055ac8","lane":"client-lint","parents":["f7aad870d24b40470f7b6d0d1d098d740696b83c"],"secs":183,"stamp":"3486dcfe718332c6e486788ad9bc2427","tree":"2c90cbb252aea43da69861dae3dcf7c4eb1f178d","v":1,"via":"run"}
zackees
enabled auto-merge
November 19, 2026 22:47
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #5284. Rust swap follow-up: #5285.
What and why
Move
obs_sceneitem_get_order_positionverbatim intolibobs/obs-scene-item-order-position.c.h. Scoped aliases reuse the existing full-scene lock boundary and preserve the pre-lock list-head read. The sorted core-source unity group supplies it to CMake and Cargo on Linux, macOS and Windows through the shared source manifest. The canonical graph and tests.d pointer register one cmocka fixture with the private-header dependencies and a watched extraction input.The characterization pins zero-based positions in lists of one through six items, reversed lists, group-local and nested counting, and the existing list-length result for an absent item. Valid inputs call both the real shared-library getter and a renamed copy of the exact extracted body. Probes also pin one balanced full lock/unlock and NULL/no-parent early returns without locking.
PR #2899 deliberately retains the permissive attached-item predicate in the legacy C reference: its public NULL/detached calls remain undefined. Those two cmocka assertions exercise the exact getter body with the existing hybrid predicate contract. A separate local check confirms that the actual hybrid public NULL/detached calls both return zero. The Rust swap must retain real-adapter coverage and this existing intentional difference. No held Rust-static support or link-support files are needed.
RED → GREEN
f7aad870d24b40470f7b6d0d1d098d740696b83c: replaying its committed archive with the configured Tier 2 compiler flags fails at the missing extraction include. Before RED, the original shared libraries passed the characterization with the exact-body probe supplied temporarily outside production's unity group.67e1aba974bbaa8cb15346c4bb4c5286e5581d54before proof stamping: adds that source and moves the unchanged body into the unity group. The published head is06cb0d7f603d74b4b4eb01b5e6c2bb80a440aad5, with the same validated source tree. The early RED push was refused because the preserved temporary source made the checkout dirty after safe-rm refused its location; RED and GREEN were published together.Validation
All four cmocka cases pass 25 consecutive runs per library before and after extraction. Final validation replays the eight affected native C compilation/archive/link edges from the configured Tier 2 graph. Before/after and C-reference/hybrid exports are identical (1,769 symbols). The separate actual-hybrid public NULL/detached check passes.
All 324 native-build contracts and both Linux-hosted Cargo/CMake fixture contracts pass. A three-host CMake inventory matches the common Cargo source-set inputs, selecting core-source exactly once. Focused build-group, source-set, Windows-diagnostic and registration checks pass. One-agent clud-review is clean. No new Rust executable is added.
Full
SOLDR_PORCELAIN=0 ./lintran once with a 1,800-second deadline and failed after 904.95 seconds in tooling self-tests: browser startup failed; the attestation suite exceeded its 600-second per-file limit and triggered the timeout reporter's mixed-bytes/string TypeError addressed by open #5283 (Refs #4896). A standalone full-lint pass is not claimed.Subsequent stock
./pushpassed Clippy and Dylint for all six shipping targets, the full repository self-tests (including browser startup and the attestation suite), and data validators. Its main host suite passed 9,264 tests with six skips. The alternate-feature Utilities suite passed 919/920; I stopped the remaining existingdead_pipe_write_survives_concurrent_spawnstest after 359.9 seconds. Consequently the host proof was not attested, final signing was not completed, and publication explicitly retained ordinary required PR CI. Native macOS/Windows C execution, Windows GNU test linking and the complete cmocka suite were not run locally.Checklist
master.