Skip to content

test: retry intermittent screenshot program-frame samples (Refs #3960) - #5277

Merged
zackees merged 1 commit into
masterfrom
fix/3960-known-flaky-screenshot
Nov 19, 2026
Merged

zackees merged 1 commit into
masterfrom
fix/3960-known-flaky-screenshot

Conversation

@zackees

@zackees zackees commented Nov 19, 2026 •

Copy link
Copy Markdown
Member

The screenshot sRGB fixture intermittently reads a black program pixel after taking a correct screenshot. The latest I210 occurrence on Dell runner dell-fsx3mn2-1 ejected a whole merge group in run 44558387230, job 135686841242. Register its exact CTest name, test_frontend_screenshot_srgb, in the existing known-flaky list so either affected subcase receives one audited retry. A second failure still fails the suite, and successful retries retain the issue-linked warning and job summary.

Refs #3960. This is the maintainer-assigned retry mitigation; the rendering investigation remains open. The C++ fixture, libobs, and all assertions are unchanged.

The add_test(NAME test_frontend_screenshot_srgb ...) registration matches the anchored entry. The Linux Tier 2 wrapper consumes this registry in both OFF and ON modes, with and without CPU-pinned scheduling; determinism repeats remain unwrapped. Existing self-tests validate registry syntax and retry behavior, but none requires this particular fixture to be listed or queries GitHub issue state. Issue #3960 was verified open.

Local RED evidence used the existing fake-CTest test harness with the production registry and this fixture name: before the entry, a simulated failure returned exit 8 after one CTest call. After the entry, the same failure followed by success returned exit 0 after two calls in both OFF and ON modes, including the #3960 warning and summary. This registry-only change has no shipped RED test commit; the diagnostic probe and RED/GREEN logs are retained in the worker response directory.

Validation: uv run --no-project -m unittest ci.test_tier2_known_flaky ci.test_tier2_schedule passed all 16 tests. The single SOLDR_PORCELAIN=0 ./lint run exited 1 in an unrelated existing timing self-test, test_tier2_serial_cpus.SerialRunTest.test_serial_tests_run_at_the_same_time_on_their_own_cpus: the two one-second probes did not overlap under load. The lint report is retained at /home/niteris/.clud/tmp/tool-output/local-test-private/local-test-dDSi04.log; the known-flaky and schedule self-tests passed within that run too. The isolated rerun of that one failing self-test passed in 1.615 seconds. No full lint rerun or unrelated scheduler change is included; ordinary hosted checks remain required. The required ./push wrapper subsequently passed its six-target client-lint lane (72.9 seconds), and its full self-test run passed the scheduler module, but test_platform_missing_prototypes.py timed out at 600 seconds (it had passed in 406.6 seconds during the standalone lint run). The wrapper therefore published with partial client evidence and ordinary PR CI; no native unit-test proof is claimed. The complete wrapper output is retained as push.log in the worker response directory.

Source audit: wait_for_painted_program already waits for a raw frame newer than its baseline with a nonblack pixel. After that wait returns, capture takes the screenshot and only then reads the shared program_pixel again. That later sample can belong to a different frame; the global pixel/frame counter also persists across cases. This supports the timing window already described in #3960, rather than proving that the assertion simply precedes the first render. No harness or libobs root cause was established, and no rendering reproduction or Tier 2 binary run is claimed. Rust unit/differential and protocol tiers are not applicable to this registry-only mitigation.

Ci-Attestation: {"at":1795117553,"gate":"general/all/client-lint","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"c458e0384e2dcfdbca50f8a91f7f4344","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117555,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"e2dcaabc6ac900cd0c75c926f2875e8d","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117555,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"2c55a843258ed38a9d8ecd7d34a89216","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117554,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"8a75cba3539ee837a5533267c1e1bc52","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117554,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"abb03546afa87a5d425b2c6274c5bf5c","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117554,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"bc152d75c58713f83a4349cf26e53647","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117554,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"6d5755080ec4a7fb102b3ab056587200","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117555,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"4db7e1e567cb507fc3975a5c553ecce3","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117555,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"e38106a378dc17aea118ce166a46261b","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117554,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"967a9001bb65266795a7142afd3d17fc","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117554,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"dfef2bc264479a336d048bf16f3d41d8","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117553,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"898d52cbd44db7859a2fa62e42fd0d56","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
Ci-Attestation: {"at":1795117553,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"5b67bf3bbcef0c5c16e774e8e4a574f8f619e53854b4a9695f1da2ccbf61f75c","lane":"client-lint","parents":["68a23db4360d1093faa2003fe6161188e5e9dc59"],"secs":73,"stamp":"319df84619da15047de01c4b621bdc89","tree":"bfb725ca632f8db669dcee015154016c6c540ef0","v":1,"via":"run"}
@zackees zackees added the pool-active Pool worker owns this PR; automated rebases must skip it label Nov 19, 2026
@zackees
zackees enabled auto-merge November 19, 2026 20:03
@zackees zackees removed the pool-active Pool worker owns this PR; automated rebases must skip it label Nov 19, 2026
@zackees
zackees added this pull request to the merge queue Nov 19, 2026
Merged via the queue into master with commit c24fc60 Nov 19, 2026
46 checks passed
@zackees
zackees deleted the fix/3960-known-flaky-screenshot branch November 19, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant