Repository navigation
graphics: port indexbuffer data/type queries to Rust (Refs #5241) - #5252
Merged
Merged
Conversation
Ci-Attestation: {"at":1795101944,"gate":"data/all/compatibility","host":"linux-x86_64","key":"","lane":"client-checks","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":292,"stamp":"90810a72dc103e11ac0971f27bf19638","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101944,"gate":"data/all/flatpak-manifest","host":"linux-x86_64","key":"","lane":"client-checks","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":292,"stamp":"0e0b4aee1e2ebf8aa13feb8793ada49b","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101944,"gate":"data/all/qt-xml","host":"linux-x86_64","key":"","lane":"client-checks","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":292,"stamp":"67bc3e7b42f06752a2b55fe2748f4067","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101944,"gate":"data/all/services-schema","host":"linux-x86_64","key":"","lane":"client-checks","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":292,"stamp":"bfa23af5b44beffbffdaf864a797c380","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101650,"gate":"general/all/client-lint","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"2ffe79f40aa68212abd8b481bcd4417a","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101944,"gate":"python/all/self-test","host":"linux-x86_64","key":"","lane":"client-checks","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":292,"stamp":"d67bcebdc24488c4a37d02da9edc7b4c","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101651,"gate":"rust/aarch64-apple-darwin/client-clippy","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"81c0fc7fe3cdf5d109a76b5213fb1268","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101651,"gate":"rust/aarch64-apple-darwin/client-dylint","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"6221383a869ad6cd74d6ffc70795a185","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101651,"gate":"rust/aarch64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"4fb10323e51b51e564b19e2b13162222","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101651,"gate":"rust/aarch64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"9040d880d35e3efc0c21c9301519237d","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101650,"gate":"rust/aarch64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"f71a846200d80980cd7cbb164e9d0c95","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101650,"gate":"rust/aarch64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"462f3c196f29ad9e60d0b62fe1d6daa1","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101651,"gate":"rust/x86_64-apple-darwin/client-clippy","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"bbe2dd94e1ae316db5258b90fc3171bd","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101651,"gate":"rust/x86_64-apple-darwin/client-dylint","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"c18de6e60195a66286315f893ef94867","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101650,"gate":"rust/x86_64-pc-windows-msvc/client-clippy","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"e2dc01ef0df93e9d5eabe3075c996997","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101650,"gate":"rust/x86_64-pc-windows-msvc/client-dylint","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"12adf31f722dc700ab284f85655edbb4","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101650,"gate":"rust/x86_64-unknown-linux-gnu/client-clippy","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"591a1eece8c586d1ba8ba9423be7a68e","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795101650,"gate":"rust/x86_64-unknown-linux-gnu/client-dylint","host":"linux-x86_64","key":"93111b4438f29efde821313aa55a364c102b350d709a098ddc35e7f45721ad09","lane":"client-lint","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":255,"stamp":"4059c0ecd9e95503622cbf59d1828291","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Ci-Attestation: {"at":1795102610,"gate":"rust/x86_64-unknown-linux-gnu/client-test","host":"linux-x86_64","key":"2acb01e87ea4b9ffc68558a62f29391f24c9672328a20149bd2683e85aaa6948","lane":"client-test-x86_64-unknown-linux-gnu","parents":["d6403134b79e91a92a66506a666b4422d41c1f58"],"secs":664,"stamp":"280cc3dfb5b788f2f188b59cf06f05bb","tree":"dd931add54df26111752eb5aa0a232d314e6cebf","v":1,"via":"run"}
Client-Checks: {"checks":{"base":"2ab51880d128cc5892ab1cc4291cb6931d1d8230","coverage":"all-tracked-applicable-files","diff":["libobs/build/libobs.core-source+.h.c","libobs/build/libobs.graphics+.h.c","libobs/build/libobs.ported-graphics-indexbuffer-queries+.h.c","libobs/build/ported-source-sets/graphics-indexbuffer-queries.json","libobs/cmake/rust-exports.d/obs-graphics-indexbuffer_queries.txt","libobs/graphics/graphics-indexbuffer-maintenance-fields.c.h","libobs/graphics/graphics-indexbuffer-queries.c.h","libobs/obs-source-audio-capture-callbacks.c.h","libobs/obs-source.c.h","rust/obs-c-oracle/legacy/graphics-indexbuffer-queries.c","rust/obs-c-oracle/oracle.d/graphics-indexbuffer-queries.list","rust/obs-c-oracle/oracle/indexbuffer_maintenance.c","rust/obs-graphics/src/ffi/indexbuffer_queries.rs","rust/obs-graphics/src/ffi/mod.rs","rust/obs-graphics/src/indexbuffer_queries.rs","rust/obs-graphics/src/lib.rs","rust/obs-graphics/tests/render/indexbuffer_queries.rs","rust/obs-graphics/tests/render/indexbuffer_queries_parity.rs","rust/obs-graphics/tests/render/main.rs","test/cmocka/build/test-graph.json","test/cmocka/test_source_audio_capture_callbacks.c","test/cmocka/tests.d/test_source_audio_capture_callbacks.cmake"],"head":"042d0733502c543ff9ef176793dd14592e97178b","tools":{"orchestrator-python":"3.14.7 (main, Aug 14 2026, 15:35:28) [Clang 22.1.3 ]","schema-dependencies":"3.14.7 (main, Aug 14 2026, 15:35:28) [Clang 22.1.3 ]\n{'jsonschema': '4.26.0', 'json_source_map': '1.0.5'}","uv":"uv 0.13.5 (x86_64-unknown-linux-gnu)","xmllint":"xmllint: using libxml version 21504\n compiled with: Threads Tree Output Push Reader Patterns Writer SAXv1 DTDValid HTML C14N Catalog XPath XPointer XInclude Iconv ISO8859X Regexps Automata RelaxNG Schemas Modules Debug"},"tracked-digest":"1a22112ec085a2b9f3eac8437bfe9196f4414c5b2e1db264cf634f0b1d17e786","tree":"dd931add54df26111752eb5aa0a232d314e6cebf"}}
zackees
enabled auto-merge
November 19, 2026 15:39
This was referenced Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #5241.
Port
gs_indexbuffer_get_dataandgs_indexbuffer_get_typeto the existing obs-graphics crate. The safe core checks the graphics context before the buffer and before every field projection, preserves exact diagnostics and the NULL/enum-cast-zero rejection values, and calls the matching mandatory backend callback exactly once. A successful NULL data result is forwarded without a diagnostic. This follows #5227's GPU-free fake-backend seam and reuses the real indexbuffer context/logging/dispatch adapter and its demand-linked support archive from #5190. No existing C tests, public C headers, WebSocket code, workflows or test graph were changed, and no Rust test executable was added.RED
d6403134bfails all three safe-core characterization mirrors attodo!()(exit 101). GREENf1e3ff53b6afpasses all five new Tier 1/3 tests, including the 72-case context/buffer/data/enum/query matrix and bounded random differential cases through the actual Rust ABI and real C adapters. The legacy oracle and both reference getter bodies are byte-identical to the prerequisite extraction. Flipping the Rust enum result makes both differential tests fail (exit 101); the original core was restored byte-for-byte and all five tests then passed again. The entire Graphics category passed 1,035 tests with no failures or skips; the wholenative_build::module passed 322 with no failures or ignores.Focused Linux Tier 2 built every one of the 65 configured standalone
*_rusttargets. The unchanged query characterization passed 25 repeats against the C reference (OFF) and 25 against hybrid libobs (ON), with identical sets of 1,769 dynamic symbols.ci/windows_link_check.pypassed the Windows MSVC category links and hybrid libobs plus all 56 configured Rust fixtures on both Windows MSVC x64 and Darwin ARM64. The separately invokedci/cmocka_link_check.py --alias mac-arm64also passed. The frozen C characterization was explicitly compiled and linked on both cross targets.Darwin binding evidence for #5226:
llvm-nm -mon the characterization Mach-O reports(undefined) external _gs_indexbuffer_get_data (from obs)and(undefined) external _gs_indexbuffer_get_type (from obs). The fixture's_get_dataand_get_typecallbacks arenon-externaldefinitions; the libobs Mach-O defines both public Rust getter symbols and contains the real_obs_graphics_indexbuffer_maintenance_dataand_obs_graphics_indexbuffer_maintenance_typeadapters asnon-external (was a private external). This fixture installs static export-table callbacks and replaces no global C function called by Rust, so it has no test-global interposition dependency. Full symbol evidence is retained inbuild_ci_audit/5241/darwin-{fixture,libobs}-nm.txt.Workspace Rust formatting passed. The single full
SOLDR_PORCELAIN=0 ./lintrun passed in 428.7 seconds (exit 0).Publication through
./push's proof/sign/publish engine passed six-target Clippy and Dylint, the complete repository client checks, 9,219 host tests (six skipped), 920 feature tests (none skipped), doctests and GNU Windows category linking. Final headf1e3ff53b6af20eca50b4b5453d9cc45a5dee1a0has 19 attestation records and a GitHub-verified valid signature; its tree is identical to the locally verified GREEN tree. Optional Swift proof was unavailable becauseswift-formatis absent; no Swift files changed.Test cost: across 25 reduced-parity runs of all five new tests together, the longest run was 0.01 seconds and peak RSS was 8,836 KiB. The tests create no threads. Forced-fetch/merge-tree preflight is clean against current master
9135554e3, including the merged active-shader extraction #5247; its pre-merge PR-head comparison was also clean. Overlapping #5155 has the same pre-existing conflicts against master and this branch; every temporary ref was deleted.There are no intentional behavior differences. Tier 4 does not apply to this non-protocol unit; no native Windows/macOS execution, complete cmocka-suite run or real-GPU qualification is claimed. Hosted CI remains the merge gate.