Skip to content

frontend: Answer a fallback warning that comes after shutdown - #2377

Merged
zackees merged 3 commits into
masterfrom
fix/2369-fallback-after-shutdown
Oct 25, 2026
Merged

zackees merged 3 commits into
masterfrom
fix/2369-fallback-after-shutdown

Conversation

@zackees

@zackees zackees commented Oct 25, 2026

Copy link
Copy Markdown
Member

Closes #2369. RED is pushed first; GREEN follows once CI shows the RED failure.

The new after_shutdown_answers_inside_warn case in test_fallback_warning_queue warns after SetMainWindow(nullptr). It must get one answer, accepted, inside the call, with the log line. A new main window must start the queue again.

…2369)

After SetMainWindow(nullptr) no event loop runs the queue, so a later
Warn() logs and accepts at once, inside the call, instead of queuing a
callback that never runs. A mutex that both take orders it against the
shutdown flush; a new main window starts the queue again. The policy doc
and the API reference now say the same about when cb runs.
@zackees
zackees marked this pull request as ready for review October 25, 2026 10:02
@zackees

zackees commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

RED, seen in CI: Tier 2 (tests ON) failed with [ FAILED ] after_shutdown_answers_inside_warn and only that case (1 of 521). The Fast Gate failed on clang-format in the new case, now fixed. GREEN is pushed.

@zackees
zackees enabled auto-merge October 25, 2026 10:02
@zackees

zackees commented Oct 25, 2026

Copy link
Copy Markdown
Member Author

Coordinator review (posted as a comment, since this account authored the PR): no blocking findings. This follows up nit 2 from my #2238 review.

  • Ordering: SetMainWindow(nullptr) sets fw_shut_down under fw_shutdown_mutex before closeWindow() runs sendPostedEvents, and Warn() checks the flag and queues under the same lock. So a warning either gets posted in time for that flush (where the pump, with no window, accepts it) or is answered inside the call. None is lost.
  • Restart: a later SetMainWindow(window) clears the flag, which the new case checks.
  • Docs: fallback-warning.md and the rst now describe the in-call answer for both the no-frontend and after-shutdown cases, which also fixes nit 1.
    The RED case is in. The PR is waiting on GREEN as described.

@zackees
zackees added this pull request to the merge queue Oct 25, 2026
Merged via the queue into master with commit 1e02b1d Oct 25, 2026
37 checks passed
@zackees
zackees deleted the fix/2369-fallback-after-shutdown branch October 26, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

frontend: Fallback warning: answer warnings after shutdown, and align the cb docs

1 participant