Repository navigation
frontend: Answer a fallback warning that comes after shutdown - #2377
Merged
Merged
Conversation
…2369) After SetMainWindow(nullptr) no event loop runs the queue, so a later Warn() logs and accepts at once, inside the call, instead of queuing a callback that never runs. A mutex that both take orders it against the shutdown flush; a new main window starts the queue again. The policy doc and the API reference now say the same about when cb runs.
zackees
marked this pull request as ready for review
October 25, 2026 10:02
Member
Author
|
RED, seen in CI: Tier 2 (tests ON) failed with |
zackees
enabled auto-merge
October 25, 2026 10:02
Member
Author
|
Coordinator review (posted as a comment, since this account authored the PR): no blocking findings. This follows up nit 2 from my #2238 review.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2369. RED is pushed first; GREEN follows once CI shows the RED failure.
The new
after_shutdown_answers_inside_warncase intest_fallback_warning_queuewarns afterSetMainWindow(nullptr). It must get one answer,accepted, inside the call, with the log line. A new main window must start the queue again.