Skip to content

rust: Port libobs/obs-encoder-get-name.c.h to obs-encoder #5253

Closed

Description

@zackees

Phase 6 direct Rust swap, after prerequisite #5044 characterized and extracted the unit. Refs #4239.

Port libobs/obs-encoder-get-name.c.h into the existing obs-encoder crate, retaining its C API/ABI and borrowed-pointer lifetime. NULL must return NULL and emit exactly one LOG_DEBUG diagnostic spelling obs_encoder_get_name and encoder; valid input must return the identical context.name pointer silently through a real private projection adapter, after the NULL check. Preserve rename observation and pointer identity.

Existing characterization: unchanged test/cmocka/test_encoder_get_name.c (four cases), plus test_context_names. Start with Tier 1 mirrors against a stub, then implement the safe core/FFI, original-C Tier 3 differential, and production swap. No public-header or existing-C-test edits.

Resolve the exact-name test double in rust/obs-output/tests/output/interleave_parity.rs without losing assertions. Verify obs-encoder/output tests, native_build, Linux OFF/ON Tier 2 and EVERY *_rust target, Windows MSVC and Darwin cross-links including symbol-binding evidence, formatting and full lint. Use #5190's shared adapter archive and #5226's private Rust-entry pattern where required.

Activity

  1. added
    portPort a C unit to Rust (four-tier policy)
    readyMeets the definition of Ready; claimable
    P2Normal priority
    on Nov 19, 2026
  2. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Claiming: encoder name direct Rust swap, pool encoder-get-name-swap in manager-owned slot fix5159. 1. Commit failing safe Rust mirrors of unchanged test_encoder_get_name. 2. Implement private projection, ABI swap, original-C differential and isolate the obs-output test seam. 3. Verify all requested local links/tests and publish a ready Refs #5253 PR today, subject to backpressure.

  3. zackees commented on Nov 19, 2026

    @zackees
    MemberAuthor

    Landed on master in #5257 (fa4ceee): obs_encoder_get_name now runs in safe Rust in obs-encoder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Normal priorityportPort a C unit to Rust (four-tier policy)readyMeets the definition of Ready; claimablesize:SHours

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions