Skip to content

rust: Port source audio-pause subscriptions to obs-source #4375

Open

Description

@zackees

Phase 5 follow-up to prerequisite #4374. After its characterization/extraction PR lands, port obs_source_add_audio_pause_callback and obs_source_remove_audio_pause_callback from libobs/obs-source-audio-pause-callbacks.c.h to rust/obs-source. Preserve source validation and identical callback/param registration and removal on both media_pause and media_stopped. Port the C characterization assertions 1:1 into the existing core category binary, add RED then GREEN commits, unchanged Tier 2 against hybrid and C reference, and Tier 3 differential coverage. Tier 4 is inapplicable to these local subscription helpers. Do not edit existing C tests or public headers. Dependency: #4374 must land first.

Activity

  1. added
    enhancementNew feature or request
    portPort a C unit to Rust (four-tier policy)
    P2Normal priority
    readyMeets the definition of Ready; claimable
    on Nov 9, 2026
  2. zackees commented on Nov 9, 2026

    @zackees
    MemberAuthor

    Claiming: Rust audio-pause callback port on branch port/4375-source-audio-pause, stacked on #4380 (bf59dc0), worker im-st-4375-audiopause in obs-studio13. 1. Add Tier 1 RED tests in the existing core binary. 2. Implement the safe core and FFI swap with Tier 3 oracle parity. 3. Run focused checks, fmt and full lint, then push a verified branch-only handoff today; no PR while the queue is backlogged.

  3. moved this from In progress to Ready in obs-rust Multiviewon Nov 10, 2026
  4. rdoupe commented on Nov 18, 2026

    @rdoupe
    Collaborator

    @zackees are you still on this one? It was claimed on 2026-11-09 and port/4375-source-audio-pause has a finished-looking commit from that day but no PR; both functions are still C on master. If you've moved on, I'll take it over tomorrow and build on your branch.

  5. rdoupe commented on Nov 19, 2026

    @rdoupe
    Collaborator

    Claiming: taking this over, no reply since my check-in yesterday. I'll swap both audio-pause subscription functions to safe Rust in obs-source, the same shape as the audio-capture callback swap in #5254, RED then GREEN with Tier 1-3 coverage.

  6. moved this from Ready to In progress in obs-rust Multiviewon Nov 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Normal priorityenhancementNew feature or requestportPort a C unit to Rust (four-tier policy)readyMeets the definition of Ready; claimablesize:SHours

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions