You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
rust: Port libobs/obs-display state accessors to obs-core #3848
Port obs_display_set_enabled, obs_display_enabled, and obs_display_set_background_color from libobs/obs-display.c.h into obs-core after verbatim extraction.
Phase and position
Phase 6 small core accessor slice, following the service accessor pattern #3842. Outside obs-service, obs-output, transition and parser work.
Dependencies and existing tests
All three functions remain in C; no matching Rust symbols or cmocka characterization calls exist. Add C-only characterization first (new test and registration fragment), extract verbatim in a separate behavior-neutral commit, then Tier 1 RED/GREEN in obs-tests-core, real-header layout checks, Tier 3 proptest oracle, unchanged Tier 2 OFF/ON, export parity and mutation check.
Notes
Preserve NULL no-op setters and NULL getter false; setters change only the requested field and retain all 32 color bits. No intentional behavior differences or protocol surface. Search found no open issue or PR for this slice; recent display PR #2259 concerns clear decisions only.
Claiming: display state accessors in slot obs-studio4, branch port/display-state-accessors.
Add C-only characterization for NULLs, enabled toggles, full-width color storage, and unrelated-field preservation.
Extract the three C bodies verbatim, then commit Tier 1 RED and open a draft PR today.
Implement obs-core shims and safe core, real-header layout and differential tests; validate Tier 2 OFF/ON, exports and mutation, then queue.
No work in obs-output, service or excluded series.
Implementation is in #3849, GREEN head a2f893c. Local Rust Tier 1/layout/differential: 6 passed; mutation dropping the high color byte kills both behavior parity tests, restored GREEN passes. Unchanged C characterization passes 3/3 on reference and hybrid, verified loaders and 1,767 identical exports. Focused Clippy, format and staged group inventory pass. Full lint encountered a soldr scratch-build lock refusal; full unittest/broad Tier 2 not run, documented in the PR. Final head is pushed; preparing pool handoff with auto-merge pinned to that SHA.
Activity
zackees commentedon Nov 7, 2026
Claiming: display state accessors in slot obs-studio4, branch port/display-state-accessors.
No work in obs-output, service or excluded series.
zackees commentedon Nov 7, 2026
/ready
test: link private display header dependencies (#3848)
obs-core: implement display state accessors with C parity (#3848)
obs-core: format accessors and retain mutation regression seed (#3848)
zackees commentedon Nov 7, 2026
Implementation is in #3849, GREEN head a2f893c. Local Rust Tier 1/layout/differential: 6 passed; mutation dropping the high color byte kills both behavior parity tests, restored GREEN passes. Unchanged C characterization passes 3/3 on reference and hybrid, verified loaders and 1,767 identical exports. Focused Clippy, format and staged group inventory pass. Full lint encountered a soldr scratch-build lock refusal; full unittest/broad Tier 2 not run, documented in the PR. Final head is pushed; preparing pool handoff with auto-merge pinned to that SHA.
test: characterize display state accessors (#3848)
libobs: extract display state accessors verbatim (#3848)
obs-core: add RED display state accessor tests (#3848)
test: link private display header dependencies (#3848)
obs-core: implement display state accessors with C parity (#3848)
12 remaining items
test: link private display header dependencies (#3848)
obs-core: implement display state accessors with C parity (#3848)
obs-core: format accessors and retain mutation regression seed (#3848)
test: account for display state in merged native inventory (#3848)
test: characterize display state accessors (#3848)
libobs: extract display state accessors verbatim (#3848)
obs-core: add RED display state accessor tests (#3848)
test: link private display header dependencies (#3848)
obs-core: implement display state accessors with C parity (#3848)
obs-core: format accessors and retain mutation regression seed (#3848)
obs-core: Port display state accessors (obs-rust#3848) (obs-rust#3849)