Skip to content

ci: lint ratchet against new shared build-file edits #3237

Closed

Description

@zackees

A ./lint check reporting when a PR touches a shared build path (ci_scope SHARED_PREFIXES/SHARED_FILES), with a ratcheted allowlist, so new central lists don't creep back after the split.

Part of #3232. RED: a ci/ test pins the new layout and its ci_scope mapping; GREEN: the move. Done when an edit of the kind described starts only the lanes it affects.

Activity

  1. added
    infraBuild, gate, CI and tooling
    P3Low priority
    on Oct 31, 2026
  2. zackees commented on Oct 31, 2026

    @zackees
    MemberAuthor

    /ready

  3. zackees commented on Oct 31, 2026

    @zackees
    MemberAuthor

    Claiming: taking this (last sub-issue of #3232). Plan: ci/test_shared_build_files.py lists every tracked file ci_scope treats as all-platform (is_shared, minus the Linux-only hidden fragments) and compares it with ci/shared-build-files.txt. A new shared file fails until it is listed with a reason, or moved to a per-OS or per-unit file; a removed one must leave the list, so the set only shrinks. Runs in ./lint with the other ci tests.

  4. self-assigned this
    on Oct 31, 2026
  5. zackees commented on Oct 31, 2026

    @zackees
    MemberAuthor

    Done in #3296 (merged f2dc8a3).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P3Low priorityinfraBuild, gate, CI and toolingreadyMeets the definition of Ready; claimablesize:SHours

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions