You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
build: split the OS branches of cmake/common into per-platform files #3234
Move the OS-specific parts of compiler_common.cmake, unity.cmake, groups.cmake and helpers_common.cmake into *-<os>.cmake files, and teach ci/platform_paths.py that they start only their OS, as libobs/cmake/os-<os>.cmake already does.
Part of #3232. RED: a ci/ test pins the new layout and its ci_scope mapping; GREEN: the move. Done when an edit of the kind described starts only the lanes it affects.
Claiming: taking this (part of #3232). Scoping found most OS code already lives in cmake// (which ci/platform_paths.py maps to one OS). Platform-only edits to cmake/common since Aug: the CEF macOS archive handling in buildspec_common.cmake (#2994, #3016) and the MSVC /wd exemptions in helpers_common.cmake (#2691). Plan: move those into cmake/macos/ and cmake/windows/ (keeping the call sites working on every host), RED test pinning no OS branches in cmake/common/, then GREEN.
Activity
zackees commentedon Oct 31, 2026
/ready
zackees commentedon Oct 31, 2026
Claiming: taking this (part of #3232). Scoping found most OS code already lives in cmake// (which ci/platform_paths.py maps to one OS). Platform-only edits to cmake/common since Aug: the CEF macOS archive handling in buildspec_common.cmake (#2994, #3016) and the MSVC /wd exemptions in helpers_common.cmake (#2691). Plan: move those into cmake/macos/ and cmake/windows/ (keeping the call sites working on every host), RED test pinning no OS branches in cmake/common/, then GREEN.
zackees commentedon Oct 31, 2026
Done in #3269 (merged 927c11b).
build(cmake): keep cmake/common host-neutral, move OS logic to cmake/…