Skip to content

build: split the OS branches of cmake/common into per-platform files #3234

Closed

Description

@zackees

Move the OS-specific parts of compiler_common.cmake, unity.cmake, groups.cmake and helpers_common.cmake into *-<os>.cmake files, and teach ci/platform_paths.py that they start only their OS, as libobs/cmake/os-<os>.cmake already does.

Part of #3232. RED: a ci/ test pins the new layout and its ci_scope mapping; GREEN: the move. Done when an edit of the kind described starts only the lanes it affects.

Activity

  1. added
    infraBuild, gate, CI and tooling
    P2Normal priority
    on Oct 31, 2026
  2. zackees commented on Oct 31, 2026

    @zackees
    MemberAuthor

    /ready

  3. zackees commented on Oct 31, 2026

    @zackees
    MemberAuthor

    Claiming: taking this (part of #3232). Scoping found most OS code already lives in cmake// (which ci/platform_paths.py maps to one OS). Platform-only edits to cmake/common since Aug: the CEF macOS archive handling in buildspec_common.cmake (#2994, #3016) and the MSVC /wd exemptions in helpers_common.cmake (#2691). Plan: move those into cmake/macos/ and cmake/windows/ (keeping the call sites working on every host), RED test pinning no OS branches in cmake/common/, then GREEN.

  4. self-assigned this
    on Oct 31, 2026
  5. zackees commented on Oct 31, 2026

    @zackees
    MemberAuthor

    Done in #3269 (merged 927c11b).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

P2Normal priorityinfraBuild, gate, CI and toolingreadyMeets the definition of Ready; claimablesize:MAbout a day

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions