Skip to content

macos: Finish release signing: run the setup script, then verify a signed release (follow-up to #2383) #2424

Open

Description

@zackees

Follow-up to #2383. The Apple side is ready, and one secret is set. What's left is listed below.

Done (2026-10-25)

  • Apple Developer Program renewed through 2026-10-25 → 2027-10-25. Team Zachary Vorhies (NCFFSNX26D).
  • MACOS_SIGNING_IDENTITY = Developer ID Application: Zachary Vorhies (NCFFSNX26D).
  • Setup script: gist. It makes the key and certificate request, takes the downloaded Developer ID certificate, builds the .p12, and sets the remaining secrets with gh secret set. No secret goes through chat.

To do

  1. Maintainer, on a Mac (needs gh logged in):
    bash <(curl -fsSL https://gist.githubusercontent.com/zackees/546bf7c0a5979ec8f4cff22be2346c3d/raw/f859e9022046292c9b96bc73460889640701a10f/macos-signing-setup.sh)
    
    It asks for the Apple ID email and opens the Developer ID Application certificate page (upload the request, download the .cer). Then it asks for an app-specific password from account.apple.com.
  2. Back up ~/obs-rust-signing (private key and .p12) somewhere safe.
  3. Coordinator: check that all five secrets are set: MACOS_SIGNING_IDENTITY, MACOS_SIGNING_CERT, MACOS_SIGNING_CERT_PASSWORD, MACOS_NOTARIZATION_USERNAME and MACOS_NOTARIZATION_PASSWORD. Then dispatch a release build of master.

Acceptance criteria

Activity

  1. self-assigned this
    on Oct 25, 2026
  2. zackees commented on Oct 25, 2026

    @zackees
    MemberAuthor

    All five MACOS_* secrets are set (2026-10-25 22:30 UTC). The certificate is Developer ID Application: Zachary Vorhies (NCFFSNX26D), issued by Developer ID G2 and valid until 2027-11-24. It was checked against its key, and the .p12 uses legacy encryption so security import accepts it. Verification run (verify_only, publishes nothing): https://github.com/obs-rust/obs-studio/actions/runs/40240506753

    Follow-up: the app-specific password was pasted into a chat log, so revoke it and set a new one once signing is confirmed (~/obs-rust-signing/set-notarization-secrets.sh).

  3. zackees commented on Oct 26, 2026

    @zackees
    MemberAuthor

    Status: signing + notarization work. #2428 prints Apple's notary log; #2430 (merged) signs Sparkle's and CEF's nested code; verify_only run 40246027884: both macOS builds Accepted and stapled. Policy in #2433; reusable ci.yml section proposed in forge-ci/ci.yml#462. Left before closing this and #2383: the next tagged release shows codesign/notarize true and the quarantine workaround leaves the release notes. Still open for the account holder: rotate the app-specific password that was exposed in plain text.

  4. zackees commented on Oct 26, 2026

    @zackees
    MemberAuthor

    What's left before this and #2383 close, after the coordinator's research:

    1. Release notes: drop the quarantine workaround. Filed as release: Drop the macOS quarantine workaround from the release notes now that the DMG is notarized (#2424) #2493.
    2. The macOS arm64 DMG shutdown crash (-11) is macOS arm64: packaged app crashes (SIGSEGV) during shutdown after reloading a saved capture profile #2432.
    3. Releases come from release-rust.yaml's daily schedule or a dispatch, not from tags pushed by hand, and it has failed since 2026-10-24: the Windows builds and the Windows x64 release gate. I dispatched a full release on master to get current evidence: run 40352480030.
    4. Once a run publishes, check both macOS jobs show codesign: true and notarize: true, then run spctl --assess --type execute and xcrun stapler validate on the DMG on a Mac.
  5. zackees commented on Oct 27, 2026

    @zackees
    MemberAuthor

    Triage: not Ready to hand to a worker yet — linked the open blocker as a real GitHub dependency (#2424 is now blocked by #2432, the macOS arm64 shutdown crash), so this leaves the triage list until that closes.

    State after the research above:

    1. Release notes (release: Drop the macOS quarantine workaround from the release notes now that the DMG is notarized (#2424) #2493) — closed, no longer a blocker.
    2. arm64 DMG shutdown crash — macOS arm64: packaged app crashes (SIGSEGV) during shutdown after reloading a saved capture profile #2432, open, now linked as the blocking dependency.
    3. The release pipeline itself: release-rust.yaml has not published since 2026-10-23; every run since has failed. The current daily schedule run (40529110726, 15:15Z) is still in progress and already has Release gate / Fast Gate and Native macOS x86_64 DMG startup red. That failure is not tracked by an open issue, so it needs the maintainer's attention (the Windows builds and the Windows x64 release gate have been the failing jobs since 2026-10-24).
    4. Final verification (spctl --assess --type execute, xcrun stapler validate on the DMG) still needs someone on a Mac — a verify-only run already produced an Accepted, stapled DMG on 2026-10-25 (run 40246027884), so this is confirmation, not new setup.

    Signing credentials: the five MACOS_* secrets are set as organization secrets in obs-rust (repo-scope gh secret list only shows the two update keys), so the "run the setup script" step is done. Nothing here is a coordinator action until #2432 closes and the release lane goes green.

  6. moved this from In progress to Blocked in obs-rust Multiviewon Oct 27, 2026
  7. zackees commented on Oct 28, 2026

    @zackees
    MemberAuthor

    Triage update — the blocker from the last comment is closed and the pipeline item now has its own tracker, so what is left here is maintainer-side, and I am relabelling it rather than leaving it in the triage list.

    What changed since 2026-10-27 17:24Z:

    1. macOS arm64: packaged app crashes (SIGSEGV) during shutdown after reloading a saved capture profile #2432 (the arm64 shutdown crash) is closed. Post-fix arm64 packaged startup is green on current master — run 40631862829, head 25fc4bc6e, verify_only=true, both Native macOS arm64/x86_64 DMG startup 🧪 success, with test(packaged-startup): Print crash-report evidence on a signal exit (#2714) #2718's crash-report capture armed and nothing printed.
    2. Item 3 (release lane red) is now tracked as release: the daily beta has not published since 2026-10-24 — every release-gate run fails #2725, and the last master-only red on it was the macOS packaging abort (infra: macOS DMG packaging aborts when the first hdiutil detach hits 'Resource busy' #2728), fixed by fix(packaging): Retry the macOS volume detach by device, not by a stale path (#2728) #2729. The same run 40631862829 built the arm64 DMG successfully (Build macos arm64 🧱 success, DMG created and identity-verified) and the macOS release gates are green.
    3. Item 1 (release: Drop the macOS quarantine workaround from the release notes now that the DMG is notarized (#2424) #2493, release-notes quarantine line) is closed.

    So the acceptance criteria are down to two, and neither is worker-executable:

    • a publishing release-rust.yaml run on master at or after 25fc4bc6e in which the two macOS jobs log codesign: true and notarize: true — verify_only publishes nothing, so this is a maintainer dispatch;
    • spctl --assess --type execute and xcrun stapler validate on the produced DMG, plus opening it without the Gatekeeper prompt — needs a Mac.

    There is no open decision and no code left to write here, which is why human-review-needed fits better than ready: a worker claim would stall on the two steps above. The signing credentials are already confirmed (five MACOS_* org secrets; a 2026-10-25 verify-only run produced an Accepted, stapled DMG), so this is confirmation and a publish, not setup. #2383 closes with it.

    Answer with a Decided: comment, or just remove the label, when the publish and the Gatekeeper check are done.

  8. moved this from Blocked to Needs decision in obs-rust Multiviewon Oct 28, 2026
  9. zackees commented on Oct 30, 2026

    @zackees
    MemberAuthor

    Decided: the publish criterion is met; what is left is one Mac check plus the password rotation, both for the maintainer, in one sitting. Then close this and #2383.

    Reasons:

    Maintainer, on a Mac:

    gh release download obs-studio-rust-v0.1.0-beta.20261028 -R obs-rust/obs-studio -p "*macos-$(uname -m | sed s/x86_64/x86_64/).dmg" -D ~/Downloads
    DMG=$(ls ~/Downloads/OBS-Studio-Rust-0.1.0-beta.20261028-macos-*.dmg)
    xcrun stapler validate "$DMG"
    hdiutil attach "$DMG" -mountpoint /Volumes/obsr
    spctl --assess --type execute -vv /Volumes/obsr/*.app
    open /Volumes/obsr/*.app   # must open with no Gatekeeper prompt
    hdiutil detach /Volumes/obsr

    Download the DMG with a browser instead of gh if you want the quarantine attribute set, which is the real user path.

    Then rotate the app-specific password that was pasted into a chat log (2026-10-25 comment): revoke it at account.apple.com, create a new one, and run ~/obs-rust-signing/set-notarization-secrets.sh.

    If all of that passes, close #2424 and #2383. If spctl rejects the app, post its output here and this goes back to a worker.

    Removing human-review-needed: no decision is left open, only the steps above.

  10. moved this from Needs decision to Triage in obs-rust Multiviewon Oct 30, 2026
  11. vpacher commented on Nov 13, 2026

    @vpacher
    Member

    Coordinator triage: only maintainer steps are left, so this issue is not a worker task.

    1. On a Mac, run the Gatekeeper check from the 2026-10-30 comment (stapler validate, spctl --assess) on the newest beta DMG.
    2. Rotate the app-specific password. Only the Apple account holder can do this.

    Then close this issue and #2383. Labelled human-review-needed, so the issue waits on the maintainer and leaves the triage list.

  12. moved this from Triage to Needs decision in obs-rust Multiviewon Nov 13, 2026
  13. rdoupe commented on Nov 14, 2026

    @rdoupe
    Collaborator

    The macOS release builds have been failing at notarization since 2026-11-13. This needs the Apple account holder, not a code change.

    Both Build macos arm64 and Build macos x86_64 build and package the DMG, then the notary submission is refused:

    Error: HTTP status code: 403. A required agreement is missing or has expired. This request requires an in-effect agreement that has not been signed or has expired.
    

    Runs: the scheduled release of 2026-11-13 (run 43468991070), the manual run of 2026-11-14 11:45 UTC (43591511399) and the scheduled release of 2026-11-14 (43611475920). The 2026-11-12 and 2026-11-11 runs failed earlier for other reasons (Windows Tier 2, AppImage on 22.04), so they never reached notarization.

    Fix: the account holder for team NCFFSNX26D signs in at developer.apple.com and accepts the updated Apple Developer Program License Agreement from the banner on the Account page. Apple shows it to the Account Holder role only. Then rerun the release workflow. The secrets and scripts need no change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Normal priorityhuman-review-neededEscalated: waits on the human maintainersize:SHours

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions