Skip to content

browser: Windows: run CEF with the sandbox (link cef_sandbox) #2379

Closed as not planned

Description

@vpacher

Summary

Split out of #1092 (item 2, Windows). On Windows, obs-browser still starts CEF with settings.no_sandbox = true: browser-sandbox has no probe for Windows, so the sandbox stays off. A renderer exploit in any page a browser source or dock loads then runs as the OBS user, with no sandbox escape needed (#1092). Linux uses the sandbox where it can work since obs-rust/obs-browser#3 and #8 (in master through #2378).

Scope

  • Link obs-browser-page.exe with cef_sandbox (the static library in the CEF binary distribution) and pass the sandbox info to CEF, as CEF's Windows sandbox requires.
  • browser-sandbox: a Windows decision. Where the sandbox can't work, the same fallback warning as on Linux (obs_frontend_warn_fallback(), id browser.sandbox, see docs/fallback-warning.md).
  • The CEF build for Windows must include cef_sandbox; the mirror in obs-rust/cef and the CEF version are browser: Upgrade the bundled CEF from 7871 (Chromium 150, end of life) to a supported Chromium #1864.

Acceptance criteria

  • RED then GREEN in obs-browser: the Windows decision and its warning, as tests/sandbox-decision.cpp does for Linux.
  • On Windows 10 and 11, a browser source renders with the sandbox on (the renderer process runs sandboxed), and where it can't, OBS logs the error and shows the warning.
  • docs/features.md: the sandbox line also names Windows.

Suggested: P2, size:M.

Activity

  1. zackees commented on Oct 25, 2026

    @zackees
    Member

    Triage: the scope and acceptance criteria are concrete, following the Linux work (obs-browser#3, #8). Labelled P2, size:M as suggested. Not Ready yet, because of WORKFLOW.md's rule that dependencies must be closed: it needs a Windows CEF distribution that ships cef_sandbox, which is #1864's Windows half, waiting on the maintainer's build-host decision. One part could start now: if the current Windows CEF 7871 archive in obs-rust/cef already includes cef_sandbox.lib, the Windows decision in browser-sandbox (RED → GREEN in tests/sandbox-decision.cpp) and the warning can land first, and the link step follows the CEF upgrade. A link to that archive's file list would settle it. Linking this to #1864.

  2. vpacher commented on Oct 25, 2026

    @vpacher
    MemberAuthor

    The file list of the Windows CEF 7871 archive in obs-rust/cef (cef_binary_7871_windows_x64.zip) settles it: there is no cef_sandbox.lib. Sandbox-related files are:

    include/cef_sandbox_win.h
    Release/bootstrap.exe
    Release/bootstrapc.exe
    

    cef_sandbox_win.h declares the entry points for "client DLLs using bootstrap.exe" (/SUBSYSTEM:WINDOWS) and bootstrapc.exe (/SUBSYSTEM:CONSOLE). As far as I know, this CEF version no longer ships a static sandbox library for Windows. The sandbox comes from bootstrap.exe instead: it is the main executable and the sandbox broker, and it loads the application as a DLL.

    This changes the scope of this issue:

    • The broker must be the browser process, and in OBS that is obs64.exe, not obs-browser-page.exe. Linking obs-browser-page.exe (the first item under Scope) does not work.
    • To use the sandbox, OBS on Windows must be built as a DLL that a renamed bootstrap.exe starts. That touches how OBS is built and started on Windows: the installer, code signing, the updater, the crash handler, and each other start path.
    • An own CEF build (browser: Upgrade the bundled CEF from 7871 (Chromium 150, end of life) to a supported Chromium #1864) does not change this, as far as I know, because the static library is not part of current CEF.

    So it is not an obs-browser change of size M. My suggestion:

    1. Change the scope to "OBS on Windows starts through CEF's bootstrap.exe", and resize it (size:L or larger).
    2. Get a maintainer decision on that architecture before someone starts.
    3. The Windows decision in browser-sandbox and its warning wait until then. Without the bootstrap they have nothing to decide.

    I do not claim this issue. For reference: on macOS the sandbox works with this CEF version without such changes (obs-rust/obs-browser#12, for #1092).

    AI note: Claude Code (Claude Opus 5.5) checked the archive and wrote this text under the submitter's direction.

  3. added
    human-review-neededEscalated: waits on the human maintainer
    size:LSeveral days
    and removed on Oct 25, 2026
  4. zackees commented on Oct 25, 2026

    @zackees
    Member

    Coordinator: escalating this to the maintainer. Thanks to @vpacher for checking the CEF 7871 archive: it ships no cef_sandbox.lib, so the Windows sandbox needs CEF's bootstrap.exe as the browser process. That means OBS on Windows would be built as a DLL and started through a renamed bootstrap.exe, which affects the installer, code signing, the updater, the crash handler and every other way OBS gets started. That is an architecture change, not an obs-browser size:M change, so I've relabelled it size:L.

    Decision needed: should OBS on Windows start through CEF's bootstrap.exe (OBS as a DLL), or should the Windows browser sandbox stay off for now, with this issue closed or parked until CEF changes? If you approve the bootstrap route, the issue gets rescoped and probably split (the build and start path first, then the obs-browser decision and its warning). Nobody should start on it before that.

  5. moved this from Triage to Needs decision in obs-rust Multiviewon Oct 25, 2026
  6. zackees commented on Oct 25, 2026

    @zackees
    Member

    Decided: not now. OBS on Windows won't be restructured into a DLL started through CEF's bootstrap.exe. That would change the installer, code signing, the updater, the crash handler and every start path, for one feature. The Windows browser sandbox stays off, as docs/features.md already says. Linux and macOS have it.

    I'm closing this as not planned. Reopen it if CEF ships a sandbox option for Windows that doesn't need the bootstrap (for example a static cef_sandbox again), or if the Windows start path gets reworked for another reason. The analysis above (thanks @vpacher) is the starting point.

    (Decided by the coordinator under the maintainer's go-ahead of 2026-10-25. The maintainer can reverse it.)

  7. moved this from Needs decision to Done in obs-rust Multiviewon Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P2Normal prioritysize:LSeveral days

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions