Repository navigation
Closed
Labels
readyMeets the definition of Ready; claimableMeets the definition of Ready; claimable
Description
Summary
Some features fall back to a less safe mode when the safe one cannot work, so that users do not lose them. The maintainer decided on #1092 (#1092 (comment)) how OBS tells the user, and that this is the policy for similar cases:
- Warn the user, with a 3-second progress countdown that auto-accepts "Accept anyway".
- Log the error to stderr.
- Tell the user that this may become a hard error in the future.
- Use standard terminology, and reword similar existing warnings to match.
Two features need this now:
- bug: browser: CEF 7871 (Chromium 150.0.7871.252, end of life, two in-the-wild V8 CVEs) runs with no_sandbox on every platform #1092: the browser source runs without the Chromium sandbox when no sandbox can work (Linux: use the CEF sandbox where it can work obs-browser#3 logs it; the warning is the next step).
- rtmp-services: Prefer RTMPS for services that support it, with fallback to RTMP #2205: the RTMPS → RTMP fallback, which proposes the same 3-second countdown.
One shared implementation keeps the dialog, the wording, the log line and the no-UI behaviour the same for both and for later cases.
Proposal
- A frontend helper, callable from the frontend and from plugins through the frontend API. It takes a short title, the message (what failed, what OBS does instead, and what the user can do about it), and an ID for the log.
- It logs the message at error level, so it is in the log and on stderr once (Linux and macOS echo error lines to stderr).
- With a main window: a warning dialog with a progress bar that counts down 3 seconds, an Accept anyway button, and a Cancel button when the caller can stop (for example a stream start). At the end of the countdown, or on Accept anyway, the caller continues in the fallback mode. Cancel lets the caller stop. The text includes one standard sentence: "This may become an error in a future version of OBS."
- Without a main window (obs-websocket
StartStream,--startstreaming, a headless start): no dialog. It logs, and the caller continues as with Accept anyway. - One dialog at a time. The same ID shows only once per session.
- A short policy doc (docs/): when a fallback uses the helper, the standard wording (for example "without the sandbox", "unencrypted", "Accept anyway"), and that new cases use it instead of their own dialogs.
- Callers: obs-browser (sandbox fallback, bug: browser: CEF 7871 (Chromium 150.0.7871.252, end of life, two in-the-wild V8 CVEs) runs with no_sandbox on every platform #1092) in a follow-up PR. rtmp-services: Prefer RTMPS for services that support it, with fallback to RTMP #2205 can use the helper for the RTMPS fallback.
Not in scope
- Rewording other existing warnings. This can follow under the policy doc, case by case.
- A setting to make a fallback a hard error ("Require the browser sandbox" from bug: browser: CEF 7871 (Chromium 150.0.7871.252, end of life, two in-the-wild V8 CVEs) runs with no_sandbox on every platform #1092 B stays a separate item).
Testing
- RED/GREEN unit tests for the helper's decision logic: countdown end → accept, Accept anyway → accept, Cancel → cancel, no main window → accept without a dialog, the same ID twice → one dialog, the log line at error level.
- One real run on Linux with the browser sandbox fallback (OBS as root), with the dialog, the countdown and the stderr line.
Metadata
Metadata
Assignees
Labels
readyMeets the definition of Ready; claimableMeets the definition of Ready; claimable
Type
Projects
- StatusShow more project fieldsDone
Activity
vpacher commentedon Oct 24, 2026
Claiming: #2218
Plan: RED tests for the decision logic, then the helper and the frontend API function, then the policy doc. The obs-browser caller (#1092) follows in its own PR.
vpacher commentedon Oct 24, 2026
Decision needed: how does the frontend link the Rust core of this helper?
The plan is the #846 pattern: the pure logic (dialog or accept at once, once per session, how each dialog end resolves, countdown progress, the log line with the standard sentence) in a new crate
rust/obs-fallback-warningwith#[test]s on its safe API, and only the Qt dialog andobs_frontend_warn_fallback()in C++.The frontend has one Rust staticlib today,
obs-gpu-status-frontend, and it builds only withENABLE_GPU_STATUS(the Flatpak sets it OFF). This warning is a security policy, so it must be in every build, and a second staticlib in the same binary would duplicate the Rust std symbols.Proposal: rename
obs-gpu-status-frontendto one general frontend staticlib (for exampleobs-frontend-rust), built whenever the frontend is built, that re-exports bothobs-gpu-statusandobs-fallback-warning.ENABLE_GPU_STATUSthen only switches the GPU light on or off. Cargo becomes a requirement of the frontend; the defaultOBS_LIBOBS_BACKEND=HYBRIDneeds it already, so only theOBS_LIBOBS_BACKEND=Crollback build changes. For that build, a small C++ fallback that logs and accepts.Alternative: write the core in C (as
frontend/utility/encoder-fallback.c.h) and port it later.I am writing the Rust crate and its tests now; only the linking waits for the answer.
zackees commentedon Oct 24, 2026
Decided: the proposal. One general frontend Rust staticlib, built whenever the frontend is built, that re-exports
obs-gpu-statusandobs-fallback-warning.ENABLE_GPU_STATUSthen only switches the GPU light.OBS_LIBOBS_BACKEND=Crollback build. A C++ fallback there that logs and accepts is fine.docs/rust-port/naming.md(ci/test_naming.pychecks it). Keep the rename in its own commit, so the GPU-status behaviour is visibly unchanged (Flatpak still OFF for the light).(Coordinator decision.)
github-actions commentedon Oct 24, 2026
Claim bot: @vpacher, the decision is in; your claim is no longer blocked.
rust: RED obs-fallback-warning, the shared fallback warning (obs-rust…
rust: obs-fallback-warning, the shared fallback warning (obs-rust#2218)
rust: Rename obs-gpu-status-frontend to obs-frontend (obs-rust#2218)
frontend: Build obs-frontend whenever the frontend is built (obs-rust…
14 remaining items
frontend: obs_frontend_warn_fallback(), the fallback warning API (obs…
frontend: Show fallback warnings on the main window, and document them (
test: Don't name the fallback warning crate in the dialog test's CMake (
frontend: RED fallback warnings wait for another modal dialog (obs-ru…
frontend: Fallback warnings wait for another modal dialog (obs-rust#2218
frontend: RED the fallback warning countdown pauses under a modal dia…
frontend: Pause the fallback warning countdown under a modal dialog (o…
docs: Standard wording for fallback warnings (obs-rust#2218)
frontend: Shared fallback warning with a countdown (obs_frontend_warn…
Warn when the CEF sandbox cannot work (#8)
obs-browser: Update to 4583599 (sandbox, fallback warning, audio fixe…
frontend: Use the shared fallback warning for RTMPS
rtmp-services: Stream over RTMPS where the ingest server accepts it (o…