Skip to content

test: finish Cargo native-build C/Rust parity validation after prototype launch #1390

Open
15 of 18 issues completed

Description

@zackees

Context

The maintainer explicitly requested wrapping up draft PR #1333 and deferring remaining C/Rust parity work when it would delay launching the Cargo/cc::Build prototype. This issue records that deferral; it does not claim parity or the full CMake replacement is complete.

The existing graph builds both real shared libobs variants, compares exports, and has 52 core test executables, six VLC tests, one graphics test and two standalone WHIP tests. Earlier completed runs include 104 core executions/832 reported cmocka cases, 50 VLC cases and eight group-audio cases; the standalone WHIP helpers pass eight cases once without a core/SDK. These are separate completed runs, not a claimed final-head combined pass. Four WebRTC unity/PCH modes and the original CMake reference pass real H.264/Opus streaming against both cores.

Coverage is incomplete: this checkout has 238 literal test-fragment executable declarations before platform/option evaluation; recent reference CI configured 299 tests. Those counts are not interchangeable. Final broad validation hit fixture errors and then a shared Soldr daemon connection failure; logs/limitations are recorded in docs/rust-port/cc-build.md.

Proposal

Complete the native-build compatibility/parity evidence after the initial prototype launch, preserving existing Rust implementations and existing tests.

Acceptance criteria

  • Generate an evaluated inventory of the original CMake/CTest graph for each supported configuration and map every applicable test to its Cargo build/run path; explicitly explain unsupported or environment-dependent cases.
  • Add missing native test graph entries with focused RED evidence, then GREEN implementation. Keep existing C/C++ tests and public headers unchanged; do not skip, weaken or retry failures to report green.
  • Run applicable unchanged tests against both real dynamically linked libobs variants, verify selected library loading and exact dynamic export parity, and preserve Rust unit/oracle differential tests.
  • Exercise applicable application/protocol behavior, feature options and saved profiles against both variants; include HEVC on/off and available unity/PCH configurations. Report physical/hardware/platform paths not exercised.
  • Obtain a successful final-head app/streaming validation and relevant CI gate; distinguish source failures, known owned bugs and infrastructure failures. Link concrete logs/results and update the draft's limitations.

Decisions

Related work

Refs #1332 and draft #1333. Existing #838 audio intermittency and #1283 recording-shutdown work retain their own ownership; this issue does not duplicate or claim their fixes.

Activity

  1. zackees commented on Oct 25, 2026

    @zackees
    MemberAuthor

    /ready

    Triage: a recorded deferral from #1333 with a concrete scope: finish C/Rust parity validation of the Cargo native build (exports compared for both shared libobs variants, the full cmocka set rather than the 52 core, 6 VLC, 1 graphics and 2 WHIP executables). Acceptance: the Cargo graph builds and runs every cmocka test CMake runs, in both modes, with matching export lists, and a test fails when a CMake-registered test is missing from the graph. Sub-issue of #1332. P3, size:M.

  2. zackees commented on Nov 3, 2026

    @zackees
    MemberAuthor

    Claiming: the next Qt-free frontend compatibility-test slice of the Cargo native graph.

    1. Add a RED contract that builds and runs the unchanged product-name and volume-meter snapshot tests through both the canonical CMake and Cargo graph consumers; both are still declared only in CMakeLists.txt and absent from the shared graph.
    2. Move their existing build requirements into the shared graph without editing the C/C++ tests or public headers, preserving threads and frontend include paths.
    3. Run focused contracts, lint and PR CI, and queue one scoped PR today. Refs test: finish Cargo native-build C/Rust parity validation after prototype launch #1390; the wider platform/application parity inventory remains open.
  3. zackees commented on Nov 3, 2026

    @zackees
    MemberAuthor

    Claiming: the missing Qt-free frontend utility compatibility tests in the canonical native graph (continuing after #3539).

    1. Add a RED build/run contract for stream-service selection, saved transitions, recording disk-space decisions, multitrack ladder and encoder override helpers.
    2. Move the five existing fragment definitions into the shared graph, preserving all sources and include/library requirements, without editing C tests or public headers.
    3. Run both actual Cargo and CMake consumers, focused tests, lint and PR CI, then enqueue one scoped PR today. Refs test: finish Cargo native-build C/Rust parity validation after prototype launch #1390; broad platform/application parity remains open.
  4. zackees commented on Nov 3, 2026

    @zackees
    MemberAuthor

    Claiming: the missing QtCore frontend API call compatibility-test graph slice.

    1. Add a failing canonical-graph contract for unchanged test_frontend_api_call and its original timeout/runtime requirements.
    2. Share its definition between Cargo and CMake, preserving the original C++ test/public headers, then run all four UI-thread dispatch cases through both consumers and compare evaluated CTest inventory.
    3. Run lint, independent review and required PR CI, then queue the validated head. Refs test: finish Cargo native-build C/Rust parity validation after prototype launch #1390; broader full-application parity remains open. First PR expected this iteration.
  5. zackees commented on Nov 3, 2026

    @zackees
    MemberAuthor

    Claiming: the missing Qt hotkey Backtab compatibility-test graph slice, continuing the existing native parity claim from checkout obs-studio3.

    1. Add a failing canonical graph contract for unchanged test_hotkey_edit_backtab and its Qt Widgets/Test/runtime requirements.
    2. Move its definition into the shared Cargo/CMake graph, preserve the original C++ test and headers, and run all eight key/focus cases through both consumers with exact CTest inventory.
    3. Validate optional Qt Test selection, lint, independent review and PR CI, then queue the validated head. Refs test: finish Cargo native-build C/Rust parity validation after prototype launch #1390; broader application parity remains open. First PR expected this iteration.
  6. 243 remaining items

  7. added a commit that references this issue on Nov 8, 2026
  8. zackees commented on Nov 8, 2026

    @zackees
    MemberAuthor

    Claiming: manager-assigned branch-only batch 42 in obs-studio2, stacked on test/1390-b41-land. Scout the five Qt/frontend/filename fixtures on current master, preserve complete original owner closures, then RED/GREEN registration and both-consumer GCC/Clang replay against both cores. No PR by assignment. Refs #1390.

  9. added 2 commits that reference this issue on Nov 8, 2026
  10. zackees commented on Nov 8, 2026

    @zackees
    MemberAuthor

    Claiming: manager-assigned batch 43 in obs-studio2. Split the camera GNU ld wrap boundary while preserving unity/PCH, add the native PulseAudio server to Tier 2, and register only fixtures passing five GCC repetitions in both cores. One focused RED/GREEN PR today. Refs #1390.

  11. zackees commented on Nov 8, 2026

    @zackees
    MemberAuthor

    Claiming: manager-assigned branch-only batch 44 in obs-studio2, based on the still-open batch 43. Scout the other-blockers inventory with original fragments and both core/compiler lanes; register only fully passing fixtures. No PR by assignment. Refs #1390.

  12. zackees commented on Nov 8, 2026

    @zackees
    MemberAuthor

    Claiming: manager-assigned landing of batch 44 in obs-studio2. Preserve the two batch commits on current master, add up to four qualified WebSocket helper registrations with target-local configured headers, validate both GCC core lanes, and open one PR. Refs #1390.

  13. zackees commented on Nov 8, 2026

    @zackees
    MemberAuthor

    Claiming: manager-assigned branch-only batch 45 in obs-studio2, stacked on batch 44 landing #4078. Register the remaining qualified WebSocket helper fixtures after RED/GREEN and four-lane repetitions; screenshot requires ten passes per lane. No PR by assignment. Refs #1390.

  14. added 2 commits that reference this issue on Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    P3Low priorityreadyMeets the definition of Ready; claimablesize:MAbout a day

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions