Skip to content

rtmp-services: ingest refresh waits poll every 10 ms for up to 5 s (flag mismatch; possibly on the UI thread) #1284

Closed

Description

@zackees

Part of #1273. B, possible UI stall (caller not yet traced).

Both wait for an ingest-list refresh by checking every 10 ms until a timeout:

  • plugins/rtmp-services/service-specific/service-ingest.c.h:132-138 (5 s): it checks ingests_refreshed but gates on ingests_loaded, so it can wait the full timeout even after a refresh has finished.
  • plugins/rtmp-services/service-specific/dacast.c.h:151-157.

If these are reached from the UI thread (Settings → Stream), that is up to a 5 s freeze.

To do:

  1. Trace the callers and confirm whether the UI thread waits here.
  2. Fix the flag mismatch in service-ingest.
  3. Replace the polling with a condvar or event signalled when the refresh completes.

Test: a refresh that completes after 50 ms ends the wait within ~one wake-up, not after the timeout.

Activity

  1. zackees commented on Oct 17, 2026

    @zackees
    MemberAuthor

    Claiming. Plan: trace the callers (UI thread or not), fix the ingests_refreshed/ingests_loaded mismatch in service-ingest, and replace the 10 ms polling in service-ingest and dacast with an event signalled when the refresh completes. RED: a refresh that completes after ~50 ms must end the wait within one wake-up, not after the timeout.

  2. added
    claimedAn agent or person has claimed this; check the claim comment before starting
    on Oct 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    claimedAn agent or person has claimed this; check the claim comment before starting

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions