Repository navigation
Update to 2.27.3 - #2
Merged
Merged
Conversation
OnShowPermissionPrompt is only called *once* when a page requests permission. If it is denied, even automatically, this code path will never be triggered again.
Fails to compile when this warning is turned into an error.
Adds additional hardening to the custom scheme handler for local files to ensure they are coming from a local file frame context. A fetch request made from an insecure page (http://) with the option "no-cors" may be delivered to the scheme handler successfully. A request made from a secure page (https://) already fails due to mixed content restrictions. This is additional protections for what is ultimately legacy functionality dating back to the original OBS Classic and we should consider removing the http://absolute handler entirely in a future update, instead preferring the sane defaults and handling of Chromium itself as it pertains to local files.
Passing a std::string to std::filesystem will use the system codepage. On Windows, this means it will interpret const char* as ANSI but the paths returned by libobs are utf8. If the path only contains ASCII characters, then everything is fine. If the path contains non ASCII characters, then it leads to errors.
chriscoveries
pushed a commit
to chriscoveries/obsrust-fork
that referenced
this pull request
Oct 22, 2026
Move plugins/obs-browser from 0c3b700 to 7bab463, the merge of upstream obs-browser 2.27.3 into obs-rust/obs-browser (obs-rust/obs-browser#2). The range also brings 4f26bda from obs-rust/obs-browser#1 (tests only). docs/rust-port/cc-build.md names the new pin. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream obs-browser 2.27.3 (
07227af) intomaster. It is a merge commit, as the mirror keeps the upstream commit hashes.Upstream commits since 2.27.1:
058c30fTemporarily recreate implied Localhost permissionsd0acf1cUpdate version to 2.27.29ecf652Fix unused variable warning6b6d456Additional restrictions on custom scheme handler4d341a6Fix handling of filepaths in migration07227afUpdate version to 2.27.3The merge has no conflicts with #1. Please merge it with a merge commit, not squash, so that the upstream hashes stay in the history. After it merges, I will open the
plugins/obs-browsersubmodule bump in obs-rust/obs-studio.Tested on Linux x86_64 (Debian 13, CEF 7871): obs-rust/obs-studio master
9f2253334with this branch builds with no new warnings. Browser sources render, from a local file and from an http:// page.🤖 Generated with Claude Code