Multisite support - #4
Open
lotimopa wants to merge 3 commits into
Open
Conversation
$this->io was still null when the executor was built, so the executor never got the IO object and the verbose output of the drush commands was silently dropped.
Docker based environments and CI images often have no global drush: only vendor/bin/drush exists. Every command then failed with "drush: not found", and as the plugin only reports the drush output as a comment the failure was easy to miss: the modules were simply never uninstalled. Fall back to the bin-dir drush when there is no global one, and add an extra.uninstall-drupal-modules.drush setting for the other cases.
On a multisite installation the plugin only ran drush on the default site: the modules stayed installed on the other sites, and their next config:import failed on the very configuration the plugin is meant to clean up -- silently, since a module absent from the default site already reports "nothing to do". List the sites in extra.uninstall-drupal-modules.sites and each pm:uninstall / theme:uninstall is run once per site, as a --uri= option or as a site alias. The site is added to the reported command so each line can be traced back. Without the setting nothing changes: a single target-less run, as before. The default and admin themes are now read per site too, as each site has its own system.theme configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.