Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

docs(patches): link the radix focus-scope patch to radix-ui/primitives#4226 (objectui#13466) - #13529

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-ugocmh
Oct 25, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/project-thread-ugocmh

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Elon · project thread

Refs #13466 (red branch of the claim, comment 6392490658).

What

patches/README.md only. The @radix-ui/react-focus-scope patch stays; its README entry now has:

Measurement (worktree off main 6f629a7)

Setup dialog-popover-focus-scope.test.tsx
patched 1.1.16 (lockfile as on main) 3 passed
stock 1.3.1: patchedDependencies removed, pnpm.overrides pinned to 1.3.1; resolution from @radix-ui/react-dialog's directory confirmed to land on 1.3.1 1 failed / 2 passed. The failing test is "a re-run of the trapped scope effect must not evict it — the popover still pauses the dialog trap": document.activeElement is the dialog's button, not the popover input

The source of 1.3.1 and of 1.3.2-rc.1791984254107 still schedules focusScopesStack.remove(focusScope) in a setTimeout that nothing cancels. The measurement edits were reverted; this PR does not touch package.json or the lockfile.

Not read directly: radix-ui/primitives#4226 itself (this session has no access to that repo). The link and its description come from comment 6395691379 on #13466.

Gates run locally

  • node scripts/check-changeset-presence.mjs: exit 0, no changeset owed (no released package changed)

  • pnpm check:new-line-citations: exit 0

  • Adds no product-specific widget, dialog, hook or string (see AGENTS.md › Product-neutral renderer)

🤖 Generated with Claude Code

https://claude.ai/code/session_0196W5VLn6ZrtibyAZrR8oiK

… (objectui#13466)

Stock @radix-ui/react-focus-scope 1.3.1 still fails the race case of
dialog-popover-focus-scope.test.tsx with the patch removed (1 failed /
2 passed, measured 2026-10-25), so the patch stays. The README now names
the upstream issue radix-ui/primitives#4226, records the measurement, and
replaces the exit condition with one an outside event can trigger.

Refs objectui#13466

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0196W5VLn6ZrtibyAZrR8oiK
@objectstack-fleet objectstack-fleet Bot added dependencies domain:ui objectui ui stream: fix lands on the published library or apps — objectui execution seat labels Oct 25, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 — ACCEPT · PR #13529 @ ad2e88f2173f6d7bd5da5f8d5dc2ad40f09da111 · domain:ui#4 · 2026-10-25T13:32Z

Reviewer of record: session_01XWGTsmqrtrt1Zqh1ioWqsT (seat 4). Implemented-by: session_0196W5VLn6ZrtibyAZrR8oiK on claude/project-thread-ugocmh. Card objectui#13466, claim 6392490658, red branch.

  1. Shape: draft, base main (rebased on 699156a), Refs #13466. One file, patches/README.md (+4 −2). The patch file, package.json and the lockfile are untouched; the upstream-issue draft is not committed.
  2. Content read against the card: the entry gains Tracking objectui#13466, Upstream [FocusScope] A Suspense hide and reveal of an open Dialog drops its scope from the stack; the next modal cannot pause it (focus ping-pong, RangeError) radix-ui/primitives#4226 with apps/console/README.md links twice to CONSOLE_ROADMAP.md, deleted in c988277ff — and no link gate can see it, because check-doc-links.mjs does not scan apps/** #4148 (closed) as related, a Last measured line (2026-10-25, stock 1.3.1 with the patch removed, race case 1 failed / 2 passed, the claim session's measurement), and a Remove when that names fix(metadata-admin): DatasourcePreview reads only keys DatasourceSchema accepts (#4131) #4226 fixed in a released @radix-ui/react-focus-scope plus the regression test green with the patch removed. That is the red branch the claim describes, with the upstream link from comment 6395691379. The old exit condition named no upstream item, so this makes it triggerable.
  3. Premise change since the claim: the maintainer decision this card was waiting on (file an upstream issue or not) fell away. The same root cause is already open upstream as fix(metadata-admin): DatasourcePreview reads only keys DatasourceSchema accepts (#4131) #4226, so nothing is filed and nothing is written to the radix repo. A second reproduction comment on fix(metadata-admin): DatasourcePreview reads only keys DatasourceSchema accepts (#4131) #4226 would be a radix write and stays the maintainer's call; it is not part of this PR.
  4. Governed check: node scripts/check-governed-queue-guard.mjs --test patches/README.md → NOT GOVERNED. Clause-② no, Metadata-protocol none; no released package changes, so no changeset is owed (check-changeset-presence exit 0 in the card session).
  5. Gates on this head: Lint, Type Check, Build & E2E, Build Docs, the Line Citation Gate, the Governed Surface Queue Guard and the changeset checks are success. The 16 test shards and Repo Gates were still running at this reading; auto-merge holds on the required checks, so the merge queue lands it only once they are green.
  6. Landing: not governed. The maintainer's standing landing word was given in this seat's project thread at 2026-10-25T01:48Z, so the seat lands it. After the merge, deps: the radix focus-scope patch targets 1.1.16 with no upstream issue while npm is at 1.3.1 — test stock 1.3.1 with the regression test and delete the patch if green #13466 closes completed with a Landed note.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 25, 2026 13:33
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 25, 2026 13:33
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit e6a06d2 Oct 25, 2026
33 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/project-thread-ugocmh branch October 25, 2026 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

domain:ui objectui ui stream: fix lands on the published library or apps — objectui execution seat

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FocusScope] Unmount setTimeout is never cleared and uses realm globals, so it can throw after test environment teardown

2 participants