This repository was archived by the owner on Oct 26, 2026. It is now read-only.
Repository navigation
docs(patches): link the radix focus-scope patch to radix-ui/primitives#4226 (objectui#13466) - #13529
Merged
Merged
Conversation
… (objectui#13466) Stock @radix-ui/react-focus-scope 1.3.1 still fails the race case of dialog-popover-focus-scope.test.tsx with the patch removed (1 failed / 2 passed, measured 2026-10-25), so the patch stays. The README now names the upstream issue radix-ui/primitives#4226, records the measurement, and replaces the exit condition with one an outside event can trigger. Refs objectui#13466 Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0196W5VLn6ZrtibyAZrR8oiK
Contributor
Author
席位核对 — ACCEPT · PR #13529 @
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elon · project thread
Refs #13466 (red branch of the claim, comment 6392490658).
What
patches/README.mdonly. The@radix-ui/react-focus-scopepatch stays; its README entry now has:setTimeoutis never cleared and uses realm globals, so it can throw after test environment teardown radix-ui/primitives#4148 as related.1.3.1with the patch removed, race case red (1 failed / 2 passed).@radix-ui/react-focus-scopeand the regression test is green on that release with the patch removed. The old condition named no upstream item, so nothing outside could trigger it.Measurement (worktree off
main6f629a7)dialog-popover-focus-scope.test.tsx1.1.16(lockfile as on main)1.3.1:patchedDependenciesremoved,pnpm.overridespinned to1.3.1; resolution from@radix-ui/react-dialog's directory confirmed to land on1.3.1document.activeElementis the dialog's button, not the popover inputThe source of
1.3.1and of1.3.2-rc.1791984254107still schedulesfocusScopesStack.remove(focusScope)in asetTimeoutthat nothing cancels. The measurement edits were reverted; this PR does not touchpackage.jsonor the lockfile.Not read directly: radix-ui/primitives#4226 itself (this session has no access to that repo). The link and its description come from comment 6395691379 on #13466.
Gates run locally
node scripts/check-changeset-presence.mjs: exit 0, no changeset owed (no released package changed)pnpm check:new-line-citations: exit 0Adds no product-specific widget, dialog, hook or string (see AGENTS.md › Product-neutral renderer)
🤖 Generated with Claude Code
https://claude.ai/code/session_0196W5VLn6ZrtibyAZrR8oiK