Skip to content
This repository was archived by the owner on Oct 26, 2026. It is now read-only.

chore(skills): mark the two repo-internal .claude skills metadata.internal (objectstack#25727) - #13514

Merged
os-zhuang merged 2 commits into
mainfrom
claude/project-thread-gxm6ze
Oct 25, 2026
Merged

os-zhuang merged 2 commits into
mainfrom
claude/project-thread-gxm6ze

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Tesla · project thread

Part of objectstack-ai/objectstack#25727
Part of objectstack-ai/objectstack#25677

Clause-②: no
Metadata-protocol: none

⛔ Governed surface (.claude/**). This PR stays a draft until an APPROVED review from an authorized approver (os-zhuang or hotlong) is on record; the merge-queue leg of the Governed Surface Queue Guard refuses it otherwise. No agent seat approves it.

What changes

Round 2 (b) of objectui-readiness 3. .claude/skills/objectui-contributor/SKILL.md and .claude/skills/verify/SKILL.md gain metadata: internal: true in their frontmatter, with a comment saying why. The merged objectstack repo's create-objectstack test ("skills catalog boundary") requires that marker on every SKILL.md outside the published skills/ catalog, so a repo-root npx skills add never offers these repo-internal skills to customers. Both stay internal (Tesla's decision D, 2026-10-25). skills/objectui/SKILL.md is not touched: it moves into objectstack's root skills/ catalog in the cutover commit. packages/plugin-dashboard/SKILL.md got the same marker in objectui#13512.

Frontmatter only: +8 lines, no instruction text changes.

Verification (local)

Gate Exit / verdict
node scripts/check-governed-queue-guard.mjs --test over the diff GOVERNED (.claude/** x2)
node scripts/check-changeset-presence.mjs no changeset owed
check:skills-paths, check:skill-examples, check:skill-eval-tokens, check:control-bytes, check:shell-escape-residue, check:new-line-citations, check:lint-rule-coverage 0 each
vitest: the 6 scripts/__tests__ files that read .claude/skills or SKILL.md 0 (305 tests)

🤖 Generated with Claude Code

Session: https://claude.ai/code/session_01K1ngdG6x8wAt8cjeVx2cSk

…ernal (objectstack#25727)

The merged objectstack repo's skills-catalog boundary test requires every
SKILL.md outside the published `skills/` catalog to carry
`metadata: internal: true` (Tesla's decision D: these two stay internal).

Part of objectstack#25727 (epic objectstack#25677).

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01K1ngdG6x8wAt8cjeVx2cSk
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Dispatch seat record. ACCEPTed as round 2 (b) on card objectstack#25727. check-governed-merges --pr objectstack-ai/objectui#13514 on the final file list: ⛔ GOVERNED — .claude/** ×2 (7 surfaces govern objectui), landing tier H: this PR needs an APPROVED review from a GOVERNED_APPROVERS member (os-zhuang / hotlong); the dispatch seat then flips ready and arms auto-merge. 8 changed lines (+8/−0). CI green on head ae88ed4a14 (16 Test shards, Type Check, Build & E2E, Lint, Repo Gates, changeset checks, governed guard pull_request leg). The approval ask has gone to the maintainer; no seat approves this PR, and no further push will land on the branch, so the approval stays valid.


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 25, 2026 10:54
@os-zhuang
os-zhuang enabled auto-merge October 25, 2026 12:58
@os-zhuang
os-zhuang added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit 867b937 Oct 25, 2026
32 checks passed
@os-zhuang
os-zhuang deleted the claude/project-thread-gxm6ze branch October 25, 2026 13:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants