docs(app-shell): the organization administrator creates and removes Setup holders by objectstack-fleet[bot] · Pull Request #13280 · objectstack-ai/objectui

objectstack-fleet · 2026-10-20T18:13:41Z

Fixes #13119
Clause-②: no

What

objectstack's shipped organization_admin (and organization_admin_no_bypass) now creates and removes rows on sys_user_position and sys_user_permission_set and never edits them (allowCreate: true, allowDelete: true, allowEdit: false), bounded server-side by the delegated-administration gate (its own organization, its own members, in-boundary sets only). objectstack-ai/objectstack#24732 landed it at b27f8ded5c, and objectui's .objectstack-sha (06cab4849a) carries it.

Four places here still said that administrator is read-only on both assignment objects and cited a retired objectstack pin. They now say what ships and cite the successor pin, organization_admin creates and removes assignment rows, never edits them — both variants (packages/plugins/plugin-security/src/objects/rbac-objects.test.ts, read at 06cab4849a):

packages/app-shell/README.md, "The Setup half of an item" (published in @object-ui/app-shell's files[], so it gets a patch changeset);
the comments above canAdd / canRemove in AssignedUsersSection.tsx and PositionHoldersSection.tsx;
setupHoldersGrant-12082.test.tsx: the header, and the ORG_ADMIN fixture, which is now the shipped shape (create and delete true, edit false, beside the super-user wildcard).

No behaviour change. Add still reads relatedNew (the create grant) and Remove still reads relatedRowDelete (the delete grant); neither reads allowEdit. Section logic is untouched.

Pins

(a) An organization administrator with the shipped grant is offered Add (and the picker it feeds) and Remove, in both sections. This passed against the unchanged sections, which confirms the client already does the right thing for the new grant.
(b) CONTROL: the same super-user wildcard beside explicit entries with neither create nor delete (the old read-only shape) is offered neither. The explicit entry still governs. The existing read-only / create-only / delete-only / full matrix and the no-provider control are unchanged.

Verification (at `ae98638bcf`)

pnpm exec vitest run --maxWorkers=1 packages/app-shell/src/views/metadata-admin/setupHoldersGrant-12082.test.tsx from the repo root, under the shared lock: Test Files 1 passed (1), Tests 20 passed (20).
Closure build turbo run build --filter="@object-ui/app-shell^..." --concurrency=2 (28/28 tasks) then @object-ui/app-shell type-check (tsc --noEmit && tsc -p tsconfig.test.json): exit 0. --listFilesOnly on tsconfig.test.json lists all three edited .tsx files.
eslint --format json on the three edited .tsx files: 3 files, 0 errors. Type-aware linting is off in eslint.config.js (no parserOptions.project), so this diff cannot change any verdict on an untouched file.
The pre-tsc battery (check:phantom-deps, self-import, unreferenced-sources, doc-example-readers, handler-key-reads, side-effects-array, element-data-source-declaration, spec-symbols, action-forward-parity, designer-field-key-parity, icon-record-names, i18n-keys, i18n-drift, i18n-designer-parity, control-bytes), check-hand-rolled-comment-mask.mjs and check-changeset-fixed.mjs: all exit 0.
Declared to CI: the full packages/app-shell/ test directory. Locally only the edited test file ran.

Generated by Claude Code

…olders objectstack's shipped organization_admin (and organization_admin_no_bypass) now creates and removes rows on sys_user_position and sys_user_permission_set and never edits them, bounded server-side by the delegated-administration gate. The README's "Setup half of an item", both holders sections' comments and the setupHoldersGrant fixture said it was read-only and cited a retired objectstack pin. They now say what ships and cite the successor pin; the fixture case asserts Add and Remove both show, and a control keeps the old read-only shape offering neither. No behaviour change. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB

github-actions · 2026-10-20T18:14:38Z

changeset-claim-re-read

⚠️ 1 pending changeset(s) describe a file this change touches

Their bodies publish verbatim into the CHANGELOG at the next release, so this is a request to re-read them against your diff — addressed here because you are the one seat that can answer it without re-deriving anything.

⛔ Nothing here blocks, and nothing here is a verdict on your change. This gate exits 0, is not a required context, and judges name resolution, never meaning: it asked whether a pending body names a file you touched. "Is this sentence still true?" is the one question it will not answer, and the one you are being asked to answer.

`.changeset/11806-login-server-unreachable.md`

names packages/app-shell/README.md → packages/app-shell/README.md — edited by this change

packages/app-shell/README.md documents the two new states in its sign-up table. Its useSignUpOffer recipe for hosts now asks decideSignUpOffer only once the read has answered, and answers unreachable for a failed read.

Read the paragraph, not the line: both false halves of the objectui#8617 claim sat in one paragraph, and correcting either alone would have left it asserting the same wrong thing.

If a claim did go false, correct the body. That is precedented and prose-only, frontmatter untouched; check-changeset-overwrite.mjs will report the correction as its own case 2 ("correcting a declaration on purpose … legitimate"), which is the intended shape — one gate asks for the read, the other records the write.

Not covered, stated so nobody reads this as more: a born-false claim that spells no line address at all (objectui#9495 coordinated one by ORDINAL — "a grep finds that member first" — and deciding that means reading what the sentence means), a claim spelled as a symbol or a package rather than a backticked file name, and a file named ambiguously.

Compared the checked-out tree with 8e649da7d (merge-base with origin/main): 4 file(s) changed outside .changeset/, read against 906 pending declaration(s) that publish a body (932 pending in total). · run

github-actions · 2026-10-20T18:17:20Z

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 78 chunks)	3222.5 KB	3744.1 KB
Main entry chunk (gzip)	82.3 KB	350 KB
Entry file	`index-CvrQmE7D.js`	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (buildIdentity.js)	0.80KB	0.49KB
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	21.41KB	7.90KB
app-shell (runtime-config.js)	24.52KB	8.48KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.11KB	3.87KB
auth (ActiveOrganizationStorage.js)	27.95KB	10.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	45.59KB	12.03KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	20.67KB	6.12KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.72KB	2.24KB
auth (SocialSignInButtons.js)	9.74KB	3.94KB
auth (UserMenu.js)	3.39KB	1.21KB
auth (auth-gate-events.js)	1.62KB	0.83KB
auth (authStyles.js)	5.27KB	1.86KB
auth (createAuthClient.js)	42.84KB	11.66KB
auth (createAuthenticatedFetch.js)	8.54KB	3.46KB
auth (index.js)	3.63KB	1.64KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	11.08KB	4.58KB
collaboration (CommentThread.js)	27.26KB	8.03KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.28KB	2.60KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (commentAuthorship.js)	1.39KB	0.78KB
collaboration (index.js)	1.93KB	0.85KB
collaboration (useCollaborationTranslation.js)	6.50KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	616.17KB	150.17KB
core (index.js)	10.18KB	4.04KB
create-plugin (index.js)	27.94KB	9.51KB
data-objectstack (index.js)	252.96KB	70.67KB
fields (index.js)	294.55KB	75.30KB
i18n (LocalizationContext.js)	2.92KB	1.42KB
i18n (builtinAggregateLabels.js)	0.86KB	0.49KB
i18n (currency.js)	2.59KB	1.22KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	8.87KB	3.64KB
i18n (index.js)	5.52KB	2.39KB
i18n (pickLocalized.js)	9.86KB	3.95KB
i18n (provider.js)	39.35KB	12.88KB
i18n (translateFn.js)	0.20KB	0.18KB
i18n (useDisplayLocale.js)	3.52KB	1.76KB
i18n (useObjectLabel.js)	36.87KB	9.88KB
i18n (useSafeTranslation.js)	7.14KB	2.92KB
layout (index.js)	41.40KB	12.01KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.99KB	0.87KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	6.62KB	2.45KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useSpecGesture.js)	5.52KB	2.10KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	15.35KB	5.51KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	6.82KB	2.38KB
permissions (discardProofCache.js)	1.04KB	0.55KB
permissions (evaluator.js)	8.33KB	3.07KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	4.83KB	2.27KB
plugin-ai (index.js)	16.04KB	3.92KB
plugin-calendar (index.js)	55.56KB	16.21KB
plugin-charts (index.js)	86.06KB	23.66KB
plugin-chatbot (index.js)	238.47KB	56.30KB
plugin-dashboard (index.js)	147.53KB	39.95KB
plugin-designer (index.js)	233.95KB	50.08KB
plugin-detail (index.js)	266.70KB	70.83KB
plugin-editor (index.js)	2.23KB	1.05KB
plugin-form (index.js)	186.64KB	48.54KB
plugin-gantt (index.js)	178.46KB	45.13KB
plugin-grid (index.js)	276.56KB	76.82KB
plugin-kanban (index.js)	64.49KB	19.83KB
plugin-list (index.js)	149.81KB	39.28KB
plugin-map (index.js)	27.17KB	9.00KB
plugin-markdown (index.js)	13.88KB	4.80KB
plugin-report (index.js)	46.66KB	13.13KB
plugin-timeline (index.js)	39.31KB	11.88KB
plugin-tree (index.js)	15.27KB	5.40KB
plugin-view (index.js)	94.54KB	24.33KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	12.07KB	3.68KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	126.45KB	41.40KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	4.71KB	2.11KB
react (schema-input.js)	4.31KB	2.07KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (body-dialect.js)	4.50KB	1.99KB
sdui-parser (codegen.js)	9.45KB	3.76KB
sdui-parser (dashboard-widget-options.js)	3.07KB	1.30KB
sdui-parser (index.js)	7.30KB	3.12KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	25.28KB	7.81KB
sdui-parser (provenance.js)	3.84KB	1.90KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	23.87KB	7.83KB
types (ai.js)	4.39KB	2.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	4.12KB	1.61KB
types (authoring-nodes.js)	0.20KB	0.19KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (cloud.js)	0.20KB	0.18KB
types (complex.js)	4.44KB	2.07KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (dashboard-widget-layout.js)	2.06KB	0.96KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (expression.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	1.13KB	0.65KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	5.78KB	2.70KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	5.00KB	2.39KB
types (navigation.js)	0.20KB	0.18KB
types (node-slots.js)	7.18KB	2.34KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	2.52KB	1.31KB
types (plugin-scope.js)	0.20KB	0.18KB
types (product-blocks.js)	0.20KB	0.19KB
types (record-approval-decision.js)	0.20KB	0.20KB
types (record-components.js)	0.20KB	0.19KB
types (record-panels.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (select-option.js)	0.20KB	0.19KB
types (spec-report.js)	4.99KB	1.96KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (strict-authoring-face.js)	19.93KB	7.26KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	8.48KB	3.50KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

objectstack-fleet Bot assigned baozhoutao Oct 20, 2026

github-actions Bot added documentation Improvements or additions to documentation tests package: app-shell labels Oct 20, 2026

objectstack-fleet Bot mentioned this pull request Oct 20, 2026

app-shell: the published README and the Setup holder sections still say objectstack's organization administrator is read-only on the assignment objects — objectstack#24732 gave it create and delete #13119

Closed

objectstack-fleet Bot mentioned this pull request Oct 20, 2026

[PM seat] domain:ui · seat 2 — 🟢 baozhoutao · session_01XVp19E1MYUTFM3dnkwz8gB · batch 1 (container restarts) · 70 landed · in flight #12625 #9771

Open

objectstack-fleet Bot marked this pull request as ready for review October 20, 2026 18:28

objectstack-fleet Bot enabled auto-merge October 20, 2026 18:28

objectstack-fleet Bot added this pull request to the merge queue Oct 20, 2026

Merged via the queue into main with commit b001d21 Oct 20, 2026
37 checks passed

objectstack-fleet Bot deleted the claude/issue-13119-org-admin-holders-docs branch October 20, 2026 18:42

objectstack-fleet Bot mentioned this pull request Oct 20, 2026

console: the permission-set editor keeps the clone notice "The copy is held by nobody yet" after users are assigned and the copy is saved #13272

Closed

Navigation Menu

Repository navigation

docs(app-shell): the organization administrator creates and removes Setup holders - #13280

docs(app-shell): the organization administrator creates and removes Setup holders#13280
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-13119-org-admin-holders-docs

objectstack-fleet Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

objectstack-fleet Bot commented Oct 20, 2026

What

Pins

Verification (at ae98638bcf)

Uh oh!

github-actions Bot commented Oct 20, 2026

⚠️ 1 pending changeset(s) describe a file this change touches

.changeset/11806-login-server-unreachable.md

Uh oh!

github-actions Bot commented Oct 20, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Verification (at `ae98638bcf`)

`.changeset/11806-login-server-unreachable.md`