Skip to content

fix(plugin-form): record:line_items hydrates an untyped column from the child field - #12914

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-12854-line-items-hydrate
Oct 17, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-12854-line-items-hydrate

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12854
Clause-②: no

The objectui half of objectstack-ai/objectstack#24140 (the spec describe landed in objectstack-ai/objectstack#24188).

What changed

  • LineItemsPanel (record:line_items) now passes its authored columns through hydrateColumns from deriveMasterDetail.ts, the same function the master-detail carriers call through deriveDetail. It was already exported, so deriveMasterDetail.ts is untouched. There is no second resolver.
  • The child schema it hydrates from is the one the panel already loads with getObjectSchema(childObject) for the save sanitize and the line affordances (A1). hydrateColumns takes it as is: its parameter is the structural ChildObjectSchemaLike (name?, fields?), and the panel's state is that shape or null (passed as undefined).
  • A column without a type takes the child field's label, type and options. Through the same function it also takes required, a lookup's reference / displayField, file props, readonlyWhen / requiredWhen and a formula's computed / expr, exactly as a master-detail grid's column does. An authored label or type still wins. A column whose field the child object does not declare is returned as written. Until the schema answers, the columns render as authored.

Translation path

The master-detail carriers do not translate a column heading on the client. The hydrated label is the one the object-metadata endpoint serves, and that endpoint translates the object document into the session locale (translateObject in @objectstack/spec/system, reading objects.CHILD.fields.F.label). The console adapter's schema cache is cleared on a language switch, so the next read is in the new locale. record:line_items now takes its heading from the same served label, so it translates the same way. The zh pin serves the child schema the way that endpoint answers a zh session.

Print page (A3)

A print page does not use a different renderer. record:line_items has one registration (ComponentRegistry.register('line_items', LineItemsPanelRenderer, { namespace: 'record' }) in packages/plugin-form/src/index.tsx), and it renders LineItemsPanel. On a page that declares print, the panel only reads usePrintPage() to name its row cap. Printed headings therefore go through the same hydration.

Pins

New packages/plugin-form/src/LineItemsPanel.childFieldHydration-12854.test.tsx, through the real panel and SchemaRendererProvider:

  • (a) an identity-only column is headed Quantity / Line status (the child field labels), not quantity / status;
  • (a, zh) under a zh I18nProvider, with the schema served in zh, the headings are 数量 / 行状态;
  • (b) the status cell is a select picker named by the hydrated label, showing the option label Open (zh: 未结) rather than the stored value open;
  • (c) CONTROL: authored labels Units / State are kept, and the field's type and options still apply;
  • (c) CONTROL: an undeclared note column is headed note and edits as a plain text input over the stored value.

Ablation, after the fix was committed (f58f1ce764), with scripts/ablation-replace.mjs from the objectstack checkout and a trap restore. hydrateColumns(schema.columns, childSchema ?? undefined) was replaced with schema.columns plus a marker comment. Anchor count went 1 to 0, and the blob went 892b35f0be3b to 85ce270d9929. All 4 tests went red: (a) failed with Unable to find role="columnheader" and name "Quantity", the zh case on 数量, and both controls on their hydration-dependent assertions. After the restore the blob read 892b35f0be3b, matching the HEAD blob, and git diff HEAD was empty. A first attempt that put back a bare schema.columns was refused by the tool before the run (the replacement text already occurred in the anchor, so its count could not rise), and nothing was run on it.

Verification (on f58f1ce764)

  • New test file: Tests 4 passed (4), lock verdict command-exit 0.
  • Closure build pnpm --workspace-concurrency=2 --filter '@object-ui/plugin-form^...' build: exit 0.
  • pnpm --filter @object-ui/plugin-form run type-check (tsc --noEmit && tsc -p tsconfig.test.json): exit 0. --listFilesOnly on tsconfig.test.json counts the new test file once.
  • eslint --no-inline-config on the 2 changed source files: 0 errors and 17 warnings. All warnings are on lines this PR did not touch (no-explicit-any, set-state-in-effect, exhaustive-deps).
  • The pre-tsc battery all exited 0: check:phantom-deps, self-import, unreferenced-sources, doc-example-readers, handler-key-reads, side-effects-array, element-data-source-declaration, spec-symbols, action-forward-parity, designer-field-key-parity, icon-record-names, i18n-keys, i18n-drift, i18n-designer-parity, control-bytes, scripts/check-hand-rolled-comment-mask.mjs, scripts/check-changeset-fixed.mjs and scripts/check-changeset-presence.mjs.
  • check:spec-floors: exit 1, no-artifact (the workspace was not fully built). Recorded, not fixed.
  • NOT MEASURED: plugin-form package dir, reason: lock queue. Three timed acquisitions (300 s, 360 s, 420 s) never reached the head while one holder ran a full packages/components/ vitest for more than 24 minutes, and an earlier whole-package run was cut by the foreground cap. This run is declared to CI.

Acceptance notes

  • The read-only table of the grid (GridField with readonly) draws a select cell as the stored value. Its cell sends only file and temporal columns through displayText, so displayText's select branch is not reached from that table. A read-only line-items panel therefore shows open, not Open, even after this change (measured while writing the pins). That is not this PR's scope, and it is reported to the seat.
  • Riders for objectstack's pin bump that carries this: see the domain:spec seat's note on the card.

Changeset: .changeset/12854-line-items-hydrate.md (@object-ui/plugin-form: patch).

Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB


Generated by Claude Code

…he child field

LineItemsPanel passes its columns through the same hydrateColumns the
master-detail carriers call, over the child schema it already loads. An
identity-only column takes the child field's label, type and options; an
authored label or type still wins, and an undeclared field renders as written.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 75 chunks) 3153.6 KB 3744.1 KB
Main entry chunk (gzip) 80.3 KB 350 KB
Entry file index-DGGgtQXv.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.42KB 7.85KB
app-shell (runtime-config.js) 23.60KB 8.19KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 45.59KB 12.03KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.67KB 6.12KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.74KB 3.94KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 42.84KB 11.66KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 610.72KB 148.41KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.83KB 69.44KB
fields (index.js) 291.60KB 74.45KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 41.33KB 11.96KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 210.60KB 49.94KB
plugin-dashboard (index.js) 146.23KB 39.59KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 265.18KB 70.24KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.24KB 46.60KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 272.78KB 75.66KB
plugin-kanban (index.js) 63.18KB 19.45KB
plugin-list (index.js) 139.66KB 35.98KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.27KB 5.40KB
plugin-view (index.js) 94.68KB 24.36KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.23KB 39.46KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants