Skip to content

fix(app-shell): Studio Interfaces names a package with no app by its display name (objectui#12718) - #12849

Merged
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-12718-studio-no-app-package-label
Oct 17, 2026
Merged

objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-12718-studio-no-app-package-label

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12718
Clause-②: no

What

On the Studio Interfaces pillar of a package that has no app yet, the rail heading and the pillar title now name the package by its display name, the same name the top bar shows, instead of its id.

  • Before: COM.QA.RECHECK · NAVIGATION and title com.qa.recheck, under a top bar reading QA Recheck.
  • After: QA RECHECK · NAVIGATION and title QA Recheck.

A package whose manifest declares no name still shows its id, because that is the only name it has.

A draft-only app (created, never published) is now named by the label its pending-draft row serves, as the shell header already names it, instead of by its machine name. A published app keeps its own label.

Mechanism (measured at main 5e15928)

  • InterfacesPillar started its app label with packageId. The app resolve returned on the no-app branch before it ever set a label, so the id stayed.
  • The package's display name was already in the surface's own fetchPackages() answer, the read it makes for the read-only gate. That read now also keeps the package entry, and the surface passes packageLabel to the pillar.
    • No request is added; the test checks that /api/v1/packages is read at most once.
    • The entry is stored with its id, so after a package switch the next package never gets the previous package's name. The pillar is also keyed on packageId.
  • The pillar now holds no app label until it finds an app, and reads app label, then package name, then package id.
  • The three readers are unchanged: the rail heading (through railAppLabel, objectui#12688), the pillar title, and the create dialog's description.
  • The draft-only path now reads the _drafts row's label (served since metadata-protocol/spec: the _drafts header carries no label, so a draft-only item can only be shown by its machine name (ListDraftsResponseSchema drops the label the repository already reads) objectstack#22200) and falls back to the app name.
  • The published path's final packageId fallback can never be reached: a row without a name drops to the drafts or no-app branch. It is left unchanged.

Tests

StudioDesignSurface.noAppPackageLabel-12718.test.tsx renders the real surface with the package list stubbed. It has 4 tests:

  1. A package with no app: the package name appears in the heading and the title, and the id does not appear in the pillar.
  2. A draft-only app with a label: its label is shown.
  3. CONTROL: a published app keeps its own label.
  4. CONTROL: a package with no declared name shows its id.

Ablation, with the fix committed first and a trap that restores the file:

  • Dropping the package-name fallback turns test 1 red.
  • Reading the draft name instead of the draft label turns test 2 red.
  • After both, the restored blob 9a25941 equals HEAD.

Family: 226 files that name StudioDesignSurface, appLabel, navHeading or displayAppLabel all pass (1855 tests).

Live reading

Backend from e2e/live/ci/start-backend.sh (published 18.0.0-next.2). POST /api/v1/packages with a named manifest and no app returned 201.

  • Before: the backend's published console and this branch's console with the file at 5e15928 both show the id.
  • After: this branch's console shows the package name.

Screenshots are on branch claude/issue-12718-evidence, under evidence/12718/. A live reading of a draft-only app was NOT MEASURED; the unit test covers it.

Acceptance notes

  • AppSchema.label is required by the spec, so the existing app-name fallbacks were left in their current order. The package name comes before the id only, not before an app's own name.
  • The surface's package read does not refetch on objectui:packages-changed (the top bar does). After a rename made elsewhere, the no-app heading updates on the next remount. Noted, not filed.

Clause-② reason: no export, type member, spec key or language-pack key changes. InterfacesPillar gains an internal prop and is not exported from the package entry.

Provenance: built by the cloud session session_017wgGVVegwUuFc4uhBx7Lot (claim 6228641111) and opened by the domain:ui seat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. The seat replaced the dev's footer line with this paragraph and changed nothing else.


Generated by Claude Code

…display name (objectui#12718)

The pillar seeded its app label with the package id and the app resolve
returned on the no-app branch before setting one, so the rail heading and
the pillar title read the id beside a top bar reading the package name.
The surface now hands the pillar the name from the package list it already
reads for the writability gate, and the pillar holds no app label until an
app is found. A draft-only app is named by its `_drafts` row's label.

Claude-Session: https://claude.ai/code/session_017wgGVVegwUuFc4uhBx7Lot
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 75 chunks) 3135.6 KB 3744.1 KB
Main entry chunk (gzip) 75.8 KB 350 KB
Entry file index-BLWuA40f.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.42KB 7.85KB
app-shell (runtime-config.js) 23.60KB 8.19KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 42.48KB 11.25KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.67KB 6.12KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.74KB 3.94KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 42.84KB 11.66KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 606.28KB 146.84KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.83KB 69.44KB
fields (index.js) 291.36KB 74.46KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.79KB 11.90KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 210.60KB 49.94KB
plugin-dashboard (index.js) 146.23KB 39.59KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 263.70KB 69.73KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.22KB 46.59KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 271.78KB 75.39KB
plugin-kanban (index.js) 62.17KB 19.22KB
plugin-list (index.js) 138.78KB 35.68KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 94.68KB 24.36KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.23KB 39.46KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 · ACCEPT · domain:ui seat 1 · session_011K9g23W67dy2zwnyzaoB6o · 2026-10-17T03:25Z

What was reviewed:

  • Head 2fde2f4, against objectui#12718.
  • The claim 6228641111 (triage's direction: seed the app label from the package's display name) and the dev's report with the seat's answers on the card (6228913965).
  • Tier: TIER_DEFAULT, the seat's own review. Clause-②: no is on line 2 of the body and in the changeset. No export, exported prop, spec key or language-pack key changes; InterfacesPillar's new prop is internal.
  1. Shape.
    • Fixes #12718 is the first line and the only closing keyword. The assignee is os-tesla.
    • 3 files, NOT governed (check-governed-merges --pr on this file list, 218 changed lines): StudioDesignSurface.tsx, one new surface-level test and one @object-ui/app-shell patch changeset.
    • The head's diff from its merge-base equals the fix and changeset commits line for line; the merge 2fde2f4 brings only main.
  2. The change.
    • The surface's existing fetchPackages() answer, the read behind the read-only gate, now also keeps the current package's entry. The entry is held with its id and passed to InterfacesPillar as packageLabel only when that id is the current package's. No request is added.
    • The pillar holds no app label until it finds an app. It reads the app's label, then the package's display name, then the package id.
    • The draft-only path reads the _drafts row's label, as the shell header's draft read already does.
    • The rail heading, the pillar title and the create dialog read the same value as before.
  3. Tests and evidence.
    • 4 surface-level cases: no app, a draft-only app with a label, and two controls (a published app's own label, and a package with no declared name).
    • Both ablations turned their case red, and the restored blob equals HEAD.
    • The dev's run: 226 test files, 1855 tests.
    • Live against a published 18.0.0-next.2 backend, a freshly posted package with no app: COM.QA.RECHECK · NAVIGATION / com.qa.recheck before, QA RECHECK · NAVIGATION / QA Recheck after. PNGs are on claude/issue-12718-evidence.
  4. Gates (check-runs pinned to this head).
    • 33 success and 3 skipped (coverage and dependabot, skipped by design), including Lint, Type Check, Test with all 16 shards, Test (dist pins), Build & E2E, Bundle Analysis, Repo Gates, Governed Surface Queue Guard and every changeset check.
  5. Recorded, not filed: the surface's package read does not refetch on objectui:packages-changed, so a rename made elsewhere reaches the no-app heading on the next remount. This is read from code, not reproduced, and is in the PR's Acceptance notes.
  6. Landing.
    • Ready, then the merge queue.
    • After the merge: verify by content, close the card through Fixes, strip pm:dispatched, and archive cloud session session_017wgGVVegwUuFc4uhBx7Lot.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 17, 2026 03:26
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 17, 2026 03:26
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 17, 2026
Merged via the queue into main with commit e1351a8 Oct 17, 2026
37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-12718-studio-no-app-package-label branch October 17, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants