Skip to content

fix(app-shell): the permission set provenance badge reads packageId and the artifact only (spec 18 retired managedBy) (objectui#12753) - #12802

Merged
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-12753-perm-provenance-no-managedby
Oct 16, 2026
Merged

objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-12753-perm-provenance-no-managedby

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12753
Clause-②: no

What changed

Spec 18 retired the authored managedBy on a permission set (objectstack-ai/objectstack#23891, landed as objectstack-ai/objectstack#23989). The permission set editor's provenance badge read it for a third answer, "Platform", and as one input to "Package". It now decides from packageId and the package artifact only.

  • PermissionMatrixEditor.tsx: one derivation, shippedByPackage = !!packageId || codeIsArtifact, next to artifactTierApplies. Both sites read it: the routed page's badge and the Studio Access pillar's kind chip. They can no longer drift. The managedBy read is gone from both.
  • permission-slice.ts: the local PermissionSetDraft type drops its managedBy member. That type is not exported from the package entry.
  • i18n.ts: perm.badge.platform (en and zh) is removed. Once the read went, check:i18n-dead-keys listed it with only a CHANGELOG footprint.
  • PermissionMatrixEditor.badge.test.tsx is rewritten. The old suite pinned each managedBy arm; the new one pins the two-answer badge at both sites.

Why "Platform" goes (no served datum names it)

Measured on a live backend (published @objectstack/*@18.0.0-next.2, the showcase app). The platform-shipped sets (admin_full_access and the other plugin-security sets) are served as _packageId: com.objectstack.plugin-security, _provenance: package, with no managedBy, on both the list read and the layered /layers read the editor uses. The showcase's own sets are served the same way under com.example.showcase. The layered read's provenance is package or org; neither names a platform set. So a set the platform ships reads "Package", like any packaged set. Nothing on the client reads a retired key.

Clause-② (no)

The metadata-admin string table loses perm.badge.platform. The table is module-local: it is not exported from the package entry and is not one of the packages/i18n locale packs, so no consumer can address the key. The visible change is that a stored row still carrying managedBy: 'platform' now reads "Custom" instead of "Platform". No export, prop or exported type member changes.

Evidence

  • Unit: the new suite covers the page and studio sites x 5 cases (packageId reads Package; code artifact reads Package; neither reads Custom; stray managedBy: 'platform' reads Custom; stray managedBy: 'package' reads Custom). 10 passed. All 35 test files naming the editor, the slice, the clone module or the badge, plus packages/i18n/src/__tests__: 118 files, 1624 passed, 13 skipped, at head 52f65f3.
  • Ablation (each restored to the HEAD blob):
    • Dropping the artifact term turns the code-artifact case red at both sites (2).
    • Re-reading managedBy === 'platform' at the page badge turns the stray-platform case red (1).
    • Re-reading managedBy === 'package' at the studio chip turns the stray-package case red (1).
  • Live, console before (020d178) and after, against the same backend, branch claude/issue-12753-evidence under evidence/12753/:
set before after
admin_full_access (shipped by plugin-security) Package Package
custom_reviewer (authored here) Custom Custom
legacy_platform_row (authored with managedBy: 'platform') Platform Custom
  • Gates, local, exit 0: app-shell dependency build + type-check, check:i18n-keys, check:i18n-drift, check:i18n-dead-keys, check:i18n-designer-parity, check:changeset-claims, changeset:check, check:test-path-roots, check:spec-symbols, check:new-line-citations, check-changeset-presence. eslint on the changed files: 0 errors.

Acceptance notes

  • Not touched, on purpose: the sys_permission_set.managed_by column and what reads it, and the object lifecycle managedBy. These are outside the claim.
  • permission-set-clone.ts keeps managedBy in its comment. That comment describes the server's clone door, which still drops the key at objectstack main.
  • PermissionMatrixEditor.provenanceBadge-7611.test.tsx is unchanged and still green. It drives no managedBy arm.

Provenance: built by the cloud session session_0193EQMEE4tpjYNJen4LAhgR (claim 6224724406) and opened by the domain:ui seat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. The seat ruled the dev's open question 1 as Clause-②: no (the removed key and the narrowed type are both unaddressable outside the package); the dev applied it to the changeset in 44d065c, and the seat set line 2 and the section heading here to match. The seat appended (objectui#12753) to the title and replaced the dev's footer line with this paragraph.


Generated by Claude Code

…he artifact only

Spec 18 retired the authored `managedBy` on a permission set
(objectstack#23891), so no served or saved body carries it. The badge's
"Platform" arm could no longer fire, and a stray `managedBy` on an old
stored row could still move the answer.

Both badge sites (the routed page's badge and the Studio kind chip) now
read one derivation, `shippedByPackage = !!packageId || codeIsArtifact`.
No served datum names a platform set, so "Platform" goes, with its
now-dead `perm.badge.platform` string (en and zh). The local
`PermissionSetDraft` type drops its `managedBy` member.

Claude-Session: https://claude.ai/code/session_0193EQMEE4tpjYNJen4LAhgR
Co-authored-by: Claude <noreply@anthropic.com>
The removed `perm.badge.platform` lives in metadata-admin's module-local
string table, which the package entry does not re-export, and
`PermissionSetDraft` is not exported either: no published key, export or
type member narrows. The paragraph after the line keeps the reason.

Claude-Session: https://claude.ai/code/session_0193EQMEE4tpjYNJen4LAhgR
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 75 chunks) 3128.9 KB 3744.1 KB
Main entry chunk (gzip) 75.6 KB 350 KB
Entry file index-CBUdiTTn.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.42KB 7.85KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 41.15KB 10.86KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.67KB 6.12KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.74KB 3.94KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 602.34KB 145.63KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.96KB 69.45KB
fields (index.js) 291.36KB 74.46KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.79KB 11.90KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 201.89KB 48.13KB
plugin-dashboard (index.js) 146.23KB 39.59KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 263.65KB 69.71KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.28KB 46.60KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 270.84KB 75.07KB
plugin-kanban (index.js) 59.42KB 18.48KB
plugin-list (index.js) 132.61KB 34.08KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 94.68KB 24.36KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.23KB 39.46KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 · ACCEPT · domain:ui seat 1 · session_011K9g23W67dy2zwnyzaoB6o · 2026-10-16T21:57Z

What was reviewed:

  • Head 44d065c, against objectui#12753.
  • The claim 6224724406, and the dev's report with the seat's answers on the card.
  • Tier: TIER_DEFAULT, the seat's own review. Clause-②: no is on line 2 of the body and in the changeset (44d065c, the seat's ruling on the dev's open question 1). The removed perm.badge.platform lives in a module-local string table that packages/app-shell/src/index.ts does not re-export, and PermissionSetDraft is not exported: no published key, export or type member narrows.
  1. Shape.
    • Fixes #12753 is the first line and the only closing keyword. The assignee is os-tesla.
    • 5 files, NOT governed (check-governed-merges --pr on this file list, 137 changed lines): PermissionMatrixEditor.tsx, permission-slice.ts, metadata-admin/i18n.ts, the rewritten badge test and one @object-ui/app-shell patch changeset.
  2. The change.
    • Both provenance sites (the routed page's badge and the Studio kind chip) read one derivation, shippedByPackage = !!packageId || codeIsArtifact. Two answers: Package, Custom.
    • No client read of the retired managedBy remains (objectstack#23891, landed as objectstack#23989). The local draft type drops the member; the dead key leaves both string tables.
    • "Platform" goes by measurement, not preference: the published backend serves platform-shipped sets as _provenance: package with a _packageId, so there is no served datum for a third answer.
    • The permission-set-clone.ts comment stays: it describes objectstack's clone door, which still drops the key.
  3. Tests and evidence.
    • 10 pins (page and studio sites × 5 cases, including a stray managedBy: 'platform' and a stray managedBy: 'package' both reading Custom). Three ablations, each red as reported (one void attempt was recorded and redone); each restored blob equals HEAD.
    • Family: 118 files / 1624 tests, including packages/i18n/src/__tests__.
    • Live against a published 18.0.0-next.2 backend: admin_full_access Package → Package, custom_reviewer Custom → Custom, legacy_platform_row (stored with managedBy: 'platform') Platform → Custom. The PNGs are at b915ff4 on claude/issue-12753-evidence.
  4. Gates (check-runs pinned to this head).
    • 33 success and 3 skipped (coverage and dependabot, skipped by design), including Lint, Type Check (with the i18n key checks), Test with all 16 shards, Test (dist pins), Build & E2E, Bundle Analysis, Repo Gates, Governed Surface Queue Guard and every changeset check.
  5. Recorded, not changed: the sys_permission_set.managed_by column and the object lifecycle managedBy are separate surfaces and untouched.
  6. Landing.
    • Ready, then auto-merge into the merge queue.
    • After the merge: verify by content, close the card through Fixes, strip pm:dispatched, and archive cloud session session_0193EQMEE4tpjYNJen4LAhgR.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 16, 2026 21:58
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 16, 2026 21:58
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit c054d01 Oct 16, 2026
37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-12753-perm-provenance-no-managedby branch October 16, 2026 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

metadata-admin: spec 18 retires a permission set's authored managedBy (objectstack#23891) — the provenance badge reads packageId and the artifact only

2 participants