fix(components): page:header reads the spec's variant 'danger' as destructive (objectui#12764) by objectstack-fleet[bot] · Pull Request #12798 · objectstack-ai/objectui

objectstack-fleet · 2026-10-16T21:13:30Z

Fixes #12764
Clause-②: no

The record header reads the spec's variant: 'danger' as destructive. Clause-② stays no: no prop, export or type member changes. The header reads its actions untyped, so no type union was widened, and an existing spec value now renders the way the spec defines it.

What changed

page:header (packages/components/src/renderers/layout/containers.tsx) has ONE predicate, isDestructiveAction (variant === 'danger' || name === 'sys_delete'). It decides the overflow menu's destructive band, its separator, the red row, the inline style and the primary pick. Before this, the menu carried its own copy of the test.
A danger action is never the filled primary. The primary is the first non-destructive row action, or the one declaring variant: 'primary' (objectui#12617's rule otherwise unchanged).
Shown inline, a danger action uses the existing Shadcn destructive button (no new variant). Folded, it is a red row below the separator.
variant: 'destructive' is no longer read. It is not a spec value (the enum is primary, secondary, danger, ghost, link: "danger = destructive"). The only header producer of it is the host's sys_delete, which is matched by name, so the Delete row is unchanged.
The registry description of maxVisible and content/docs/guide/slotted-pages.md state the rule.

Tests

New page-header-danger-12764.test.tsx (4 tests, the last a CONTROL for sys_delete and non-destructive actions). Each new behaviour was proven red by ablation: predicate back to destructive gave 3 failed; primary candidates unfiltered gave 2 failed; inline variant back to default/outline gave 2 failed. The control passed in every leg, and every leg was restored to HEAD blob 5af5a743. The family run on head 275db44 (code unchanged at 92659d8) gave 26 files and 812 tests passed. Type-check, changeset presence and claims, line citations, test-path-roots, spec-symbols and eslint were all clean.

Live reading

Published @objectstack/*@18.0.0-next.2 showcase, booted with e2e/live/ci/start-backend.sh. No showcase header action declares danger, so showcase_submit_signoff (invoice record_header) was given variant: 'danger' in the throwaway copy only. On INV-1004, before the fix: Submit for Sign-off was the filled primary and Edit was outline. After: Edit is the primary and Submit for Sign-off is the red destructive button. Screenshots are on branch claude/issue-12764-evidence under evidence/12764/.

Acceptance notes

RecordDetailView's host sys_delete and plugin-detail DetailView's systemActions (the action:bar surface) still write variant: 'destructive'. page:header now matches the Delete by name only. Not changed here: it is outside this card's surface.
Host applications outside objectui that might inject a non-sys_delete header action with variant: 'destructive' were not measured.

Provenance: built by the cloud session session_016x9qWsXaLgVtWMEpYeiNgo (claim 6224242831) and opened by the domain:ui seat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. The seat replaced the dev's two footer lines with this paragraph and changed nothing else.

Generated by Claude Code

…tructive (objectui#12764) One predicate decides destructive for the header's primary pick, inline style, overflow band, separator and red row; it reads the spec's `danger` (and the host's `sys_delete` by name), not Shadcn's `destructive`. A danger action is never the filled primary, draws the destructive button inline, and is a red row below the separator in the overflow menu. Claude-Session: https://claude.ai/code/session_016x9qWsXaLgVtWMEpYeiNgo Co-authored-by: Claude <noreply@anthropic.com>

…in (objectui#12764) Claude-Session: https://claude.ai/code/session_016x9qWsXaLgVtWMEpYeiNgo Co-authored-by: Claude <noreply@anthropic.com>

…ader-danger-variant

… action list (objectui#12764) Claude-Session: https://claude.ai/code/session_016x9qWsXaLgVtWMEpYeiNgo Co-authored-by: Claude <noreply@anthropic.com>

github-actions · 2026-10-16T21:16:32Z

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 74 chunks)	3128.0 KB	3744.1 KB
Main entry chunk (gzip)	75.6 KB	350 KB
Entry file	`index-zb8NvX6s.js`	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	21.42KB	7.85KB
app-shell (runtime-config.js)	22.59KB	7.89KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.11KB	3.87KB
auth (ActiveOrganizationStorage.js)	27.95KB	10.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	41.15KB	10.86KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	20.67KB	6.12KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.72KB	2.24KB
auth (SocialSignInButtons.js)	9.74KB	3.94KB
auth (UserMenu.js)	3.39KB	1.21KB
auth (auth-gate-events.js)	1.62KB	0.83KB
auth (authStyles.js)	5.27KB	1.86KB
auth (createAuthClient.js)	41.19KB	11.12KB
auth (createAuthenticatedFetch.js)	8.54KB	3.46KB
auth (index.js)	3.63KB	1.64KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	11.08KB	4.58KB
collaboration (CommentThread.js)	27.26KB	8.03KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.28KB	2.60KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (commentAuthorship.js)	1.39KB	0.78KB
collaboration (index.js)	1.93KB	0.85KB
collaboration (useCollaborationTranslation.js)	6.50KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	602.34KB	145.63KB
core (index.js)	10.18KB	4.04KB
create-plugin (index.js)	27.94KB	9.51KB
data-objectstack (index.js)	248.96KB	69.45KB
fields (index.js)	291.36KB	74.46KB
i18n (LocalizationContext.js)	2.92KB	1.42KB
i18n (builtinAggregateLabels.js)	0.86KB	0.49KB
i18n (currency.js)	2.59KB	1.22KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	8.87KB	3.64KB
i18n (index.js)	5.52KB	2.39KB
i18n (pickLocalized.js)	9.86KB	3.95KB
i18n (provider.js)	39.35KB	12.88KB
i18n (translateFn.js)	0.20KB	0.18KB
i18n (useDisplayLocale.js)	3.52KB	1.76KB
i18n (useObjectLabel.js)	36.87KB	9.88KB
i18n (useSafeTranslation.js)	7.14KB	2.92KB
layout (index.js)	40.67KB	11.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.99KB	0.87KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	6.62KB	2.45KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useSpecGesture.js)	5.52KB	2.10KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	15.35KB	5.51KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	6.82KB	2.38KB
permissions (discardProofCache.js)	1.04KB	0.55KB
permissions (evaluator.js)	8.33KB	3.07KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	4.83KB	2.27KB
plugin-ai (index.js)	16.04KB	3.92KB
plugin-calendar (index.js)	54.94KB	16.05KB
plugin-charts (index.js)	84.97KB	23.36KB
plugin-chatbot (index.js)	201.89KB	48.13KB
plugin-dashboard (index.js)	146.23KB	39.59KB
plugin-designer (index.js)	233.95KB	50.08KB
plugin-detail (index.js)	263.59KB	69.69KB
plugin-editor (index.js)	2.23KB	1.05KB
plugin-form (index.js)	180.28KB	46.60KB
plugin-gantt (index.js)	178.36KB	45.08KB
plugin-grid (index.js)	270.84KB	75.07KB
plugin-kanban (index.js)	59.42KB	18.48KB
plugin-list (index.js)	132.61KB	34.08KB
plugin-map (index.js)	27.07KB	8.96KB
plugin-markdown (index.js)	13.88KB	4.80KB
plugin-report (index.js)	46.66KB	13.13KB
plugin-timeline (index.js)	39.21KB	11.85KB
plugin-tree (index.js)	15.07KB	5.33KB
plugin-view (index.js)	94.68KB	24.36KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	12.07KB	3.68KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	120.23KB	39.46KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	4.50KB	2.06KB
react (schema-input.js)	4.31KB	2.07KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (body-dialect.js)	4.50KB	1.99KB
sdui-parser (codegen.js)	9.45KB	3.76KB
sdui-parser (dashboard-widget-options.js)	3.07KB	1.30KB
sdui-parser (index.js)	7.30KB	3.12KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	25.28KB	7.81KB
sdui-parser (provenance.js)	3.84KB	1.90KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	23.87KB	7.83KB
types (ai.js)	4.39KB	2.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	4.12KB	1.61KB
types (authoring-nodes.js)	0.20KB	0.19KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (cloud.js)	0.20KB	0.18KB
types (complex.js)	4.44KB	2.07KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (dashboard-widget-layout.js)	2.06KB	0.96KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (expression.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	1.13KB	0.65KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	5.78KB	2.70KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	5.00KB	2.39KB
types (navigation.js)	0.20KB	0.18KB
types (node-slots.js)	7.18KB	2.34KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	2.52KB	1.31KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-approval-decision.js)	0.20KB	0.20KB
types (record-components.js)	0.20KB	0.19KB
types (record-panels.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (select-option.js)	0.20KB	0.19KB
types (spec-report.js)	4.99KB	1.96KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (strict-authoring-face.js)	19.93KB	7.26KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	8.48KB	3.50KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

✅ Core packages should be < 50KB gzipped
✅ Component packages should be < 100KB gzipped
⚠️ Plugin packages should be < 150KB gzipped

objectstack-fleet · 2026-10-16T21:26:53Z

席位核对 · ACCEPT · `domain:ui` seat 1 · `session_011K9g23W67dy2zwnyzaoB6o` · 2026-10-16T21:26Z

What was reviewed:

Head 92659d8, against objectui#12764.
The claim 6224242831, and the dev's report with the seat's answers on the card.
Tier: TIER_DEFAULT, the seat's own review. Clause-②: no is on line 2 of the body and in the changeset. The header reads its actions untyped, 'destructive' was never a declared value, and no prop, export or type member changes.

Shape.
- Fixes #12764 is the first line and the only closing keyword. The assignee is os-tesla.
- 4 files, NOT governed (check-governed-merges --pr on this file list, 220 changed lines): containers.tsx, one new test, the slotted-pages.md guide bullet and one @object-ui/components patch changeset.
The change.
- page:header has one predicate, isDestructiveAction (variant === 'danger' || name === 'sys_delete'), read by the ⋯ destructive band and separator, the red row, the inline style and the primary pick. The menu's own copy of the test is gone.
- A danger action is never the filled primary: the primary is the first non-destructive row action, or the one declaring variant: 'primary' (objectui#12617's rule otherwise unchanged).
- Inline, a danger action is the existing Shadcn destructive button; folded, a red row below the separator. No new variant.
- 'destructive' is no longer read: the spec's enum refuses it, and its only header producer, RecordDetailView's host sys_delete (re-measured by the seat at main 020d178), is matched by name.
Tests and evidence.
- 4 pins, the last a CONTROL for sys_delete and non-destructive actions. Three ablations (predicate back to destructive, primary candidates unfiltered, inline variant back to default/outline), each red as reported with the control green; each restored blob equals HEAD.
- Family: 26 files / 812 tests.
- Live against a published 18.0.0-next.2 backend with showcase_submit_signoff given variant: 'danger' in a throwaway copy: on INV-1004, before, Submit for Sign-off was the filled primary; after, Edit is the primary and Submit for Sign-off is the red destructive button. The PNGs are at d83fb4b on claude/issue-12764-evidence.
Gates (check-runs pinned to this head).
- 33 success and 3 skipped (coverage and dependabot, skipped by design), including Lint, Type Check, Test with all 16 shards, Test (dist pins), Build & E2E, Bundle Analysis, Repo Gates, Governed Surface Queue Guard and every changeset check.
Recorded, not changed: RecordDetailView's sys_delete and plugin-detail DetailView's systemActions (the action:bar surface, its own renderer) still write 'destructive'; host apps outside objectui were not measured. Named in the body; no card.
Landing.
- Ready, then auto-merge into the merge queue.
- After the merge: verify by content, close the card through Fixes, strip pm:dispatched, and archive cloud session session_016x9qWsXaLgVtWMEpYeiNgo.

Generated by Claude Code

claude added 4 commits October 16, 2026 20:44

test(components): drop an unused import from the page:header danger p…

9dd36e7

…in (objectui#12764) Claude-Session: https://claude.ai/code/session_016x9qWsXaLgVtWMEpYeiNgo Co-authored-by: Claude <noreply@anthropic.com>

Merge remote-tracking branch 'origin/main' into claude/issue-12764-he…

275db44

…ader-danger-variant

docs(guide): page:header's variant 'danger' rule in the slotted-pages…

92659d8

… action list (objectui#12764) Claude-Session: https://claude.ai/code/session_016x9qWsXaLgVtWMEpYeiNgo Co-authored-by: Claude <noreply@anthropic.com>

objectstack-fleet Bot assigned os-tesla Oct 16, 2026

github-actions Bot added documentation Improvements or additions to documentation package: components tests labels Oct 16, 2026

objectstack-fleet Bot mentioned this pull request Oct 16, 2026

page:header ignores the spec's variant "danger": a danger action (leave_organization, delete_organization) draws as a filled blue primary, with no red row and no separator in ⋯ #12764

Closed

objectstack-fleet Bot marked this pull request as ready for review October 16, 2026 21:27

objectstack-fleet Bot enabled auto-merge October 16, 2026 21:27

objectstack-fleet Bot added this pull request to the merge queue Oct 16, 2026

Merged via the queue into main with commit 69a408f Oct 16, 2026
37 checks passed

objectstack-fleet Bot deleted the claude/issue-12764-header-danger-variant branch October 16, 2026 21:40

objectstack-fleet Bot mentioned this pull request Oct 16, 2026

feat(components,plugin-list): a list block in a narrow page region draws a compact list (objectui#12703) #12797

Merged

Navigation Menu

Repository navigation

fix(components): page:header reads the spec's variant 'danger' as destructive (objectui#12764) - #12798

fix(components): page:header reads the spec's variant 'danger' as destructive (objectui#12764)#12798
objectstack-fleet[bot] merged 4 commits into
mainfrom
claude/issue-12764-header-danger-variant

objectstack-fleet Bot commented Oct 16, 2026

Uh oh!

github-actions Bot commented Oct 16, 2026

Uh oh!

objectstack-fleet Bot commented Oct 16, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

objectstack-fleet Bot commented Oct 16, 2026

What changed

Tests

Live reading

Acceptance notes

Uh oh!

github-actions Bot commented Oct 16, 2026

✅ Console Performance Budget

📦 Bundle Size Report

Size Limits

Uh oh!

objectstack-fleet Bot commented Oct 16, 2026

席位核对 · ACCEPT · domain:ui seat 1 · session_011K9g23W67dy2zwnyzaoB6o · 2026-10-16T21:26Z

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

席位核对 · ACCEPT · `domain:ui` seat 1 · `session_011K9g23W67dy2zwnyzaoB6o` · 2026-10-16T21:26Z