Skip to content

feat(app-shell): console lists link names that point at another object's record (objectui#12673) - #12738

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-12673-list-cross-object-links
Oct 16, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-12673-list-cross-object-links

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12673
Clause-②: no

Ruling 6216810282, letter A: the console list host publishes the same any-object record links the record page holds. Lookup cells and referenceVia cells in every console list now link to the target record. A plain click opens it in the console; Ctrl-click, ⌘-click or a middle click opens a new tab.

First step: measurements (base 15d8ca6)

  1. Can the list host reach the routable-object set the detail bridge reads? Yes. AppContent mounts ObjectView and RecordDetailView with the same allObjects prop, and ObjectViewInner already reads appName from the route params. The bridge needs exactly those two inputs. The premise holds.
  2. Click areas in a dense grid. An in-cell link covers its own text only. Live on HotCRM at 1280 px, the account link measured 155 x 16 px inside a 180 x 41 px cell, inside a 1199 x 41 px row. The rest of the row stays the row's click. Two independent guards keep a link click from also opening the row: the anchor's own stopPropagation, and data-table's row handler, which ignores targets inside an anchor. The primary link column masks the host for its children, so no anchor nests in an anchor (the objectui#11817 rule; live nested-anchor count on the opportunities list is 0).

What changed

  • One builder, shared. RelatedRecordActionsBridge exports its existing record-path builder as two pure functions: routableObjectNames(objects) and appRecordPath(appName, routable, objectName, recordId). The bridge's own recordPath now calls them and still appends its ?from= trail. The record page behaves the same, and a CONTROL test pins it.
  • List host. listRecordActionsValue takes an optional routes argument (appName, objects, navigate, routerRootHref). With it, a record of ANOTHER routable object gets the record page's route /apps/APP/OBJECT/record/ID. It is published as a document href through the existing documentHref join, so a new tab or a copied link carries the console's base path. A plain click navigates by router path. No ?from= entry is added, because a list page has no parent record. The listed object keeps its own route and its own record navigation, which carries the list as the record's origin. A non-routable object, a missing app segment or an empty id answers no href, so the cell renders plain text.
  • ObjectView passes the routes: the route's appName, its objects prop, useNavigate() and useHref('/').
  • No change in plugin-grid or fields. RecordPointerCell and the lookup cell's ReferencedRecordLink already draw an anchor whenever the host answers.
  • Targets that cannot be opened. An unreadable or missing record-pointer target keeps its 'record unavailable' face and draws no anchor. A lookup whose target the server does not serve draws nothing. An object the console cannot route to stays plain text.
  • No metadata key, no spec change. Nothing new is reachable from the @object-ui/app-shell package entry: src/index.ts and views/index.ts export only ObjectView and ConsoleObjectViewProps by name, and package.json exports only ..

Live evidence (HotCRM, 1280 px)

Screenshots are on the evidence branch claude/issue-12673-evidence (commit cb648c3c), which is never merged here:

  • Setup, Approval Requests, focus on a record-name link: light · dark
  • Opportunities list, account lookup, focus on the first account link: light · dark

Link hrefs read from the DOM at capture, three rows each:

List Name href
Approval Requests Initech Cloud Migration /apps/setup/crm_opportunity/record/hIpgtKHxyIJ3DC3k
Approval Requests Vertex Enterprise Rollout /apps/setup/crm_opportunity/record/SlLJR9-9feAptafn
Approval Requests Northwind Grid Modernization /apps/setup/crm_opportunity/record/MoY9r6pUTH95OuQP
Opportunities ACC-000007 - Vertex Analytics /apps/crm_enterprise/crm_account/record/uaNdkA6LmpFLgdYU
Opportunities ACC-000005 - Wayne Enterprises /apps/crm_enterprise/crm_account/record/C6-rE8KonvJsu_6h
Opportunities ACC-000008 - Lattice Education /apps/crm_enterprise/crm_account/record/2wJu02KNnNzivci5

Clicked live:

  • An account link opened /apps/crm_enterprise/crm_account/record/uaNdkA6LmpFLgdYU (heading 'Vertex Analytics').
  • An approval request's record link opened /apps/setup/crm_opportunity/record/hIpgtKHxyIJ3DC3k (heading 'Initech Cloud Migration').
  • Ctrl-click opened the same href in a new tab while the list stayed. A middle click also opened a tab.
  • A click on the Stage cell, which holds no link, opened the row's own record /apps/crm_enterprise/crm_opportunity/record/SlLJR9-9feAptafn.

Tests (on 1a00c21)

  • __tests__/listCrossObjectCells-12673.test.tsx (8): real ObjectGrid and cell renderers under the real listRecordActionsValue, fed by the router's navigate and useHref, basename /_console. React-router's Link is the href oracle. Covers:
    • a lookup cell to another object (href, left click, row click not fired);
    • a modifier click left to the browser;
    • a referenceVia cell (href and click);
    • an unreadable or missing pointer target keeps its unavailable face with no anchor;
    • a lookup with no value served draws no anchor;
    • a non-routable lookup target draws no anchor;
    • a row click outside the link opens the row's own record;
    • one anchor per cell, none nested.
  • ObjectView.listCrossObjectHost-12673.test.tsx (6): the real ObjectView publishes the builder. The list href path equals the record page's href path (one builder). CONTROL: the record page keeps its ?from= trail and its null answer for an unroutable object.
  • ObjectView.listRecordHref.test.ts: 7 new builder cases. The old 'no other object' case now pins the no-routes path.
  • Ablations: each pin was mutated once, went red, and was restored with the HEAD blob hash compared and git diff HEAD empty.
    • Host stops passing routes: 3 red. Host answers no other object: 7 red. Shared builder drops the routable check: 4 red. Record page drops its trail: 1 red. Grid drops the row click: 1 red. Pointer cell links an unreadable target: 1 red.
    • Removing the lookup link's stopPropagation alone stays green, because the row handler's anchor guard catches it too. Removing both guards turns the lookup pin red.
  • Full @object-ui/app-shell suite as 12 sequential shards of the same file set (a single run outlives this container's command cap): 1461 files (1 skipped), 13774 tests passed, 9 skipped, 0 failed.
  • type-check exit 0 (after building the dependency closure); eslint on touched files exit 0 (0 errors); build exit 0 (dist completeness ok); check:i18n-keys, check:i18n-drift, check:new-line-citations and check-changeset-presence all exit 0.

Acceptance notes

  • A record of another object opened from a list carries no way-back entry. The listed object's own row open still does.
  • A lookup cell holding a raw id it could not name still links, exactly as on the record page (the objectui#8695 face). The target page answers deleted and not-visible alike, so this does not reveal whether a record exists.
  • pageRecordActionsValue (custom pages) still holds its own copy of the same route builder, and the documentHref docblock still names two hosts. Both are outside this change's file surface and are left as they are.

Session: https://claude.ai/code/session_01CrvmqMe8FLB3kXU3NHq25T


Generated by Claude Code

The list host's record-URL builder answered the listed object only, so a
lookup cell or a record-pointer cell naming another object's record drew a
name that could not be opened. It now answers any routable object through
the record page's own builder (appRecordPath over routableObjectNames,
exported by RelatedRecordActionsBridge), as a document href carrying the
router basename, with in-app navigation on a plain click and no from-trail
(a list page has no parent record). The listed object keeps its own route.

Claude-Session: https://claude.ai/code/session_01CrvmqMe8FLB3kXU3NHq25T
Co-authored-by: Claude <noreply@anthropic.com>
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 — ACCEPT · objectui#12673 · head 1a00c21 · 2026-10-16T16:26Z

Seat domain:ui#4, session session_01SJn1GEkrbbBQkhGC26wEDw. Checked against GitHub and the diff, not against the report (relayed on the card). The seat opened this PR from the dev's drafts (degraded channel), and the body is the dev's verbatim.

Checklist

  • Form:
    • Draft → main, assignee os-sales.
    • The first line is Fixes #12673, and the second is Clause-②: no, as the claim 6217359498 declares.
    • The base is 15d8ca6. git merge-tree against current main 378896d is clean; that main includes objectui#12606's ObjectView.tsx edit. 6 files, +672 / −32, no PNG on the branch.
  • Ruling A, as bound (6216810282):
    • The first measurement held: ObjectView and RecordDetailView receive the same allObjects, so the list host reaches the routable set.
    • The click areas were measured live: a link covers its own text (155 × 16 px in a 180 × 41 px cell), and two independent guards keep a link click from opening the row. There are no nested anchors.
  • Diff:
    • One builder. RelatedRecordActionsBridge exports its existing builder as routableObjectNames and appRecordPath, and the bridge calls them. Its ?from= trail is unchanged and pinned by a CONTROL.
    • List host. listRecordActionsValue takes an optional routes argument. With it, any other routable object gets /apps/APP/OBJECT/record/ID as a document href through the existing documentHref join, plus a router-path navigate. No trail is added. Non-routable objects, a missing app segment and empty ids answer null.
    • ObjectView passes the routes.
    • Nothing changes in plugin-grid or fields.
  • Tests:
    • Two new pin files (8 + 6) and 7 new builder cases. Every pin was ablated once.
    • The one single-guard ablation that stayed green (A6) is explained, and its double-guard pair (A6b) went red.
    • Full @object-ui/app-shell suite as 12 sequential shards: 1,461 files, 13,774 tests passed, 0 failed.
    • type-check (after building the dependency closure), eslint on touched files, build, the i18n checks and changeset presence: all exit 0.
  • Changeset: @object-ui/app-shell, user-facing prose.
  • Contract faces: none. The new exports are module exports, not on the package entry; src/index.ts names none of them, measured on current main. Clause-②: no holds, and no contract review is owed.
  • Screenshots (on the never-merged claude/issue-12673-evidence at cb648c3): Approval Requests and the opportunities list with the account lookup, light and dark. Six link hrefs are read from the DOM in the PR body, and the clicks were verified live. Sent to the maintainer at 2026-10-16T16:26Z.
  • CI: running at this record. Landing waits for green.

Rulings

  1. No way-back entry for a cross-object open: A, as shipped. The ruling binds no trail on a list. A location.state origin is a follow-up only if users ask for it.

  2. A lookup holding an unnamed raw id still links: A. This is objectui#8695's deliberate face, shared with the record page, and the record-page CONTROL pins it unchanged. The target page answers deleted and not-visible alike, so it reveals nothing.

  3. The full suite as 12 shards: accepted, as on earlier cards. The container caps a single run.

  4. Out of scope, not filed:

    • pageRecordActionsValue (views/pageRecordActions.ts) keeps a third copy of the route builder.
    • The documentHref docblock still names two hosts.

    Both are drift with no user-visible defect, recorded here for whoever next touches those files.

  5. Light-theme link contrast in Setup is objectui#12608's existing text-primary cell styling. It is unchanged here and not filed.

Implemented-by: cloud session session_01CrvmqMe8FLB3kXU3NHq25T, branch claude/issue-12673-list-cross-object-links
Reviewed-by: seat domain:ui#4, session_01SJn1GEkrbbBQkhGC26wEDw


Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 73 chunks) 3121.8 KB 3744.1 KB
Main entry chunk (gzip) 75.5 KB 350 KB
Entry file index-CAgSPZti.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.42KB 7.85KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.39KB 6.02KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 597.81KB 144.28KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.96KB 69.45KB
fields (index.js) 290.81KB 74.35KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.67KB 11.85KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 201.89KB 48.13KB
plugin-dashboard (index.js) 146.15KB 39.55KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 263.44KB 69.61KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.28KB 46.60KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 270.35KB 74.86KB
plugin-kanban (index.js) 59.42KB 18.48KB
plugin-list (index.js) 132.94KB 34.07KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 93.43KB 23.94KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.23KB 39.46KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Landing · head 1a00c21 · 2026-10-16T16:38Z

  • Head unchanged since the ACCEPT: 1a00c21.
  • Checks on 1a00c21: 36 runs, 33 green and 3 expected skips, none red. That includes Live E2E (informational), Build & E2E, all 16 test shards, Type Check, Lint, Repo Gates, and Bundle Analysis at 3,121.8 KB against the 3,744.1 KB ceiling.
  • Merge state: clean against main 378896d.
  • Contract review: none owed. Clause-②: no, and the new exports are not reachable from the @object-ui/app-shell entry.
  • Action: mark it ready for review and enable auto-merge through the merge queue. Fixes #12673 closes the card on merge.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 16, 2026 16:39
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 16, 2026 16:39
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit b393152 Oct 16, 2026
37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-12673-list-cross-object-links branch October 16, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Decision] 控制台列表中指向其他对象的名称是否可点击打开

2 participants