Skip to content

fix(e2e/live): start-backend.sh records the server's pid, not a subshell's (objectui#12676) #12737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 1 commit into from
Oct 16, 2026
Merged

fix(e2e/live): start-backend.sh records the server's pid, not a subshell's (objectui#12676) #12737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions e2e/live/ci/start-backend.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,17 @@ start() {
echo "[live-backend] starting objectstack dev on :$PORT (log: $BACKEND_DIR/backend.log)"
# --fresh: throwaway sqlite db, auto-removed on SIGTERM. OS_CLOUD_URL=off:
# no marketplace/cloud calls — the lane must be hermetic.
(cd "$APP_DIR" && OS_CLOUD_URL=off nohup ./node_modules/.bin/objectstack dev \
--seed-admin --fresh -p "$PORT" > "$BACKEND_DIR/backend.log" 2>&1 & \
# The `cd` runs first and only the `nohup …` command goes to the background,
# so `$!` is the `objectstack dev` process itself (nohup and the bin's
# `env node` shebang both exec in place); its SIGTERM takes down the `serve`
# child that holds the port. Backgrounding `cd … && nohup …` as one list
# forks a subshell and records ITS pid instead: stop-backend.sh then kills
# that subshell and the server keeps the port, and the `already running`
# check above never matches, because the subshell's cmdline is this script's
# (objectui#12676, measured there at 18.0.0-next.2; nothing here re-derives).
(cd "$APP_DIR"
OS_CLOUD_URL=off nohup ./node_modules/.bin/objectstack dev \
--seed-admin --fresh -p "$PORT" > "$BACKEND_DIR/backend.log" 2>&1 &
echo $! > "$BACKEND_DIR/backend.pid")

# Ready = the seeded admin can actually sign in (same call the e2e
Expand Down
Loading