Skip to content

fix(plugin-form): page form hosts draw an undeclared section as the dialog does (two per row from @md) - #12714

Merged
objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-12592-section-density
Oct 16, 2026
Merged

objectstack-fleet[bot] merged 1 commit into
mainfrom
claude/issue-12592-section-density

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12592
Clause-②: no

What changed

A form section that declares no columns now draws two fields per row from the container's @md tier, and one below it, on every page form host: ObjectForm, SplitForm, TabbedForm and WizardForm. The record dialog already drew it that way. Items 1 and 2 of this card landed through PR #12648; this PR is item 3, and it completes the card.

Measured before the change (jsdom over the real renderer, per row at @md / @2XL / @4XL)

case dialog ObjectForm SplitForm TabbedForm WizardForm
all undeclared, 3 fields 2/2/2 1/1/1 1/1/1 1/1/1 1/1/1
all undeclared, 16 fields 2/2/2 2/3/4 1/1/1 1/1/1 1/1/1
undeclared beside columns: 3 2/2/2 2/3/3 2/3/3 2/3/3 1/1/1
undeclared beside columns: 1 2/2/2 1/1/1 1/1/1 1/1/1 1/1/1
declared 2 + 3 / 1 + 1 same on every host

After the change, every undeclared row reads 2/2/2 on all five hosts, and the declared rows are unchanged.

Tests

  • New undeclaredSectionDensity-12592.test.tsx, 20 tests. Per page host:
    • all sections undeclared: byte-equal to the dialog's classes;
    • undeclared beside a declared columns: 3: the dialog's count. WizardForm draws one step per grid, so it uses the plain two-column grid rather than the 12-track one; same count, different classes;
    • declared controls: columns: 1, columns: 3, and a form-level columns: 3.
  • mixedSectionColumns-12548.test.tsx gains a unit case for the undeclared resolution.
  • pnpm exec vitest run packages/plugin-form/: 189 files, 2314 passed, 1 skipped.
  • Ablation (each mutation proven on disk, each restore proven by blob == HEAD):
    • each host's input mutated to schema.columns ?? 1 turns that host's rows red, 3 failures each;
    • the shared constant mutated from 2 to 1 turns all 8 undeclared pins red, while the declared controls stay green.

Browser readings

Showcase on published 18.0.0-next.2, console from this branch and from efa9cb4fa. HotCRM was not reachable from the container.

reading 1440 before → after 390
wizard page showcase_new_project_wizard (WizardForm, undeclared) 1 → 2 per row 1 → 1
showcase_semantic_zoo/new (ObjectForm, fieldGroup sections) 2 → 2 1 → 1
showcase_semantic_zoo New dialog (ModalForm) 2 → 2 1 → 1
showcase_task/new (declared columns: 2) 2 → 2 1 → 1
  • The page-host @container query resolves in a real browser: 2 tracks at 1440 (container 1136 px and 896 px), 1 track at 390.
  • NOT MEASURED: a tabbed or split form in the browser. Reason: the showcase's only tabbed and split forms (showcase_task formViews) declare columns on every section, so they are declared controls, which the unit pins cover; and no console route to them was found.
  • Evidence is on branch claude/issue-12592-evidence under evidence/12592/ (PNGs, per-field JSON, and the before/after table).

Acceptance notes

  • ObjectForm's fieldGroup-derived sections (no form view) are undeclared sections, so they now draw two per row as the dialog's fieldGroups already did. Before, they were sized by total field count through inferColumns.
  • Not changed here: DrawerForm's explicit-sections arm ignores section columns entirely and never calls the shared rule. No author was found declaring more than 1 on a drawer section, so it is noted only.
  • objectui#12654 is in flight in components/.../form/form.tsx and sectionFields.spec-parity.test.ts. Neither file is touched here.

Gates (local, HEAD 83ac907)

command exit
closure build @object-ui/plugin-form^... 0
@object-ui/plugin-form build 0
@object-ui/plugin-form type-check 0
console vite build (VITE_BASE_PATH=/console/) 0
check:changeset-claims 0
changeset:check 0
check:test-path-roots 0
check:spec-symbols 0
check:doc-example-readers 0
check:unreferenced-sources 0
check:handler-key-reads 0
check-changeset-presence 0
eslint on the changed files 0 (0 errors)

Provenance: built by the cloud session session_013MpUUZWPR76Hx2czmmtfu9 (claim 6216815351) and opened by the domain:ui seat 1 PM (session_011K9g23W67dy2zwnyzaoB6o) from that session's final message, because a cloud session cannot open a PR from its container. The seat joined the first two lines and replaced the dev's own footer lines with this line.


Generated by Claude Code

…ialog does

@objectstack/spec 18.0.0-next.2 dropped FormSectionSchema.columns'
default(1), so a section with no `columns` reaches every sectioned host.
The dialog drew it two per row from `@md`; ObjectForm sized it by field
count (inferColumns) and SplitForm, TabbedForm and WizardForm drew it one
per row, or at the widest declared count.

The rule (section columns, else form columns, else 2) now lives once in
autoLayout.ts: sectionedGridLayout takes the AUTHORED counts and resolves
an undeclared section and form itself, through sectionColumnsFor and
sectionedFormColumns. All five hosts hand it the raw declared values;
ModalForm's private copy of the rule is gone. A declared `columns`
(1 included) is drawn as written.

Pins per page host (undeclared, mixed, declared controls) in
undeclaredSectionDensity-12592.test.tsx.

Claude-Session: https://claude.ai/code/session_013MpUUZWPR76Hx2czmmtfu9
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 70 chunks) 3118.4 KB 3744.1 KB
Main entry chunk (gzip) 66.0 KB 350 KB
Entry file index-ob-0AFpT.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.19KB 7.76KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.39KB 6.02KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 597.81KB 144.28KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.20KB 69.22KB
fields (index.js) 290.25KB 74.19KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.67KB 11.85KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 201.89KB 48.13KB
plugin-dashboard (index.js) 146.15KB 39.55KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 263.43KB 69.61KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.30KB 46.61KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 270.08KB 74.80KB
plugin-kanban (index.js) 59.42KB 18.48KB
plugin-list (index.js) 131.40KB 33.50KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 93.43KB 23.94KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

席位核对 · ACCEPT · domain:ui seat 1 · session_011K9g23W67dy2zwnyzaoB6o · 2026-10-16T14:54Z

What was reviewed:

  1. Shape.
    • Fixes #12592 is the first line and the only closing keyword. Clause-②: no starts line 2, and the assignee is os-tesla.
    • 9 files, +351/−121, all inside the claim:
      • autoLayout.ts;
      • the four page hosts, at their section-grid call sites only;
      • ModalForm.tsx, whose private copy of the rule moved onto the shared derivation (the claim allows it);
      • the new pin and one extended test;
      • one changeset.
    • form.tsx and sectionFields.spec-parity.test.ts (objectui#12654) are untouched. The surface is NOT governed.
  2. The change, read in the diff.
    • sectionColumnsFor resolves a section's density once: section columns, else form columns, else UNDECLARED_SECTION_COLUMNS (2). sectionedFormColumns resolves the grid width.
    • Every host now hands sectionedGridLayout the AUTHORED counts, so no host keeps its own resolution. ObjectForm drops inferColumns, and ModalForm drops dialogSectionColumns / sectionedDialogColumns.
    • A declared count, 1 included, is drawn as written. The derivation stays out of the package index, so no published export, type or prop moves.
  3. Gates (check-runs pinned to this head).
    • 33 success and 3 skipped by design, including Lint, Type Check, Test with all 16 shards, Test (dist pins), Build & E2E, Bundle Analysis, Live E2E (informational) and every changeset check.
    • The dev's ablations each go red: 3 failures per host and 8 for the shared constant, with the declared controls green and the restored blob equal to HEAD.
  4. Semver. @object-ui/plugin-form: patch. A layout default for an undeclared section changes, but no accept set or surface does. Changeset Bump Policy is green.
  5. Open questions, answered A on the card.
    • fieldGroup-derived sections follow the one rule.
    • The showcase readings stand in for the HotCRM line. The dialog arm the HotCRM path uses is held byte-unchanged by the per-host equality pins.
  6. Carried, no carrier: DrawerForm's explicit-sections arm ignores section columns. No author declares more than 1 on a drawer section, so the reach is none; it is an Acceptance note only.
  7. Landing.
    • Ready, then auto-merge into the merge queue.
    • After the merge: verify by content, close the card through Fixes, strip pm:dispatched, and archive cloud session session_013MpUUZWPR76Hx2czmmtfu9.

Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 16, 2026 14:55
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 16, 2026 14:55
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit 96fa4b9 Oct 16, 2026
37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-12592-section-density branch October 16, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants