Skip to content

feat: show a write answer's advisory warnings after save, on the write-warning channel - #12709

Merged
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-12107-write-answer-warnings
Oct 16, 2026
Merged

objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-12107-write-answer-warnings

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12107
Clause-②: yes

What

A single-record create/update answer's warnings (advisory validation-rule hits, declared by the installed @objectstack/spec on CreateDataResponseSchema / UpdateDataResponseSchema, element ValidateDataIssueSchema) now reaches the user after save, on the existing write-warning channel that droppedFields uses. No second channel, no new provider, no form-level code.

  • @object-ui/data-objectstack: WriteWarningEvent gains an optional warnings?: ValidateDataIssue[] (type imported from @objectstack/spec/api, no hand-written duplicate). notifyDroppedFields (the create/update emit site) parses each entry through ValidateDataIssueSchema.safeParse and emits when droppedFields OR warnings is non-empty — the gate measured on main was "return unless droppedFields non-empty after the no-op filter", widened only by "or warnings non-empty". droppedFields stays required; it is [] on an event that exists only for warnings.
  • @object-ui/app-shell: emitWriteWarning keeps the stripped-fields toast byte-for-byte, then shows the warnings in their OWN toast on the same sink: each distinct message verbatim, one per line, under one new heading key. Two toasts rather than one combined: the stripped toast's title says fields did not take effect, which misdescribes an advisory hit. The field is not prefixed to the message (the ruling allows it, does not require it; the author-written message is shown as written, and a prefix would be invented formatting).
  • @object-ui/i18n: detail.writeWarningsTitle in all ten packs (the one heading key).

Clause-② (A1, measured)

WriteWarningEvent is export interface in packages/data-objectstack/src/index.ts, the package's only entry (exports["."] builds from it), so the optional member is a published-type widening: Clause-②: yes. Changeset: minor data-objectstack, patch app-shell and i18n.

Pins (A2)

  • (a) create answer with one warning → event carries it → toast shows its message: writeWarningToast.test.ts "shows the warning message after a create whose answer carries one" (real adapter, real onWriteWarning, real emitWriteWarning; only client.data stubbed), and the adapter-level twin in onWriteWarning.test.ts.
  • (b) same for update: "shows the warning message after an update whose answer carries one".
  • (c) CONTROL, no key → no event, no toast: "CONTROL: an answer without the key shows nothing" and the adapter's "CONTROL: an answer without the key, or with an empty list, emits nothing".
  • (d) CONTROL, both present: the stripped toast equals the toast the same droppedFields produce alone, and the warnings get a second toast ("CONTROL: with both lists present ...").

Ablation (once, after commit, via ablation-replace.mjs with restore proven by blob hash == HEAD and empty git diff HEAD): replacing const warnings = readWriteWarnings(result); with an empty list turned 7 tests red (both create pins, both update pins, the both-present controls, the parse pin) while the no-key controls stayed green — the expected direction. Restored blob c113f4ec3cb5 == HEAD.

Acceptance notes

  • batchTransaction (notifyBatchDroppedFields) is not touched: the file surface and the card name the single-record create/update sites only. Whether the cross-object batch answer carries per-op warnings was not read here. Carrier: none named.
  • An entry the spec schema refuses (for example a severity a later runtime adds) is not shown: parse, never assert, as droppedFields does for its own entries; the skew arm it would need is not this card's.

Verification (head 849e0cfa4)

Every gate below ran on 849e0cfa4 (git rev-parse --short HEAD after the last commit); exit codes recorded to a file.

  • Closure build pnpm --filter '@object-ui/app-shell^...' build (covers data-objectstack's closure too): exit 0.
  • type-check for @object-ui/data-objectstack, @object-ui/app-shell, @object-ui/i18n: exit 0; --listFiles confirms both new test files are in the checked programs.
  • Targeted vitest, --maxWorkers=1: onWriteWarning.test.ts 18 passed; writeWarningToast.test.ts 19 passed.
  • Package dirs under the lock: packages/data-objectstack/ 94 files / 1164 tests passed; packages/i18n/ 83 files / 1321 passed, 13 skipped.
  • packages/app-shell/: NOT MEASURED as a whole package — the serial (--maxWorkers=1) run printed no file result after 22 minutes and was stopped by PID. Declared narrowing: packages/app-shell/src/providers/ (every sibling of the changed module, incl. AdapterProvider.* and the other toast modules) plus product-neutral-renderer.ratchet.test.ts (locale keys): 26 files / 274 tests passed. The rest of app-shell is left to CI's pnpm test.
  • Lint narrowed to the 14 changed .ts files (eslint, inline config on as the package lint scripts run it): 0 errors, 0 warnings on added lines. Population: the 14 files of the diff, count read from --format json. Invariance: the eslint config declares no type-aware parser options, so this diff cannot move a verdict on an untouched file.
  • pnpm check: phantom-deps, self-import, unreferenced-sources, doc-example-readers, handler-key-reads, side-effects-array, element-data-source-declaration, spec-symbols, action-forward-parity, designer-field-key-parity, icon-record-names, i18n-keys, i18n-drift, i18n-designer-parity, control-bytes: all exit 0. node scripts/check-hand-rolled-comment-mask.mjs: 0. node scripts/check-changeset-fixed.mjs: 0. node scripts/check-changeset-presence.mjs: 0. pnpm check:new-line-citations: 0 new.

Generated by Claude Code

…warning event

The spec declares `warnings` (advisory validation-rule hits, element
ValidateDataIssueSchema) on CreateDataResponseSchema / UpdateDataResponseSchema.
The single-record create/update emit site now parses it through the spec schema
and carries it as an optional `warnings` member on WriteWarningEvent; the event
is emitted when droppedFields or warnings is non-empty. An answer without the
key emits nothing new.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
emitWriteWarning now shows the event's `warnings` messages, verbatim, in their
own toast on the same sink, under one new heading key
(detail.writeWarningsTitle, all ten packs). The stripped-fields toast is
unchanged; an event without warnings toasts exactly as before.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 70 chunks) 3118.7 KB 3119.4 KB
Main entry chunk (gzip) 66.0 KB 350 KB
Entry file index-DmYL03V0.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.19KB 7.76KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.39KB 6.02KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 597.81KB 144.28KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.96KB 69.45KB
fields (index.js) 290.25KB 74.19KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.67KB 11.85KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 201.89KB 48.13KB
plugin-dashboard (index.js) 146.15KB 39.55KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 263.43KB 69.61KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.92KB 46.73KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 270.08KB 74.80KB
plugin-kanban (index.js) 59.42KB 18.48KB
plugin-list (index.js) 131.40KB 33.50KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 93.43KB 23.94KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Review: ACCEPT — objectui PR #12709 · domain:ui seat 2 · session_01XVp19E1MYUTFM3dnkwz8gB · 2026-10-16T14:35Z

Reviewed on GitHub at head 849e0cf, against the card's Done-when and the claim (6216810332).

  • Shape: a draft against main. The body opens Fixes #12107, followed by Clause-②: yes. It changes 15 files: data-objectstack, app-shell, the ten i18n packs and the changeset.
    • The changeset is minor for @object-ui/data-objectstack and patch for app-shell and i18n.
  • The change:
    • WriteWarningEvent gains an optional warnings?: ValidateDataIssue[], typed from @objectstack/spec/api.
    • The single-record create/update emit parses each entry of the answer's warnings through ValidateDataIssueSchema. Its gate is widened only by "or warnings non-empty".
    • droppedFields stays required, and is [] when the event exists only for warnings.
    • emitWriteWarning keeps the stripped-fields toast byte-identical and adds a second toast, titled by the new detail.writeWarningsTitle key, listing each distinct server message verbatim.
  • Contract review (contract tier, verdict PASS):
    • Spec types: ValidateDataIssueSchema and the warnings member of the create/update answers are byte-identical in the installed 18.0.0-next.2 and on objectstack main, and both are runtime exports of @objectstack/spec/api.
    • Subscribers: there is exactly one production subscriber (AdapterProvider.tsx). An event with droppedFields: [] produces no stripped-fields toast there, so no reader takes "an event arrived" to mean "fields were dropped".
    • Bundle: vendor-objectstack measures the same as main (±10 bytes). @objectstack/spec/api was already a runtime import in the eager closure. The aggregate +0.2 KB is the package code itself, still under the budget.
    • Batch: no batch or transaction answer declares warnings on either tree, so the Done-when is complete as filed.
  • Pins: onWriteWarning.test.ts (create and update with a warning; no-key, empty and both-present controls; the parse refusal) and writeWarningToast.test.ts (the warnings toast; the stripped toast unchanged).
    • Ablation: removing the read turns 7 cases red while the no-key controls stay green. The restore was proven by blob hash.
  • Findings:
    • Acceptance notes, not filed:
      • An entry whose severity a later runtime adds beyond 'warning' | 'info' fails the parse, so its message is not shown. No runtime emits such a severity today, so there is no reach. The reviewer's sound shape, for when the spec's vocabulary moves, is to gate on message being a string and carry the rest loosely.
      • The batch path reads no warnings. This is correct, because no batch answer declares them.
    • Dropped: the spec's clone answer also carries warnings, but @object-ui/data-objectstack has no clone write path to read it (git grep -i clone on index.ts returns nothing).
  • Trailers: all three commits carry only the model-free pair.
  • CI at head: 33 success, 3 skipped, 0 failures (filter=latest, 36 runs), Live E2E (informational) included.

Next: pr_ready + automerge_enable.


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 16, 2026 14:36
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit 6757a93 Oct 16, 2026
37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-12107-write-answer-warnings branch October 16, 2026 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

console: a write answer's warnings (advisory validation hits) is shown to the user after save, on the existing write-warning channel

2 participants