Repository navigation
fix(i18n): the cloud-connection "Not connected" card says its state and what Connect does - #12669
Merged
objectstack-fleet[bot] merged 2 commits intoOct 16, 2026
Merged
Conversation
…Connect does The "Not connected" card's body opened with the page subtitle's sentence word for word. It now says the runtime is not connected to a control plane and that Connect opens the cloud account to approve the link. All ten packs move; the key name is unchanged. A pin beside the panel holds the en text and that it does not carry the subtitle sentence. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
The de pack's quote-pairing pin counts every „…“ pair in the pack; the new body's quoted button name added one. The en body names the button bare, and the de body now does the same. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
Contributor
✅ Console Performance Budget
The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it. 📦 Bundle Size Report
Size Limits
|
Contributor
Author
|
Live E2E (informational) is red at head
Generated by Claude Code |
Contributor
Author
Review: ACCEPT — objectui PR #12669 ·
|
objectstack-fleet
Bot
deleted the
claude/issue-12655-cloud-unbound-copy
branch
October 16, 2026 13:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12655
Clause-②: no
What changed
The cloud-connection panel's "Not connected" card (
cloudConnection.unbound.body, drawn byCloudConnectionPanel) opened with the page header subtitle's sentence word for word, so an admin on Setup's cloud connection page read it twice. The body now says the state and what Connect does:packages/i18n/src/locales/carry the new text in their own language. The key name is unchanged, so no reader moves.CloudConnectionPanel.tsxis not touched.de-quote-pairing-3876.test.tspins the pack's pair count, and a quoted button name added one pair (the first run went red on it; the second commit fixes it).packages/cloud-connection/src/cloud-connection-ui.ts) and is not changed.Pin
packages/app-shell/src/console/cloud-connection/__tests__/CloudConnectionPanel.unboundBody-12655.test.tsxrenders the panel in its unbound state under the realI18nProvider(en), finds the new body inside the "Not connected" card beside the Connect button, and asserts the body neither contains the subtitle sentence nor opens with "Connect this runtime". It stubsfetchwithvi.stubGlobal; novi.mock. It reads no source.Reverse check, run once (not kept): with
packages/i18n/src/locales/en.tsput back to the base commitf78efdd1eon top of the fix commit, the pin went red (Unable to find an element with the text: This runtime is not connected to a control plane. …,Tests 1 failed (1), lock verdictcommand-exit 1). The file was then restored fromHEAD:git diff HEADempty and the file's hash equal to its HEAD blob.Verification (on head
4ba37c91f)pnpm exec vitest run --maxWorkers=1 packages/i18n/ packages/app-shell/src/__tests__/product-neutral-renderer.ratchet.test.ts packages/app-shell/src/console/cloud-connection/(under the shared verify lock):Test Files 88 passed (88),Tests 1368 passed | 13 skipped (1381), verdictcommand-exit 0.@object-ui/app-shelldependency closure (--filter '@object-ui/app-shell^...' build, exit 0):pnpm --filter @object-ui/i18n --filter @object-ui/app-shell run type-check, bothDone, exit 0. Both runtsc -p tsconfig.test.json, which type-checks the tests.check:phantom-deps,check:self-import,check:unreferenced-sources,check:doc-example-readers,check:handler-key-reads,check:side-effects-array,check:element-data-source-declaration,check:spec-symbols,check:action-forward-parity,check:designer-field-key-parity,check:icon-record-names,check:i18n-keys,check:i18n-drift,check:i18n-designer-parity,check:control-bytes,node scripts/check-hand-rolled-comment-mask.mjs,node scripts/check-changeset-fixed.mjs,node scripts/check-changeset-presence.mjs.check:i18n-driftreads: "1 en value(s) changed … 9 pack value(s) followed … Every changed en value was followed by all nine translation packs."check:i18n-drift,check:i18n-keysandcheck:control-byteswere run again on the final head, each exit 0..ts/.tsxfiles:eslint --no-inline-config --format jsongives 11 files, 0 errors, 0 warnings, none ignored.eslint.config.jssets no type-aware parser project, so this diff cannot change the lint verdict on any untouched file. The repo-widepnpm lintis left to CI.packages/app-shell/test dir. A run under the lock did not finish inside the foreground cap (killed bytimeout 560, exit 124). CI'spnpm testruns it. The app-shell files this diff can reach are measured above: the cloud-connection tests and the product-neutral ratchet, which reads locale keys.Acceptance notes
cloudConnection.*is on the frozen product-specific allowlist (ADR-0060). This PR changes one value under an existing key. It adds no key and no allowlist entry.Adds no product-specific widget, dialog, hook or string (see AGENTS.md › Product-neutral renderer). One existing string's value changes; no key is added.
Changeset:
.changeset/12655-cloud-unbound-copy.md(@object-ui/i18npatch). Session:https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gBGenerated by Claude Code