Skip to content

fix(i18n): the cloud-connection "Not connected" card says its state and what Connect does - #12669

Merged
objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-12655-cloud-unbound-copy
Oct 16, 2026
Merged

objectstack-fleet[bot] merged 2 commits into
mainfrom
claude/issue-12655-cloud-unbound-copy

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12655
Clause-②: no

What changed

The cloud-connection panel's "Not connected" card (cloudConnection.unbound.body, drawn by CloudConnectionPanel) opened with the page header subtitle's sentence word for word, so an admin on Setup's cloud connection page read it twice. The body now says the state and what Connect does:

This runtime is not connected to a control plane. Connect opens your cloud account in a new window, where one click approves the link — no ids or credentials are typed into this page.

  • The existing "no ids or credentials" reassurance is kept.
  • No control plane is named, and no new served field is read; nothing the panel is served says which control plane Connect binds to (card rulings).
  • All ten packs under packages/i18n/src/locales/ carry the new text in their own language. The key name is unchanged, so no reader moves. CloudConnectionPanel.tsx is not touched.
  • The de body names the button bare (Verbinden), like the en body does, rather than in a „…“ pair: de-quote-pairing-3876.test.ts pins the pack's pair count, and a quoted button name added one pair (the first run went red on it; the second commit fixes it).
  • The page subtitle is objectstack's (packages/cloud-connection/src/cloud-connection-ui.ts) and is not changed.

Pin

packages/app-shell/src/console/cloud-connection/__tests__/CloudConnectionPanel.unboundBody-12655.test.tsx renders the panel in its unbound state under the real I18nProvider (en), finds the new body inside the "Not connected" card beside the Connect button, and asserts the body neither contains the subtitle sentence nor opens with "Connect this runtime". It stubs fetch with vi.stubGlobal; no vi.mock. It reads no source.

Reverse check, run once (not kept): with packages/i18n/src/locales/en.ts put back to the base commit f78efdd1e on top of the fix commit, the pin went red (Unable to find an element with the text: This runtime is not connected to a control plane. …, Tests 1 failed (1), lock verdict command-exit 1). The file was then restored from HEAD: git diff HEAD empty and the file's hash equal to its HEAD blob.

Verification (on head 4ba37c91f)

  • pnpm exec vitest run --maxWorkers=1 packages/i18n/ packages/app-shell/src/__tests__/product-neutral-renderer.ratchet.test.ts packages/app-shell/src/console/cloud-connection/ (under the shared verify lock): Test Files 88 passed (88), Tests 1368 passed | 13 skipped (1381), verdict command-exit 0.
  • Type-check, after building the @object-ui/app-shell dependency closure (--filter '@object-ui/app-shell^...' build, exit 0): pnpm --filter @object-ui/i18n --filter @object-ui/app-shell run type-check, both Done, exit 0. Both run tsc -p tsconfig.test.json, which type-checks the tests.
  • Gate battery, each exit 0: check:phantom-deps, check:self-import, check:unreferenced-sources, check:doc-example-readers, check:handler-key-reads, check:side-effects-array, check:element-data-source-declaration, check:spec-symbols, check:action-forward-parity, check:designer-field-key-parity, check:icon-record-names, check:i18n-keys, check:i18n-drift, check:i18n-designer-parity, check:control-bytes, node scripts/check-hand-rolled-comment-mask.mjs, node scripts/check-changeset-fixed.mjs, node scripts/check-changeset-presence.mjs. check:i18n-drift reads: "1 en value(s) changed … 9 pack value(s) followed … Every changed en value was followed by all nine translation packs." check:i18n-drift, check:i18n-keys and check:control-bytes were run again on the final head, each exit 0.
  • Lint, narrowed to the 11 changed .ts/.tsx files: eslint --no-inline-config --format json gives 11 files, 0 errors, 0 warnings, none ignored. eslint.config.js sets no type-aware parser project, so this diff cannot change the lint verdict on any untouched file. The repo-wide pnpm lint is left to CI.
  • NOT MEASURED: the whole packages/app-shell/ test dir. A run under the lock did not finish inside the foreground cap (killed by timeout 560, exit 124). CI's pnpm test runs it. The app-shell files this diff can reach are measured above: the cloud-connection tests and the product-neutral ratchet, which reads locale keys.

Acceptance notes

  • cloudConnection.* is on the frozen product-specific allowlist (ADR-0060). This PR changes one value under an existing key. It adds no key and no allowlist entry.

  • Adds no product-specific widget, dialog, hook or string (see AGENTS.md › Product-neutral renderer). One existing string's value changes; no key is added.

Changeset: .changeset/12655-cloud-unbound-copy.md (@object-ui/i18n patch). Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB


Generated by Claude Code

…Connect does

The "Not connected" card's body opened with the page subtitle's sentence word
for word. It now says the runtime is not connected to a control plane and that
Connect opens the cloud account to approve the link. All ten packs move; the
key name is unchanged. A pin beside the panel holds the en text and that it
does not carry the subtitle sentence.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
The de pack's quote-pairing pin counts every „…“ pair in the pack; the new
body's quoted button name added one. The en body names the button bare, and
the de body now does the same.

Co-authored-by: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 70 chunks) 3118.2 KB 3119.4 KB
Main entry chunk (gzip) 65.9 KB 350 KB
Entry file index-DwFbNQ1E.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 21.19KB 7.76KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 20.39KB 6.02KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.27KB 1.86KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 597.83KB 144.29KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 248.20KB 69.22KB
fields (index.js) 290.12KB 74.14KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.67KB 11.85KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 201.89KB 48.13KB
plugin-dashboard (index.js) 146.15KB 39.55KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 262.91KB 69.49KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 180.92KB 46.73KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 270.08KB 74.80KB
plugin-kanban (index.js) 59.42KB 18.48KB
plugin-list (index.js) 131.40KB 33.50KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 93.43KB 23.94KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Live E2E (informational) is red at head 4ba37c9. The failure is not this PR's.


Generated by Claude Code

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Review: ACCEPT — objectui PR #12669 · domain:ui seat 2 · session_01XVp19E1MYUTFM3dnkwz8gB · 2026-10-16T13:25Z

Reviewed on GitHub at head 4ba37c9, against the card's Target and the claim (6215543551).

  • Shape: a draft against main. The body opens Fixes #12655, followed by Clause-②: no. It changes 12 files:
    • the cloudConnection.unbound.body value in all ten packs, under the same key name;
    • one new pin;
    • the changeset (@object-ui/i18n: patch).
  • Copy: the en body no longer repeats the page subtitle. It now says the state, then what Connect does: "This runtime is not connected to a control plane. Connect opens your cloud account in a new window, where one click approves the link — no ids or credentials are typed into this page."
    • The seat checked the claim against CloudConnectionPanel.tsx on main. connect() opens the approval link with window.open(link, '_blank', …), and a blocked popup falls back to a link with target="_blank". So "a new window" is true on both paths.
    • The copy names no control plane and reads no served field. CloudConnectionPanel.tsx is untouched.
  • Translations: all nine translations follow the en meaning in their own language, and check:i18n-drift reads every changed en value as followed.
    • The first de text quoted the button in a „…“ pair, which de-quote-pairing-3876 (frozen at 87 pairs) caught. The second commit names the button bare, as en does, so that pin is untouched.
  • Pin: CloudConnectionPanel.unboundBody-12655 mounts the real panel in its unbound state. It asserts that the new body sits in the Not connected card beside the Connect button, and that the body does not carry the subtitle sentence.
    • Ablation: restoring main's en.ts turns the pin red. The restore was proven by blob hash.
  • Trailers: both commits carry only the model-free pair.
  • CI at head: 32 success, 3 skipped, 1 failure (filter=latest, 36 runs). The one red is Live E2E (informational), which is non-required and has no merge_group trigger. It fails on the lane-wide cold-install crash in npm, objectui#12649, which is recorded on this PR.

Next: pr_ready + automerge_enable.


Generated by Claude Code

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 16, 2026 13:26
@objectstack-fleet
objectstack-fleet Bot enabled auto-merge October 16, 2026 13:26
@objectstack-fleet
objectstack-fleet Bot added this pull request to the merge queue Oct 16, 2026
Merged via the queue into main with commit efa9cb4 Oct 16, 2026
36 of 37 checks passed
@objectstack-fleet
objectstack-fleet Bot deleted the claude/issue-12655-cloud-unbound-copy branch October 16, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants