feat(app-shell): Add field asks for label and type in a popover; the type picker also searches descriptions (objectui#12516)

[objectstack-fleet]

Fixes #12516
Clause-②: no

What changed

Target 1 — the type picker's search. The picker already had a search input, focused on open, filtering on name, category, id and English name with Enter picking (objectui#11793); the test-pass screenshot cropped it off above a popover that had flipped upward. This PR adds the description to the search, matched on whole words: masked now finds Password and Secret, while pick still leaves Picklist alone and look leaves Lookup. A substring match would have pulled in Slider through 'A number picked on a slider.' A query in Han or Kana matches a description as a substring, since those scripts have no word edges. Groups keep their headings over their matches, empty groups are dropped, and the arrow keys plus Enter pick a type.

Target 2 — Add field asks first. A new AddFieldPopover (studio-design) holds a required Label, the same FieldTypePicker with Text preselected, and Cancel / Create. Create calls the pillar's one addField(label, type): the same object buffer and autosave as before, and the new field opens in the inspector. The api name is toFieldNameLoose(label), the inspector Label's own derivation. When that is empty (no Latin letters) or names an existing field, the field gets the next free field_N, which is what the inspector keeps in both cases. Cancel, Escape or an outside click creates nothing.

Target 3 — the entries share it. On main, Add field lives on the Form toolbar and the Records grid's '+' column, and both ran the same addField. Both now open the popover. There is no empty-form Add field on main (an empty section shows 'Drop here'). A read-only package still offers no Add field (objectui#12453).

Deviations

• The grid '+' is drawn from GridFieldAuthoring, whose onAddColumn hands back no element, and @object-ui/components exports no popover anchor. So the grid's popover sits at the records body's top-right corner, and focus returns to '+' when it closes. Anchoring it under '+' needs a components contract change, outside this card's file surface.
• After a popover create the api name is not a placeholder shape, so the inspector's Label no longer moves it (the objectui#7615 ownership rule); the API name box still edits it.
• Six existing suites and the shared add-field test helper were updated, because their Add field click now opens the popover; the helper fills it with 'New field'. No assertion was weakened.

Acceptance notes

• GridFieldAuthoring.onAddColumn is typed with no argument while the grid passes the click event; noted, not filed.
• The card lists nine categories that sum to 49 under its '45 types in 8 groups' line; the catalog is untouched, per the constraint.

Screenshots (1280 px, writable package, HotCRM backend)

• Type picker with pick — light · dark
• Add field popover — light · dark
• Created field in the inspector (health_score, Picklist) — light · dark

The screenshots live on the evidence branch claude/issue-12516-evidence, which is never merged.

Test evidence (at 04e029f)

• pnpm --filter @object-ui/app-shell test: exit 0, Test Files 1416 passed, 1 skipped (1417); Tests 13521 passed, 9 skipped (13530).
• type-check 0, build 0, eslint on touched files 0 errors; check:i18n-keys, check:i18n-drift, check:i18n-designer-parity, check:i18n-dead-keys, check:new-line-citations and check-changeset-presence all 0.
• New pins: FieldTypePicker.search-12516.test.tsx (8 tests) and DataPillar.addFieldPopover-12516.test.tsx (8 tests). Each was ablated once and went red: no description match (4 red), description as substring (2 red), name not derived from the label (2 red), collision unhandled (1 red), popover clicks recorded as the grid button (1 red). One unmount-close branch stayed green under ablation, which showed it unreachable, so it was deleted.

Session: https://claude.ai/code/session_01NexEdg9sJzmsdpTuKVo4AY

🤖 Generated with Claude Code

https://claude.ai/code/session_01NexEdg9sJzmsdpTuKVo4AY

---

Generated by Claude Code

[objectstack-fleet]

席位核对 — ACCEPT · objectui#12516 · head 04e029f · 2026-10-15T23:56Z

Seat domain:ui#4, session session_01SJn1GEkrbbBQkhGC26wEDw. Checked against GitHub and the diff, not against the report (relayed on the card). The seat opened this PR from the dev's pr_title_draft and pr_body_draft (degraded channel); the body is the dev's, verbatim.

Checklist

• Form: draft → main, assignee os-sales. The first line is Fixes #12516, and the next line is exactly Clause-②: no. git merge-tree against current main (daeb77f) is clean. main has taken objectui#12579, Page designer: a readable source editor, a Properties tab with the page's metadata, a Run mode that differs #12522, Studio empty states carry the primary action (Validations, Hooks, Actions, Automations, Access) #12514 and Studio: controls without an accessible name (records toolbar, flow nodes, sheets, landing cards) #12510 since the branch's last merge, and none of them touches this PR's region.
• History: five commits, the last a merge of origin/main (f96f771). There is no rebase and no force-push. The session summary's "rebase on main" was loose wording; the branch carries a merge commit.
• Diff:
  • StudioDesignSurface.tsx, in the DataPillar region only. addField(label, type) replaces the fixed "New field" / field_N / Text. addedFieldName reuses toFieldNameLoose, the inspector Label's own derivation, and falls back to nextFieldName on an empty or colliding result: one derivation, as ruled. The grid's "+" now opens the popover in place of creating at once.
  • The new AddFieldPopover.tsx holds a required Label, the same FieldTypePicker preselected on Text, and Cancel / Create. Create runs the pillar's one addField, so it uses the same buffer and the same autosave. Cancel creates nothing.
  • FieldTypePicker.tsx adds whole-word description matching (Han and Kana match as substrings) on top of the existing cmdk search.
  • A read-only package still offers no Add field.
• Tests: two new files with 8 + 8 tests. Six existing suites and the shared add-field helper are updated, because their Add field click now opens the popover; no assertion is weakened, as the report lists. Five ablations each turned red. A sixth stayed green, which showed its branch unreachable, so that code was deleted, which is the point of ablating. The full @object-ui/app-shell suite ran green on 04e029f: 13521 passed.
• i18n: one new key in en and zh (engine.studio.data.addFieldCreate). newFieldLabel lives on as the Label placeholder. The i18n gates are green.
• Changeset: user-facing prose; patch for @object-ui/app-shell.
• Contract faces: none. The components contract (GridFieldAuthoring.onAddColumn) is untouched.
• Screenshots: the picker with pick, the popover, and the created field, in light and dark, on the never-merged claude/issue-12516-evidence (15adf9a). The seat sent them to the maintainer at 2026-10-15T23:56Z.
• CI on 04e029f: running at this record. Landing waits for green.

Rulings on the open questions and deviations

1. Description matching: A, whole words, with Han and Kana as substrings. It meets both the card's target 1 and its acceptance. The rule is pinned both ways (picked finds Slider; pick does not), and no copy is edited to suit a matcher.
2. The grid "+" popover at the records body's corner: A, accept. Anchoring it under "+" needs onAddColumn to hand back its element, a components contract change with no pull yet (axis 4). Focus returns to "+". Nothing is filed; the PR's acceptance notes record the typed-versus-passed argument mismatch.
3. A label-derived api name is no longer moved by later Label edits (objectui#7615): A, accept. The label is asked for up front now, and the API name box still edits the name. Changing the inspector's ownership state machine is a separate decision.
4. Assumptions 1 and 2 partly falsified (the search box existed; there is no empty-form Add field on main): recorded. The work landed where the gaps actually were.
5. The grid "+" entry has no browser screenshot (the draft-only object shows no grid). It is covered by the popover suite's grid test. Accepted.

Implemented-by: cloud session session_01NexEdg9sJzmsdpTuKVo4AY, branch claude/issue-12516-field-type-picker
Reviewed-by: seat domain:ui#4, session_01SJn1GEkrbbBQkhGC26wEDw

---

Generated by Claude Code

[github-actions]

✅ Console Performance Budget

Metric	Value	Budget
Eager closure (gzip, 70 chunks)	3092.5 KB	3119.4 KB
Main entry chunk (gzip)	73.3 KB	350 KB
Entry file	index-Dex9063r.js	—
Status	PASS	—

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.

---

📦 Bundle Size Report

Package	Size	Gzipped
app-shell (consoleActionDispatch.js)	0.20KB	0.19KB
app-shell (index.js)	21.19KB	7.76KB
app-shell (runtime-config.js)	22.59KB	7.89KB
app-shell (types.js)	0.01KB	0.04KB
app-shell (urlParams.js)	10.11KB	3.87KB
auth (ActiveOrganizationStorage.js)	27.95KB	10.04KB
auth (AuthContext.js)	0.31KB	0.24KB
auth (AuthGuard.js)	2.07KB	1.00KB
auth (AuthProvider.js)	40.22KB	10.61KB
auth (AuthShell.js)	3.49KB	1.40KB
auth (ForgotPasswordForm.js)	12.21KB	3.45KB
auth (LoginForm.js)	18.15KB	5.40KB
auth (PreviewBanner.js)	0.90KB	0.50KB
auth (RegisterForm.js)	6.72KB	2.24KB
auth (SocialSignInButtons.js)	9.70KB	3.93KB
auth (UserMenu.js)	3.39KB	1.21KB
auth (auth-gate-events.js)	1.62KB	0.83KB
auth (authStyles.js)	5.04KB	1.72KB
auth (createAuthClient.js)	41.19KB	11.12KB
auth (createAuthenticatedFetch.js)	8.54KB	3.46KB
auth (index.js)	3.63KB	1.64KB
auth (invitation-status.js)	1.22KB	0.70KB
auth (org-roles.js)	6.66KB	2.78KB
auth (phone-identifier.js)	1.11KB	0.66KB
auth (types.js)	0.59KB	0.35KB
auth (useAuth.js)	5.30KB	1.02KB
auth (useWorkspaceAdminStatus.js)	11.08KB	4.58KB
collaboration (CommentThread.js)	27.26KB	8.03KB
collaboration (LiveCursors.js)	3.17KB	1.27KB
collaboration (PresenceAvatars.js)	6.28KB	2.60KB
collaboration (PresenceProvider.js)	2.79KB	1.13KB
collaboration (commentAuthorship.js)	1.39KB	0.78KB
collaboration (index.js)	1.93KB	0.85KB
collaboration (useCollaborationTranslation.js)	6.50KB	2.52KB
collaboration (useCommentSearch.js)	1.98KB	0.88KB
collaboration (useConflictResolution.js)	7.75KB	1.86KB
collaboration (useMentionNotifications.js)	1.81KB	0.68KB
collaboration (usePresence.js)	6.33KB	1.84KB
collaboration (useRealtimeSubscription.js)	7.91KB	2.01KB
components (index.js)	596.60KB	143.79KB
core (index.js)	10.18KB	4.04KB
create-plugin (index.js)	27.94KB	9.51KB
data-objectstack (index.js)	254.55KB	71.19KB
fields (index.js)	283.09KB	72.13KB
i18n (LocalizationContext.js)	2.92KB	1.42KB
i18n (builtinAggregateLabels.js)	0.86KB	0.49KB
i18n (currency.js)	2.59KB	1.22KB
i18n (fallbackInterpolation.js)	6.25KB	2.77KB
i18n (i18n.js)	8.87KB	3.64KB
i18n (index.js)	5.52KB	2.39KB
i18n (pickLocalized.js)	9.86KB	3.95KB
i18n (provider.js)	39.35KB	12.88KB
i18n (translateFn.js)	0.20KB	0.18KB
i18n (useDisplayLocale.js)	3.52KB	1.76KB
i18n (useObjectLabel.js)	36.87KB	9.88KB
i18n (useSafeTranslation.js)	7.14KB	2.92KB
layout (index.js)	40.67KB	11.85KB
mobile (MobileProvider.js)	0.92KB	0.49KB
mobile (ResponsiveContainer.js)	0.94KB	0.38KB
mobile (breakpoints.js)	1.51KB	0.70KB
mobile (createOfflineDataSource.js)	5.61KB	1.75KB
mobile (index.js)	1.99KB	0.87KB
mobile (offlineQueue.js)	3.91KB	1.35KB
mobile (pwa.js)	0.97KB	0.49KB
mobile (serviceWorker.js)	1.48KB	0.62KB
mobile (serviceWorkerSource.js)	3.41KB	1.48KB
mobile (useBreakpoint.js)	1.54KB	0.65KB
mobile (useGesture.js)	6.96KB	1.98KB
mobile (useOfflineSync.js)	1.99KB	0.72KB
mobile (usePullToRefresh.js)	6.62KB	2.45KB
mobile (useResponsive.js)	0.72KB	0.42KB
mobile (useSpecGesture.js)	5.52KB	2.10KB
mobile (useTouchTarget.js)	1.01KB	0.54KB
permissions (MePermissionsProvider.js)	15.35KB	5.51KB
permissions (PermissionContext.js)	0.31KB	0.25KB
permissions (PermissionGuard.js)	0.89KB	0.45KB
permissions (PermissionProvider.js)	6.82KB	2.38KB
permissions (discardProofCache.js)	1.04KB	0.55KB
permissions (evaluator.js)	8.33KB	3.07KB
permissions (index.js)	0.93KB	0.41KB
permissions (store.js)	0.91KB	0.42KB
permissions (useFieldPermissions.js)	1.28KB	0.53KB
permissions (usePermissions.js)	4.83KB	2.27KB
plugin-ai (index.js)	16.04KB	3.92KB
plugin-calendar (index.js)	54.94KB	16.05KB
plugin-charts (index.js)	84.97KB	23.36KB
plugin-chatbot (index.js)	201.89KB	48.13KB
plugin-dashboard (index.js)	145.69KB	39.39KB
plugin-designer (index.js)	233.95KB	50.08KB
plugin-detail (index.js)	262.91KB	69.49KB
plugin-editor (index.js)	2.23KB	1.05KB
plugin-form (index.js)	180.83KB	46.61KB
plugin-gantt (index.js)	178.36KB	45.08KB
plugin-grid (index.js)	262.82KB	72.91KB
plugin-kanban (index.js)	53.23KB	16.71KB
plugin-list (index.js)	129.82KB	33.09KB
plugin-map (index.js)	27.07KB	8.96KB
plugin-markdown (index.js)	13.88KB	4.80KB
plugin-report (index.js)	46.66KB	13.13KB
plugin-timeline (index.js)	39.21KB	11.85KB
plugin-tree (index.js)	15.07KB	5.33KB
plugin-view (index.js)	93.43KB	23.94KB
providers (DataSourceProvider.js)	0.75KB	0.39KB
providers (MetadataProvider.js)	1.37KB	0.59KB
providers (ThemeProvider.js)	1.90KB	0.85KB
providers (UploadProvider.js)	12.07KB	3.68KB
providers (index.js)	0.45KB	0.23KB
providers (types.js)	0.01KB	0.04KB
react-runtime (index.js)	5.62KB	2.34KB
react (LazyPluginLoader.js)	4.47KB	1.63KB
react (SchemaRenderer.js)	120.63KB	39.56KB
react (data-invalidation.js)	5.05KB	2.08KB
react (index.js)	4.50KB	2.06KB
react (schema-input.js)	4.31KB	2.07KB
react (spec-input.js)	0.20KB	0.18KB
sdui-parser (body-dialect.js)	4.50KB	1.99KB
sdui-parser (codegen.js)	9.45KB	3.76KB
sdui-parser (dashboard-widget-options.js)	3.07KB	1.30KB
sdui-parser (index.js)	7.30KB	3.12KB
sdui-parser (input-type.js)	2.84KB	1.40KB
sdui-parser (parse.js)	25.28KB	7.81KB
sdui-parser (provenance.js)	3.84KB	1.90KB
sdui-parser (types.js)	0.29KB	0.24KB
sdui-parser (validate.js)	23.87KB	7.83KB
types (ai.js)	4.39KB	2.17KB
types (api-types.js)	0.20KB	0.18KB
types (app.js)	4.12KB	1.61KB
types (authoring-nodes.js)	0.20KB	0.19KB
types (base.js)	0.20KB	0.18KB
types (blocks.js)	0.20KB	0.18KB
types (cloud.js)	0.20KB	0.18KB
types (complex.js)	4.44KB	2.07KB
types (crud.js)	0.20KB	0.18KB
types (dashboard-filter-alias.js)	6.23KB	2.74KB
types (dashboard-widget-layout.js)	2.06KB	0.96KB
types (data-display.js)	3.75KB	1.85KB
types (data-protocol.js)	0.20KB	0.19KB
types (data.js)	0.20KB	0.18KB
types (designer.js)	1.85KB	0.85KB
types (disclosure.js)	0.20KB	0.18KB
types (error-code.js)	1.54KB	0.88KB
types (expression.js)	0.20KB	0.18KB
types (feedback.js)	0.20KB	0.18KB
types (field-types.js)	1.13KB	0.65KB
types (form.js)	0.20KB	0.18KB
types (http-inflight.js)	8.87KB	3.73KB
types (http-retry.js)	4.32KB	2.02KB
types (icon-key-migration.js)	4.26KB	1.63KB
types (index.js)	5.78KB	2.70KB
types (layout.js)	0.20KB	0.18KB
types (managed-by.js)	0.19KB	0.18KB
types (mobile.js)	5.00KB	2.39KB
types (navigation.js)	0.20KB	0.18KB
types (node-slots.js)	7.18KB	2.34KB
types (objectql.js)	0.20KB	0.18KB
types (overlay.js)	0.20KB	0.18KB
types (permissions.js)	2.52KB	1.31KB
types (plugin-scope.js)	0.20KB	0.18KB
types (record-approval-decision.js)	0.20KB	0.20KB
types (record-components.js)	0.20KB	0.19KB
types (record-panels.js)	0.20KB	0.19KB
types (record-semantics.js)	1.28KB	0.67KB
types (registry.js)	0.20KB	0.18KB
types (reports.js)	0.20KB	0.18KB
types (select-option.js)	0.20KB	0.19KB
types (spec-report.js)	4.99KB	1.96KB
types (spec-ui-namespace.js)	0.20KB	0.19KB
types (strict-authoring-face.js)	19.93KB	7.26KB
types (system-fields.js)	3.33KB	1.54KB
types (theme.js)	6.28KB	2.87KB
types (ui-action.js)	8.48KB	3.50KB
types (views.js)	0.20KB	0.18KB
types (widget.js)	0.20KB	0.18KB

Size Limits

• ✅ Core packages should be < 50KB gzipped
• ✅ Component packages should be < 100KB gzipped
• ⚠️ Plugin packages should be < 150KB gzipped

[objectstack-fleet]

Landing · head 04e029f · 2026-10-16T00:08Z

• Checks on 04e029f: 34 success, plus 3 expected skips (dependabot, Test (coverage), Test (coverage shard …)). Nothing is red. The 16 test shards carry the full @object-ui/app-shell suite, and it passed.
• Mergeable: yes (clean). git merge-tree against current main (daeb77f) is clean. The queue's merge group runs the full CI on the combined tree.
• Siblings in flight on StudioDesignSurface.tsx, this seat: objectui#12524 (the item headers), objectui#12513 (the home button and switcher) and objectui#12517 (the Publish and Changes triggers), each still in its cloud session and in another region.
• Path surface: no governed path; Governed Surface Queue Guard is green. The ACCEPT 6204781007 lists the files.
• Nothing has been posted since the ACCEPT: no review, no review comment and no objection.
• Action: mark it ready for review, then enable auto-merge through the merge queue. Fixes #12516 closes the card on merge.

---

Generated by Claude Code