Skip to content

fix(data-objectstack,app-shell): Publish all publishes each bundle member of a package-less draft by its own ?member= (objectui#12402) - #12410

Merged
objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-12402-publish-all-member
Oct 15, 2026
Merged

objectstack-fleet[bot] merged 3 commits into
mainfrom
claude/issue-12402-publish-all-member

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Fixes #12402
Clause-②: yes (widening)

What this does

"Publish all" (Home's banner and the draft-preview bar, both usePublishAllDrafts) now publishes each language of a package-less email_template by its own bundle member.

Public-surface change, for the contract review

  • Widened: one exported method, MetadataClient.publishDraft. It gains an optional third parameter options: { member?: string } = {}. The return type is unchanged. Every existing call has two arguments and sends exactly the URL it sent before: pinned as "keeps the two-argument call byte for byte".
  • Unchanged: every other MetadataClient method, MetadataDraftHeader, the advisory event shape (emitAdvisories still names type and name only), and the batch door.
  • Wire contract it follows, read upstream (read-only): objectstack 038d4c958 (ruling 6116165299 on objectstack#22877). POST /meta/:type/:name/publish has the closed query set package, member. An absent selector means the canonical member. A blank selector, or any selector on a type with no discriminator (every type but email_template), is a located 400 VALIDATION_ERROR. So the client sends the parameter only when the caller has a member. It never sends an empty one, and the hook never makes one up for a member-less row.
  • Source of member: the installed @objectstack/spec 18.0.0-next.1 declares ListDraftsResponseSchema.drafts[].member as z.ZodOptional of z.ZodString, read from its dist .d.ts.

Premise measurements (dispatch assumptions)

  • A1, held. The hook mapped rows to { type, name, packageId } and dropped member. The package-less loop called client.publishDraft(d.type, d.name).
  • A2, held. publishDraft took no member and sent no query string.
  • A3, nothing to change. The hook has no result de-duplication and no toast or progress keyed on type + name. The one per-item string (NAME: sample data failed to load) is for seed drafts, which carry no member. lintDraftCapabilityReferences receives the rows but lints only object, app and action, which never carry a member.

Tests

Tree 062328bf6.

  • New packages/data-objectstack/src/metadata-client.publishDraftMember-12402.test.ts (5 cases):
    • a member is sent as ?member=;
    • two members of one name go to two URLs;
    • absent, {}, an empty string and undefined send no parameter;
    • the two-argument call is byte for byte what it was;
    • encoding.
  • New packages/app-shell/src/preview/__tests__/usePublishAllDrafts.bundleMember-12402.test.tsx (3 cases). This is the card's pins, through the real hook, useMetadataClient and MetadataClient, with fetch stubbed:
    • two package-less members of one email_template publish with ?member=en-US and ?member=zh-CN;
    • a member-less flow, and a row with an empty member, send no selector;
    • package-bound members go through one publish-drafts call and get no by-name publish, while a package-less member beside them gets its own ?member=.
  • Results under the verify lock:
    • vitest run packages/data-objectstack/ packages/app-shell/src/preview/: Test Files 115 passed (115), Tests 1316 passed (1316).
    • The two new files alone: Test Files 2 passed (2), Tests 8 passed (8).
  • Hook consumers (packages/app-shell/src/console/home/__tests__/ and useMetadataClient.advisorySink.test.tsx): Test Files 22 passed (22), Tests 134 passed (134). This ran outside the lock with --maxWorkers=1, a declared narrowing: two 9-minute lock waits timed out (exit 99) behind a full packages/app-shell/ run.
  • NOT MEASURED: the full app-shell vitest project. One lock attempt was cut off by the foreground cap after a 4.5-minute queue. The later waits timed out as above. This is declared to CI.

Ablation (one-off, through ablation-replace.mjs)

  • The run went through node ablation-replace.mjs from the objectstack checkout.
  • Mutation: in usePublishAllDrafts.ts, the argument d.member ? { member: d.member } : {} was replaced with an empty object carrying a marker comment. Anchor count went 1 to 0, the marker 0 to 1, and the blob fec8eed29b27 to 308438498f04.
  • Result: Tests 2 failed | 1 passed (3). The two-members pin and the package-bound-plus-package-less pin went red. The member-less pin stayed green. That is the predicted direction.
  • Restore: the blob equals HEAD fec8eed29b27 and git diff HEAD is empty.
  • The first attempt used a replacement already present in the file. The tool refused it as a no-op (replacement count 3 to 3) and restored it before running anything. It is not counted as an ablation run.
  • The mutated file is app-shell source imported relatively by the test, so no dist rebuild was involved.

Gates (recorded exit codes, tree 062328bf6)

  • 0: type-check for @object-ui/data-objectstack and @object-ui/app-shell. This ran after the closure build turbo run build --filter=@object-ui/app-shell^... (28 tasks, exit 0), which rebuilt data-objectstack's dist with the new parameter. The app-shell type-check includes tsconfig.test.json. The data-objectstack tsconfig.json includes src/**/*, tests included.
  • 0: check:phantom-deps, check:self-import, check:unreferenced-sources, check:doc-example-readers, check:handler-key-reads, check:side-effects-array, check:element-data-source-declaration, check:spec-symbols, check:action-forward-parity, check:designer-field-key-parity, check:icon-record-names, check:i18n-keys, check:i18n-drift, check:i18n-designer-parity, check:control-bytes.
  • 0, also run because they are implicated (a new vi.mock file, a new changeset, a metadata-client.ts edit): check:vi-mock-specifiers, check:vi-mock-inherit, check:vi-mock-override-shape, check:test-path-roots, check:new-line-citations, check:changeset-claims, check:pending-changeset-literals, check:metadata-write-doors, scripts/check-changeset-fixed.mjs, scripts/check-changeset-presence.mjs, scripts/check-changeset-no-major.mjs.
  • 1: check:spec-floors, the known failure on main (objectui#12334). Its output is "The scan collapsed: 0 package(s) declare @objectstack/spec in a consumer-facing field". It was recorded and not touched.
  • eslint --no-inline-config narrowed to the 4 changed files:
    • Exit 0, 0 errors, 11 warnings, all no-explicit-any.
    • The base blobs carry the same count, 3 + 8, read with eslint --stdin.
    • The population is files: ['**/*.{ts,tsx}'] in eslint.config.js. The file count of 4 comes from the --format json output.
    • Type-aware linting is not enabled there, so this diff cannot move the verdict on an untouched file.

Changeset

.changeset/12402-publish-all-member.md:

  • @object-ui/data-objectstack is minor, an additive widening of a published method. objectui never declares major.
  • @object-ui/app-shell is patch.

Acceptance notes

  • MetadataDraftHeader, the declared return element of listDrafts(), still has no member, although the spec row declares it. The hook reads rows through as any[], so nothing here needed the type. Widening it is a second public-type change outside this card's file surface (publishDraft only). Carrier: none.

  • The advisory event that publishDraft emits names type and name but not the member. So an advisory on a zh-CN publish reads as the template's, not the language's. This is presentation only. It stays out of scope by the dispatch's "no other client method changes". Carrier: none.

  • Adds no product-specific widget, dialog, hook or string (see AGENTS.md › Product-neutral renderer)

Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB


Generated by Claude Code

…mber of a package-less draft by its own ?member= (objectui#12402)

MetadataClient.publishDraft takes an optional member, sent as ?member= only
when given; usePublishAllDrafts keeps each _drafts row's member and passes it
on the package-less path.

Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
Co-authored-by: Claude <noreply@anthropic.com>
… Publish all's package-less path (objectui#12402)

Claude-Session: https://claude.ai/code/session_01XVp19E1MYUTFM3dnkwz8gB
Co-authored-by: Claude <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

✅ Console Performance Budget

Metric Value Budget
Eager closure (gzip, 69 chunks) 3075.4 KB 3119.4 KB
Main entry chunk (gzip) 73.9 KB 350 KB
Entry file index-D295vIDw.js —
Status PASS —

The eager closure is every chunk the entry reaches through static imports — what the browser fetches and parses before the app renders. The entry chunk on its own is a small fraction of it.


📦 Bundle Size Report

Package Size Gzipped
app-shell (consoleActionDispatch.js) 0.20KB 0.19KB
app-shell (index.js) 20.90KB 7.67KB
app-shell (runtime-config.js) 22.59KB 7.89KB
app-shell (types.js) 0.01KB 0.04KB
app-shell (urlParams.js) 10.11KB 3.87KB
auth (ActiveOrganizationStorage.js) 27.95KB 10.04KB
auth (AuthContext.js) 0.31KB 0.24KB
auth (AuthGuard.js) 2.07KB 1.00KB
auth (AuthProvider.js) 40.22KB 10.61KB
auth (AuthShell.js) 3.49KB 1.40KB
auth (ForgotPasswordForm.js) 12.21KB 3.45KB
auth (LoginForm.js) 18.15KB 5.40KB
auth (PreviewBanner.js) 0.90KB 0.50KB
auth (RegisterForm.js) 6.72KB 2.24KB
auth (SocialSignInButtons.js) 9.70KB 3.93KB
auth (UserMenu.js) 3.39KB 1.21KB
auth (auth-gate-events.js) 1.62KB 0.83KB
auth (authStyles.js) 5.04KB 1.72KB
auth (createAuthClient.js) 41.19KB 11.12KB
auth (createAuthenticatedFetch.js) 8.54KB 3.46KB
auth (index.js) 3.63KB 1.64KB
auth (invitation-status.js) 1.22KB 0.70KB
auth (org-roles.js) 6.66KB 2.78KB
auth (phone-identifier.js) 1.11KB 0.66KB
auth (types.js) 0.59KB 0.35KB
auth (useAuth.js) 5.30KB 1.02KB
auth (useWorkspaceAdminStatus.js) 11.08KB 4.58KB
collaboration (CommentThread.js) 27.26KB 8.03KB
collaboration (LiveCursors.js) 3.17KB 1.27KB
collaboration (PresenceAvatars.js) 6.28KB 2.60KB
collaboration (PresenceProvider.js) 2.79KB 1.13KB
collaboration (commentAuthorship.js) 1.39KB 0.78KB
collaboration (index.js) 1.93KB 0.85KB
collaboration (useCollaborationTranslation.js) 6.50KB 2.52KB
collaboration (useCommentSearch.js) 1.98KB 0.88KB
collaboration (useConflictResolution.js) 7.75KB 1.86KB
collaboration (useMentionNotifications.js) 1.81KB 0.68KB
collaboration (usePresence.js) 6.33KB 1.84KB
collaboration (useRealtimeSubscription.js) 7.91KB 2.01KB
components (index.js) 591.88KB 142.76KB
core (index.js) 10.18KB 4.04KB
create-plugin (index.js) 27.94KB 9.51KB
data-objectstack (index.js) 250.77KB 70.23KB
fields (index.js) 282.89KB 72.11KB
i18n (LocalizationContext.js) 2.92KB 1.42KB
i18n (builtinAggregateLabels.js) 0.86KB 0.49KB
i18n (currency.js) 2.59KB 1.22KB
i18n (fallbackInterpolation.js) 6.25KB 2.77KB
i18n (i18n.js) 8.87KB 3.64KB
i18n (index.js) 5.52KB 2.39KB
i18n (pickLocalized.js) 9.86KB 3.95KB
i18n (provider.js) 39.35KB 12.88KB
i18n (translateFn.js) 0.20KB 0.18KB
i18n (useDisplayLocale.js) 3.52KB 1.76KB
i18n (useObjectLabel.js) 36.87KB 9.88KB
i18n (useSafeTranslation.js) 7.14KB 2.92KB
layout (index.js) 40.26KB 11.71KB
mobile (MobileProvider.js) 0.92KB 0.49KB
mobile (ResponsiveContainer.js) 0.94KB 0.38KB
mobile (breakpoints.js) 1.51KB 0.70KB
mobile (createOfflineDataSource.js) 5.61KB 1.75KB
mobile (index.js) 1.99KB 0.87KB
mobile (offlineQueue.js) 3.91KB 1.35KB
mobile (pwa.js) 0.97KB 0.49KB
mobile (serviceWorker.js) 1.48KB 0.62KB
mobile (serviceWorkerSource.js) 3.41KB 1.48KB
mobile (useBreakpoint.js) 1.54KB 0.65KB
mobile (useGesture.js) 6.96KB 1.98KB
mobile (useOfflineSync.js) 1.99KB 0.72KB
mobile (usePullToRefresh.js) 6.62KB 2.45KB
mobile (useResponsive.js) 0.72KB 0.42KB
mobile (useSpecGesture.js) 5.52KB 2.10KB
mobile (useTouchTarget.js) 1.01KB 0.54KB
permissions (MePermissionsProvider.js) 15.35KB 5.51KB
permissions (PermissionContext.js) 0.31KB 0.25KB
permissions (PermissionGuard.js) 0.89KB 0.45KB
permissions (PermissionProvider.js) 6.82KB 2.38KB
permissions (discardProofCache.js) 1.04KB 0.55KB
permissions (evaluator.js) 8.33KB 3.07KB
permissions (index.js) 0.93KB 0.41KB
permissions (store.js) 0.91KB 0.42KB
permissions (useFieldPermissions.js) 1.28KB 0.53KB
permissions (usePermissions.js) 4.83KB 2.27KB
plugin-ai (index.js) 16.04KB 3.92KB
plugin-calendar (index.js) 54.94KB 16.05KB
plugin-charts (index.js) 84.97KB 23.36KB
plugin-chatbot (index.js) 201.72KB 48.07KB
plugin-dashboard (index.js) 143.88KB 38.88KB
plugin-designer (index.js) 233.95KB 50.08KB
plugin-detail (index.js) 262.05KB 69.25KB
plugin-editor (index.js) 2.23KB 1.05KB
plugin-form (index.js) 179.38KB 46.59KB
plugin-gantt (index.js) 178.36KB 45.08KB
plugin-grid (index.js) 261.69KB 72.58KB
plugin-kanban (index.js) 53.23KB 16.71KB
plugin-list (index.js) 123.37KB 31.61KB
plugin-map (index.js) 27.07KB 8.96KB
plugin-markdown (index.js) 13.88KB 4.80KB
plugin-report (index.js) 46.66KB 13.13KB
plugin-timeline (index.js) 39.21KB 11.85KB
plugin-tree (index.js) 15.07KB 5.33KB
plugin-view (index.js) 91.99KB 23.23KB
providers (DataSourceProvider.js) 0.75KB 0.39KB
providers (MetadataProvider.js) 1.37KB 0.59KB
providers (ThemeProvider.js) 1.90KB 0.85KB
providers (UploadProvider.js) 12.07KB 3.68KB
providers (index.js) 0.45KB 0.23KB
providers (types.js) 0.01KB 0.04KB
react-runtime (index.js) 5.62KB 2.34KB
react (LazyPluginLoader.js) 4.47KB 1.63KB
react (SchemaRenderer.js) 120.63KB 39.56KB
react (data-invalidation.js) 5.05KB 2.08KB
react (index.js) 4.50KB 2.06KB
react (schema-input.js) 4.31KB 2.07KB
react (spec-input.js) 0.20KB 0.18KB
sdui-parser (body-dialect.js) 4.50KB 1.99KB
sdui-parser (codegen.js) 9.45KB 3.76KB
sdui-parser (dashboard-widget-options.js) 3.07KB 1.30KB
sdui-parser (index.js) 7.30KB 3.12KB
sdui-parser (input-type.js) 2.84KB 1.40KB
sdui-parser (parse.js) 25.28KB 7.81KB
sdui-parser (provenance.js) 3.84KB 1.90KB
sdui-parser (types.js) 0.29KB 0.24KB
sdui-parser (validate.js) 23.87KB 7.83KB
types (ai.js) 4.39KB 2.17KB
types (api-types.js) 0.20KB 0.18KB
types (app.js) 4.12KB 1.61KB
types (authoring-nodes.js) 0.20KB 0.19KB
types (base.js) 0.20KB 0.18KB
types (blocks.js) 0.20KB 0.18KB
types (cloud.js) 0.20KB 0.18KB
types (complex.js) 4.44KB 2.07KB
types (crud.js) 0.20KB 0.18KB
types (dashboard-filter-alias.js) 6.23KB 2.74KB
types (dashboard-widget-layout.js) 2.06KB 0.96KB
types (data-display.js) 3.75KB 1.85KB
types (data-protocol.js) 0.20KB 0.19KB
types (data.js) 0.20KB 0.18KB
types (designer.js) 1.85KB 0.85KB
types (disclosure.js) 0.20KB 0.18KB
types (error-code.js) 1.54KB 0.88KB
types (expression.js) 0.20KB 0.18KB
types (feedback.js) 0.20KB 0.18KB
types (field-types.js) 1.13KB 0.65KB
types (form.js) 0.20KB 0.18KB
types (http-inflight.js) 8.87KB 3.73KB
types (http-retry.js) 4.32KB 2.02KB
types (icon-key-migration.js) 4.26KB 1.63KB
types (index.js) 5.78KB 2.70KB
types (layout.js) 0.20KB 0.18KB
types (managed-by.js) 0.19KB 0.18KB
types (mobile.js) 5.00KB 2.39KB
types (navigation.js) 0.20KB 0.18KB
types (node-slots.js) 7.18KB 2.34KB
types (objectql.js) 0.20KB 0.18KB
types (overlay.js) 0.20KB 0.18KB
types (permissions.js) 2.52KB 1.31KB
types (plugin-scope.js) 0.20KB 0.18KB
types (record-approval-decision.js) 0.20KB 0.20KB
types (record-components.js) 0.20KB 0.19KB
types (record-panels.js) 0.20KB 0.19KB
types (record-semantics.js) 1.28KB 0.67KB
types (registry.js) 0.20KB 0.18KB
types (reports.js) 0.20KB 0.18KB
types (select-option.js) 0.20KB 0.19KB
types (spec-report.js) 4.99KB 1.96KB
types (spec-ui-namespace.js) 0.20KB 0.19KB
types (strict-authoring-face.js) 19.93KB 7.26KB
types (system-fields.js) 3.33KB 1.54KB
types (theme.js) 6.28KB 2.87KB
types (ui-action.js) 8.48KB 3.50KB
types (views.js) 0.20KB 0.18KB
types (widget.js) 0.20KB 0.18KB

Size Limits

  • ✅ Core packages should be < 50KB gzipped
  • ✅ Component packages should be < 100KB gzipped
  • ⚠️ Plugin packages should be < 150KB gzipped

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 062328bf65da8b843c7f5b91d4d1bb8104bfee01
Local-runs: none

Inputs read: card #12402 (body; triage 6181928646; claim 6182177269; dev report 6182978375), PR #12410 (body, 5-file list, net diff of the head against its base), the check-runs on the head, and, for context, the upstream by-name door (objectstack 038d4c958, META_ITEM_PUBLISH_PARAMS = member, package; blank selector refused; absent selector = canonical member) and the two siblings on main (PR #12400's member= spelling in DraftChangesPanel, PR #12396's reset() param-building shape). Nothing built, run or re-run.

① Derived judgments

  • publishDraft is strictly additive — right. The third parameter is options: { member?: string } = {}; the return type and the request method, headers and body are untouched. The only other in-repo caller, StudioDesignSurface.tsx:1182 (shellClient.publishDraft('flow', d.name)), still makes the two-argument call, and the client test pins that call to the exact URL it sent before (/api/v1/meta/view/cases/publish, no query). Existing callers keep their exact wire.
  • member= sent only when set, never empty — right. if (options.member) params.push(...) drops undefined and '' alike; the test pins undefined, {}, { member: '' } and { member: undefined } to a URL with no ? at all. That matches the upstream door, which refuses a blank selector as a located 400 and reads an absent one as the canonical member.
  • Spelled as the by-name doors spell it — right. The query key is member, the same META_ITEM_MEMBER_PARAM the upstream door declares in its closed set for POST /publish (member, package), and the same member=${encodeURIComponent(...)} form DraftChangesPanel.tsx:223 already uses on the by-name reads (PR fix(app-shell): Studio's draft panel and build history address a bundle member (?member=) #12400). The param-building shape (params[] → qs) is the one reset() uses (PR fix(data-objectstack,app-shell,plugin-designer): a console reset or discard names the package whose row it removes (objectui#12335) #12396). Encoding is pinned (x&y z → x%26y%20z).
  • Package-bound path unchanged — right. The diff does not touch publishPackageDrafts or the for (const packageId of packageIds) loop; rows with a packageId never reach the by-name loop. The hook test pins two package-bound members to one /publish-drafts call and no by-name publish, with a package-less member beside them getting its own ?member=.
  • Hook carries only a non-empty member — right. The row map spreads member only when typeof d.member === 'string' && d.member; the by-name loop passes d.member ? { member: d.member } : {}. A flow row without member and an email_template row with member: '' are pinned to selector-less URLs. The capability lint receives the same rows plus an optional member, which it never reads (its client face is getDraft/list only).
  • No other accept-set moves. listDrafts, MetadataDraftHeader, emitAdvisories's event shape, the batch door and publish() are byte-identical. The changeset's claims match the diff. The dev's ablation (hook argument replaced by {}: the two member pins red, the member-less pin green) is read from the report, not re-run.

② Semver level

  • .changeset/12402-publish-all-member.md: @object-ui/data-objectstack: minor, @object-ui/app-shell: patch. Right: the widening of a published method is at least minor under Clause-②: yes; the app-shell change is behaviour inside an existing hook with no new export. No skip-changeset. No major (objectui's rule). Both packages are in the fixed group, so the group bumps together.
  • Clause-②: yes (widening) on line 2 of the PR body matches the diff: one exported method gains one optional parameter; nothing is narrowed or removed. The claim's Clause-②: yes (widening) and triage's reading agree.
  • Changeset gates on the head: Changeset Declaration, Changeset Bump Policy, Changeset Claim Re-read, Changeset Fixed Group Check, Changeset Overwrite Report all success.

③ Boundary flags

  • Dev open_questions: none declared.
  • Dev note 1 — MetadataDraftHeader has no member although ListDraftsResponseSchema.drafts[].member declares it. Answered: not blocking. The hook reads rows as any[], so the missing type member cannot produce a wrong URL, and widening the published interface is a second public-type change the dispatch's file surface (publishDraft only) excludes. Escalated as a follow-up card for the domain:ui lane (a Clause-②: yes (widening) of MetadataDraftHeader); not a condition of this verdict.
  • Dev note 2 — the advisory event publishDraft emits names type and name but not member. Answered: not blocking. MetadataSaveAdvisoryEvent is a published type; adding member to it is outside this card's surface and the event's recipients today key on type and name. A zh-CN publish's advisory therefore reads as the template's. Escalated with note 1 as the same follow-up card; presentation only, not reproduced.
  • Declared narrowings in the report (full app-shell vitest project NOT MEASURED locally; hook-consumer tests run outside the lock): answered by the head's check-runs, which are the gate verdicts — see below.
  • Serial note on the card (metadata-client.ts shared with metadata-client: reset() cannot name a package — after objectstack#23165 a console reset or discard of an item two packages hold answers 409, and the remedy ?package= is one the console cannot send #12335): cleared in the claim (d12bc5f landed); the head's reset() is the landed one and the diff touches only publishDraft.
  • check:spec-floors exit 1 locally is the known main failure (objectui#12334), declared and not touched; the head's Spec Main Shape Gate check-run is the verdict on that family.

Check-runs on 062328bf65da8b843c7f5b91d4d1bb8104bfee01 at the time of this record: 36 of 37 completed, every completed one success or skipped (skipped: the coverage matrix and dependabot): Test (all 16 shards and the aggregate), Type Check, Lint, Repo Gates, Build & E2E, Build Docs, Bundle Analysis, Test (dist pins), Line Citation Gate, Governed Surface Queue Guard, label, Live E2E (informational), and the five Changeset checks. Spec Main Shape Gate was still in_progress after about nine minutes of polling; this record does not claim it. The dev's locally NOT MEASURED full app-shell project is answered by the green test shards.

Implemented-by: claude/issue-12402-publish-all-member
Reviewed-by: session_01XVp19E1MYUTFM3dnkwz8gB

VERDICT: PASS


Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

2 participants