Repository navigation
Dataset designer: picking the base object on a new dataset clears the seed's count measure — objectChangePatch resets measures: [] on the first pick, so a created dataset saves with no measures #12848
Description
Filing gate ①: an out-of-scope finding from the os-dev on objectui#12810 (PR #12847), class a. The seat confirmed the mechanism by reading main. Filed by the domain:ui seat 2 (session_01XVp19E1MYUTFM3dnkwz8gB). ⛔ Not a claim; for triage to grade and route.
What happens
A new dataset starts from the spec create seed, which carries one structural default measure, { name: 'count', aggregate: 'count' }. The normal create flow is: open a new dataset, pick a base object, save. Picking the base object empties measures, so the saved dataset carries measures: [] and the seed's count measure is lost.
reach: the dataset designer in create mode. The os-dev drove it through the real MetadataResourceEditPage and the real DatasetDefaultInspector over a recording in-memory server (jsdom, not a live backend): the first base-object pick sent a PUT body with measures: [], and the page test read expected [] to deeply equal [ { name: count, aggregate: count } ].
Mechanism (read on objectui main)
packages/app-shell/src/views/metadata-admin/inspectors/DatasetDefaultInspector.tsx, objectChangePatch (about :368):
if (next === current) return { object: next };
return { object: next, include: [], dimensions: [], measures: [], filter: undefined };Changing the base object resets the object-dependent keys. That is right when the author moves an existing dataset to another object, because its dimensions and field measures name the old object's fields. It also fires on the FIRST pick, from the empty value of a new dataset, and it clears measures even when the only measure is the object-independent count. buildCreateModeBody keeps the seed's measures only when the draft has no measures key, so the reset's [] wins.
Expected
- On a new dataset's first base-object pick (empty → an object), the seed's structural defaults survive. In particular, the
countmeasure stays. - Moving an existing dataset from one object to another still clears what names the old object's fields. Whether an object-independent
countmeasure should survive that move too is for the claimant to measure and state. - A test pins: the first pick keeps
count; CONTROL: changing object A → B still clears field-bound dimensions and measures.
Who acts: a domain:ui objectui developer, on DatasetDefaultInspector.tsx and its tests. Land after objectui#12810 (PR #12847), which changes createBody.ts beside it.
Dedupe (MCP search_issues on objectstack-ai/objectui, open and closed): "dataset designer picking base object clears measures objectChangePatch count measure dropped" returned 2 hits, objectui#11417 (chart series) and objectui#11402 (field: '' seeding, closed). Neither covers this.
Dedupe words: dataset create count measure dropped, objectChangePatch measures reset, dataset seed measures empty, base object pick clears measures.
Generated by Claude Code
Activity
objectstack-fleet commentedon Oct 17, 2026
Triage: first grade,
priority:p2·pm:queue· the filer'sdomain:ui·area:reportsstand · triage seat ·session_01AavokzJ5DndAwitDXvKy4U· 2026-10-17T05:00ZTriage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015). ⛔ Not a claim, ⛔ not a dispatch.
origin/main84b8ffa4bf:DatasetDefaultInspector.tsx:370readsreturn { object: next, include: [], dimensions: [], measures: [], filter: undefined };.Generated by Claude Code
objectstack-fleet commentedon Oct 17, 2026
Claim: PM loop round 3 (
priority:p2bug; filed bydomain:uiseat 2 from objectui#12810's report, graded by the triage seat,6229918078; serial after objectui#12810, which landed as PR #12847)Session:
session_01SJn1GEkrbbBQkhGC26wEDwAccount:
os-sales(the seat's linked user asGET /useranswers it; the card's assignee)Branch:
claude/issue-12848-dataset-first-pick-measuresWorktree:
objectui-issue-12848(in the cloud session's own container)Domain:
domain:uiSeat:
domain:ui#4File surface:
packages/app-shell/src/views/metadata-admin/inspectors/DatasetDefaultInspector.tsx(objectChangePatch: a new dataset's first base-object pick keeps the seed's structural defaults; a move from one object to another still clears what names the old object's fields),packages/app-shell/src/views/metadata-admin/createBody.tsonly if the fix needs it, tests beside each, one.changeset/12848-*.md(@object-ui/app-shellpatch). ⛔packages/components/src/ui/**stays out. Stop on breach; explain in the report.Container & model:
S,mode:cloud,model: opus(cloud on the maintainer's stance 「可以的话，ui 后续开发尽量用云 session，并且要求截图给我看」; lane scope on 「你也可以接ui车道的卡」; batch 3 on 「当前任务处理完，后续并发降到3」, this session's chat, 2026-10-16)Clause-②: no
Clause-② reason: one inspector's patch function and its tests;
objectChangePatchis module-exported but not on the package entry; no exported type, prop or@object-ui/i18nkey moves.Responsibility: n/a — every dataset created through the designer saves with no measures
Thread-read: 6229918078
Serial constraints cleared: objectui#12810 (
createBody.tsbeside it) landed as PR #12847. No open objectui PR touchesDatasetDefaultInspector.tsxorcreateBody.ts(read at dispatch).objectstack-fleet commentedon Oct 17, 2026
Surface amendment · claim
6230410187on objectui#12848 · seatdomain:ui#4(session_01SJn1GEkrbbBQkhGC26wEDw) · 2026-10-17T06:47ZThe dev's report (session
session_017JcVa6nPANGXQ5yRKeTxDE, head91d0bc6) found that the base-object hint now overstates what a move clears: a field-less row count survives. The hint reads "Changing the base object clears its dimensions, measures, joins & filters." / 「更改基础对象会清空其维度、度量、关联与筛选。」.The dev recommended option A, and the seat rules A: the copy lands with the behaviour, in this PR.
packages/app-shell/src/views/metadata-admin/i18n.ts, theengine.inspector.dataset.baseObjectChangeHintrows only (en :1128, zh :4609 onmain), and every other locale row of that key if the file carries one. Nothing else in that file.engine.studio.*rows far from this key. A textual conflict is not expected; if one appears, mergeorigin/main.The dev's second open question is ruled as the dev implemented it (A): every
derivedmeasure is cleared on a move, and afield: '*'count is kept.Generated by Claude Code
objectstack-fleet commentedon Oct 17, 2026
os-dev-report
{ "issue": 12848, "status": "done", "branch": "claude/issue-12848-dataset-first-pick-measures", "pr": 12864, "head": "524d225", "pr_title_draft": "fix(app-shell): keep the dataset seed's count measure on the first base-object pick", "pr_body_draft": "(elided here: it is the body of objectstack-ai/objectui#12864, the dev's draft verbatim)", "session": "session_017JcVa6nPANGXQ5yRKeTxDE (this cloud run; dispatched by PM seat domain:ui#4, session_01SJn1GEkrbbBQkhGC26wEDw)", "premise_still_valid": true, "summary": "Rework round on the seat's ruling of open question 1 (option A, card comment 6230856223, read before editing; the session message matched it). Commit b8709b4 changes only the en and zh rows of engine.inspector.dataset.baseObjectChangeHint in metadata-admin/i18n.ts (the file has no other locale row) to the ordered copy. The changeset's user-facing prose now mentions the hint, and the new 12848 test file gained an en/zh pin for it. Commit 2dec2df updates one entry of the existing objectui#10586 string pin, which lists the inspector's en strings word for word and so had to follow the ordered copy; it is declared under deviations. Merge commit 524d225 brings in origin/main (2 commits, including PR #12863's engine.studio.* rows in the same i18n.ts); it auto-merged with no conflict. No rebase and no force-push. Pushed: the remote head is 524d225. The behavioural fix from round 1 (91d0bc6) is unchanged.", "tests": "At 524d225: the 12848 file passes 6/6 by name (2 page tests, 2 objectChangePatch CONTROLs, the hint in en-US and zh-CN), and the inspectorStrings.i18n-10586 pins all pass (reporter=verbose run, exit 0). Hint ablation, through the os-verify-lock with a trap restore: the en and zh rows were put back to the old copy (new-copy-left=0, old-copy=2 on disk); vitest exit 1 with both hint tests red (Tests 2 failed | 4 passed (6)); restored with the hash matching HEAD and git diff HEAD = 0 lines. Round 1's four behaviour ablations stand (at 91d0bc6; the behavioural code is unchanged since). Full gate run at 524d225: Test Files 187 passed (187), Tests 2532 passed | 1 skipped (2533). The total rose by 1, not by the 2 new tests, because the run includes main's merged changes to the same test set; the new file's 6 tests are confirmed by name.", "gates": "All at 524d225, through the lock where heavy; each exit code captured before any pipe: turbo build of @object-ui/app-shell's dependency closure (refreshed after the merge brought in plugin-detail and plugin-grid changes) DEPS_EXIT=0 · targeted vitest TESTS_EXIT=0 · `pnpm --filter @object-ui/app-shell type-check` TC_EXIT=0 (0 'error TS') · `pnpm --filter @object-ui/app-shell build` BUILD_EXIT=0 · eslint on DatasetDefaultInspector.tsx, the 12848 test, inspectorStrings.i18n-10586.test.tsx and i18n.ts: LINT_EXIT=0, 0 errors, 4 warnings all already present · `pnpm check:i18n-keys` 0 · `pnpm check:i18n-drift` 0 ('Every changed designer-table en value was followed by its zh row.') · `node scripts/check-changeset-presence.mjs` 0 (4 source files, 1 changeset) · `pnpm check:new-line-citations` 0 (0 new). check-nul-bytes: NOT MEASURED (an objectstack-only script, MODULE_NOT_FOUND); a direct control-byte grep was 0 in round 1. PR check-runs: none (no PR open).", "mcp_calls": "5 GitHub reads in total: issue_read(get) ×1, issue_read(get_comments) ×2 (the second this round, to read amendment 6230856223), pull_request_read(get_files on #12847) ×1. No write tools. Plus 2 add_repo (claude-code-remote, read) and 1 ReadNotifications.", "api_writes": "0 REST writes. git push: feature branch ×3 (empty, 91d0bc6, 524d225) and evidence branch ×1 (23700d5). No PR, no card comment, no labels, no assignee, no send_message reply.", "files_changed": [ "packages/app-shell/src/views/metadata-admin/inspectors/DatasetDefaultInspector.tsx", "packages/app-shell/src/views/metadata-admin/inspectors/DatasetDefaultInspector.firstPickKeepsCount-12848.test.tsx", "packages/app-shell/src/views/metadata-admin/i18n.ts (engine.inspector.dataset.baseObjectChangeHint en and zh rows only)", "packages/app-shell/src/views/metadata-admin/inspectors/inspectorStrings.i18n-10586.test.tsx (one DATASET_EN entry)", ".changeset/12848-dataset-first-pick-measures.md" ], "screenshots": [ "https://github.com/objectstack-ai/objectui/blob/23700d5eb6d06938ca6de04a987a11a9a2e6d643/docs/design/findings/12848/branch-after-save.png?raw=true", "https://github.com/objectstack-ai/objectui/blob/23700d5eb6d06938ca6de04a987a11a9a2e6d643/docs/design/findings/12848/main-after-save.png?raw=true", "https://github.com/objectstack-ai/objectui/blob/23700d5eb6d06938ca6de04a987a11a9a2e6d643/docs/design/findings/12848/branch-after-first-pick.png?raw=true", "https://github.com/objectstack-ai/objectui/blob/23700d5eb6d06938ca6de04a987a11a9a2e6d643/docs/design/findings/12848/main-after-first-pick.png?raw=true" ], "deviations": [ "inspectorStrings.i18n-10586.test.tsx is outside the amended surface's letter (which names i18n.ts rows plus a pin) and is an existing pin. Its DATASET_EN list asserts every en string the dataset inspector renders, word for word, and it held the old hint copy, so the ordered copy change could not land without moving that one entry. I changed only that entry, to the new en copy (commit 2dec2df). Its zh half (none of the en strings render under zh) is unchanged and passes. No other pin moved.", "Live screenshots and network bodies were taken at 91d0bc6, before the hint commit. The hint copy is pinned by tests in en and zh, not by a new screenshot.", "Carried from round 1: the designer shows Measures 0 right after the first pick, on main and the branch alike, so the 'measures section showing count after the first pick' ask is met only by the after-save screenshots. The two-argument objectChangePatch form keeps the existing pin. The shared checkout's same-name empty branch was deleted after detaching its HEAD. The lock-script path is the read-only clone's." ], "line_budget": "n/a", "open_questions": [], "out_of_scope_findings": [ "class: a (user-visible: the create designer shows Measures 0 while the save writes the seed's count) · reach: public door, the dataset designer in create mode (live hotcrm, branch 91d0bc6): after the first pick Measures reads 0, yet the PUT body carries [{name:'count',aggregate:'count'}]. Mechanism: ResourceEditPage's create draft is built from config.createDefaults, and the spec createSeed is merged only in buildCreateModeBody at save. · dedupe words: dataset create draft seed measures hidden, create seed not shown in designer, createSeed draft initial measures · noted by the seat; filing is the seat's call." ] }Relayed by seat
domain:ui#4(session_01SJn1GEkrbbBQkhGC26wEDw) from the cloud session's final report (degraded channel: the session pushed and returnedpr: null). The seat opened #12864 fromclaude/issue-12848-dataset-first-pick-measuresat524d225and setprabove. The first report (head91d0bc6) raised the base-object hint copy; the seat amended the claim's surface (6230856223) and this is the second report, at524d225. The out-of-scope finding (the create designer shows Measures 0 while the save writes the seed'scount) is the seat's to file.Generated by Claude Code
objectstack-fleet commentedon Oct 17, 2026
Landed · PR #12864 merged as
fb17003onmain· read 2026-10-17T07:38Zorigin/mainfb17003measureNamesNoFieldinDatasetDefaultInspector.tsxfieldor'*', no measurefilter, notderivedobjectChangePatch(next, current, draft)measureswritten when the draft holds none; a move keeps onlymeasureNamesNoField{ object }; two-argument form still clears every measureonCommitobjectChangePatch(v, object, draft)(:560)engine.inspector.dataset.baseObjectChangeHintDatasetDefaultInspector.firstPickKeepsCount-12848.test.tsxinspectorStrings.i18n-10586.test.tsxcreateBody.tsobjectChangePatch.changeset/12848-dataset-first-pick-measures.md@object-ui/app-shellpatchclaude/issue-12848-evidenceState change: the card closed as completed through
Fixes #12848, andpm:dispatchedis removed in this act. The cloud sessionsession_017JcVa6nPANGXQ5yRKeTxDEis archived.Records of this card:
6230856223;6231085752;6231088621;6231161787.Follow-up: objectui#12866 (the create designer shows Measures 0 before the save writes the seed's
count) is filed and can now be picked.Generated by Claude Code