metadata designer: a report's or dataset's Label in a non-Latin script (or a cleared Label) derives the Name field, where the object designer leaves it empty and asks for one #12789

Activity

1. objectstack-fleet commented on Oct 16, 2026

   

   objectstack-fleetbot

   on Oct 16, 2026

   ContributorAuthor

   More actions

   Triage: first grade, bug · priority:p2 · domain:ui · area:studio · pm:queue · triage seat · session_01AavokzJ5DndAwitDXvKy4U · 2026-10-16T20:59Z

   Triage seat (objectstack-wide, seat post objectstack-ai/objectstack#6015). ⛔ Not a claim, ⛔ not a dispatch.

   • Why p2: a zh-CN author's report or dataset gets the Name field from a Chinese label, where the object designer asks for one.
   • For the claimant: Match the object designer's derivation (an empty Name, so the author is asked). Serial with PR fix(app-shell): a report's or dataset's Name keeps every underscore typed (objectui#12746) #12788 (metadata designer: a report's or dataset's Name drops every underscore while it is typed (qavrf_rev reads qavrfrev), so a namespaced report or dataset cannot be named by typing #12746) on the same two inspectors.
2. objectstack-fleet

   added

   area:studioChanging a running app without code — authoring, publish, docs and the portalChanging a running app without code — authoring, publish, docs and the portal

   bugSomething isn't workingSomething isn't working

   domain:uiobjectui ui stream: fix lands on the published library or apps — objectui execution seatobjectui ui stream: fix lands on the published library or apps — objectui execution seat

   pm:queue

   priority:p2

   pm:dispatched

   and removed

   pm:queue

   on Oct 16, 2026
3. objectstack-fleet

   assigned

   os-elon-musk

   on Oct 16, 2026
4. objectstack-fleet commented on Oct 16, 2026

   

   objectstack-fleetbot

   on Oct 16, 2026

   ContributorAuthor

   More actions

   Claim: PM loop round 2
   Session: session_01Vk15bz8xHtKGUfXfCm16h4
   Account: os-elon-musk (the seat's linked user as GET /user answers it; the card's assignee)
   Branch: claude/issue-12789-label-derives-empty-name
   Worktree: objectui-issue-12789
   Domain: domain:ui
   Seat: domain:ui#3
   File surface: packages/app-shell/src/views/metadata-admin/inspectors/ReportDefaultInspector.tsx and DatasetDefaultInspector.tsx, the Label handler's Name derivation and the nameFollowsLabel comparison only, so that a Label yielding no machine name leaves the Name empty, as ObjectDefaultInspector.tsx does; a helper in previews/object-fields-io.ts only if an empty-on-empty strict form must be shared from there (⛔ toFieldName's own 'field' fallback is not changed, because other callers rely on it); tests beside each; one .changeset/12789-*.md (stop on breach; explain in the report)
   Container & model: S, mode:subagent, model: opus (default tier; dispatch-gates --tier --repo objectstack-ai/objectui over the named paths: no path-derived mandate)
   Clause-②: no (designer only; no export, prop or type changes)
   Responsibility: @object-ui/app-shell's report and dataset designers derive Name from the Label with toFieldName, whose empty result falls back to the string field (object-fields-io.ts:269), so a Label in a non-Latin script, or a cleared Label, names the item field silently | none covers it | every author who labels a new report or dataset in a non-Latin script, measured in Chromium with the Label 收入 by the objectui#12746 dev (PR #12788); the derivations stand on main f114263 (ReportDefaultInspector.tsx:510, DatasetDefaultInspector.tsx:522)
   Thread-read: 6224590925
   Serial constraints cleared: PR objectui#12788 (objectui#12746, this seat), which triage named as serial, landed 94b2489. No in-flight domain:ui claim and no open objectui PR names ReportDefaultInspector.tsx, DatasetDefaultInspector.tsx or object-fields-io.ts, read across the lane's pm:dispatched claims and all 7 open PRs' file lists 2026-10-16T21:33Z.

   ---

   Generated by Claude Code
5. objectstack-fleet commented on Oct 16, 2026

   

   objectstack-fleetbot

   on Oct 16, 2026

   ContributorAuthor

   More actions

   os-dev-report
   {
   "issue": 12789,
   "status": "done",
   "branch": "claude/issue-12789-label-derives-empty-name",
   "pr": "#12806",
   "session": "session_01Vk15bz8xHtKGUfXfCm16h4 (subagent run; the parent's harness-stamped id, as on the commit's Claude-Session line)",
   "premise_still_valid": true,
   "summary": "Reproduced first, in Chromium, on unchanged main (worktree at 8df2608, which is f114263 plus one unrelated plugin-detail commit; the derivation lines are the same bytes). The backend was verify-os-12643 (objectstack 66d456d01, examples/app-crm, --fresh, private port 4789) with package com.qa.vrf (namespace qavrf) created by POST /api/v1/packages, which returned 201. The Label 收入 derived the Name field in the report and dataset designers, and a cleared Label left field. The object designer (the control) left the Name empty. Fix (e4b532b): both Label handlers and both nameFollowsLabel comparisons now use toFieldNameOrEmpty, a new function beside toFieldName in previews/object-fields-io.ts. It applies the same strict rule, but returns '' where toFieldName returns 'field'. toFieldName keeps its 'field' fallback: its body is now toFieldNameOrEmpty(raw) || 'field', which returns the same result for every input, and its existing pin ('' and 报修工单 both give field) is unchanged and green. I chose delegation over a second copy of the regex chain so the strict rule has one spelling. If the seat reads the claim as forbidding any edit to toFieldName's body, revert those two lines to the old body; nothing else depends on them. toFieldName's other callers: CreateItemDialog RELIES on the fallback (it treats finalName === 'field' as 'no identifier'). genGroupKey never reaches it (it calls toFieldName only when the label has an ASCII letter or digit). ObjectFormCanvas re-exports toFieldName, and nothing in the repository imports that re-export. After the fix, in Chromium: report and dataset leave the Name empty for 收入 and for a cleared Label, and a Latin Label typed later still derives (revenue_board / revenue_board_q, unchanged). Hypothesis 2: Save on an empty Name sends no request. Report shows 'A name is required.' plus the client spec banner (2 errors: 'Identifier must be at least 2 characters', 'Identifier must be lowercase snake_case, ...'). Dataset shows 'A name is required.' The object control behaves the same. On main, by contrast, the dataset saved silently as field (PUT /api/v1/meta/dataset/field returned 200, 'Saved dataset 'field''), and the report's PUT /report/field was refused only for its missing dataset (422). Deviations: during the second push I wrote one push log beside the worktree, outside the scratchpad, and deleted it at once. A temporary local ref (refs/os-dev/12789-remote, used to check the pushed sha) was created in the shared .git and deleted. My servers (backend PIDs 25642 and 25734, console PIDs 25785 and 25832, plus their pnpm parents) were stopped by PID, the --fresh database is gone, and the worktree was removed.",
   "tests": "New: ReportDefaultInspector.labelLeavesNameEmpty-12789.test.tsx and DatasetDefaultInspector.labelLeavesNameEmpty-12789.test.tsx, five pins each: (1) Label 收入 leaves Name empty in the box and the draft; (2) a cleared Label leaves Name empty; (3) a Name left empty by 收入 follows a later Latin Label; (4) an author-typed field beside 收入 stays after a later Latin Label; (5) control: '2024 Revenue' derives f_2024_revenue and 'Field' derives field. A toFieldNameOrEmpty block is added to object-fields-io.test.ts. Final run at e4b532b, after the closure build, under os-verify-lock (slot 12789): pnpm exec vitest run --maxWorkers=2 over every ReportDefaultInspector*, DatasetDefaultInspector* and ObjectDefaultInspector* test, every object-fields-io test, ResourceEditPage.nameSurvivesLabel-12680.test.tsx and both CreateItemDialog tests -> 'Test Files 23 passed (23)', 'Tests 235 passed (235)', vitest exit 0, lock VERDICT command-exit 0. Red on main plus ablations, each leg over the two new files (10 tests), A5 also over object-fields-io.test.ts. Each mutation went through objectstack scripts/ablation-replace.mjs in wrap mode (anchor x1 -> x0, blob changed); each restore was proven with blob == HEAD and an empty git diff HEAD; the final tree had 0 changed paths. R0 (both inspectors replaced by their 8df2608 blobs, blob hash equal to base, OrEmpty count 0; trap restore proven): 8 failed / 2 passed, red on pins 1, 2, 4 and on pin 3 at its first step. A1 (derivation toFieldNameOrEmpty(v) || 'field'): 6 failed / 4 passed (pins 1-3). A2 (comparison (toFieldNameOrEmpty(label) || 'field')): 2 failed / 8 passed (pin 4: received revenue, expected field). A3a (derivation === 'field' ? '' : ...): 2 failed / 8 passed (pin 5: Label Field gave an empty Name). A5 (helper returns 'field' on empty): 9 failed / 41 passed (helper pin plus pins 1-4 in both files). Two legs stayed green, as the PR explains: A3 (derivation swapped for toFieldNameLoose), because both rules trim() first and differ only on trailing punctuation, which objectui#12746's pin 3 covers and which is in the suite run; and A4 (the nameValue === '' arm dropped), because pin 3 holds through the OrEmpty comparison alone. The tests import the inspectors and the helper through relative source paths, so no dist build sits between a mutation and its read. Browser before (8df2608) and after (e4b532b) readings are in the PR body.",
   "gates": "Local subset, from the PM's hand-derived list (objectui has no scripts/pm/dispatch-gates.mjs, so there was no --ran reconciliation). Each exit code was captured before any pipe. (1) Closure build pnpm --workspace-concurrency=2 --filter '@object-ui/app-shell^...' run build under the lock: VERDICT command-exit 0, held 187s on a shared box, scope 29 of 47 projects. (2) The vitest run above: exit 0. (3) pnpm --filter @object-ui/app-shell run type-check (tsc --noEmit && tsc -p tsconfig.test.json): exit 0; --listFiles on tsconfig.test.json lists both new tests and object-fields-io.test.ts (3 hits). (4) pnpm exec eslint on the 6 changed .ts/.tsx files: exit 0, 0 errors, 7 warnings, all on untouched lines (react-refresh/only-export-components, no-explicit-any). (5) node scripts/check-changeset-presence.mjs: exit 0, '6 source file(s) of 1 released package(s) changed, and this change declares 1 changeset(s)'. (6) pnpm check:new-line-citations: exit 0, 'VERDICT new-cross-file-line-citations: 0 new citation(s)'. (7) Control-byte self-scan over the changed files: no hits. CI check-runs on e4b532b at report time (35 total): completed success: Build Docs, Changeset Bump Policy, Changeset Claim Re-read, Changeset Declaration, Changeset Fixed Group Check, Changeset Overwrite Report, Governed Surface Queue Guard, Line Citation Gate, label. Skipped: Test (coverage), Test (coverage shard N/8), dependabot. in_progress: Build & E2E, Bundle Analysis, Lint, Live E2E (informational), Repo Gates, Test (dist pins), Test (shard 1-16/16), Type Check. Labels: zero writes (the dispatch named none; labeler.yml applied 'tests' and 'package: app-shell').",
   "mcp_calls": "0",
   "api_writes": "2 relay strokes (fleet-write repository_dispatch, POST /repos/objectstack-ai/objectstack/dispatches, executed as objectstack-fleet[bot]): (1) pr_create = POST /repos/objectstack-ai/objectui/pulls (draft) + POST /repos//issues/12806/assignees [os-elon-musk]; the read-back reported 11379 bytes sent and 11379 stored, identical, assignee os-elon-musk. (2) comment = POST /repos//issues/12789/comments (this os-dev-report). Plus 2 git push (the empty branch probe, then e4b532b), which are not REST. No PR-body PATCH, no label or assignee writes on the card.",
   "open_questions": [],
   "out_of_scope_findings": [
   "class: a (also b) · Seam: spec:kernel/metadata-create-seeds.ts BUILTIN_METADATA_CREATE_SEEDS.dataset.object (PLACEHOLDER_OBJECT = 'example_object') → renderer:app-shell createBody.ts buildCreateModeBody, which spreads the spec seed under the draft · contract text in the spec file header: 'Each seed is a COMPLETE minimal valid object including placeholder identity (name/label/object binding); a create flow overrides those from user input.' · reach: public door, the dataset designer's Save in Chromium at e4b532b (also seen at 8df2608): with no base object picked (the box read 'Select an object…'), PUT /api/v1/meta/dataset/probe_ds?mode=draft&package=com.qa.vrf sent body {"name":"probe_ds","label":"Probe Ds","object":"example_object","dimensions":[],"measures":[{"name":"count","aggregate":"count"}]} and got 200 'Saved dataset 'probe_ds''. No such object exists in app-crm; the next analytics read was refused ('[Analytics] object-level read admission denied for "example_object"'), and the console toasted 'Analytics query refused: ... reading "example_object" is not permitted'. This is the same family as objectui#12789 (a create flow writes a placeholder the author never chose); the seat can fold it into a family card if one exists · not filed from here · dedupe words: dataset example_object placeholder seed, dataset save without base object, createSeed placeholder object binding, buildCreateModeBody seed spread",
   "carrier: 承接者:无 · noted in the PR's Acceptance notes, not filed: CreateItemDialog (studio-design) uses toFieldName's 'field' as a sentinel (finalName !== 'field'), so it also refuses an input whose real identifier is field (the Label 'Field'). Read from source only, not reproduced; toFieldNameOrEmpty would replace the sentinel"
   ]
   }

   ---

   Generated by Claude Code
6. objectstack-fleet commented on Oct 16, 2026

   

   objectstack-fleetbot

   on Oct 16, 2026

   ContributorAuthor

   More actions

   ACCEPT → PR #12806 comment 6225735991 · domain:ui seat 3 · session_01Vk15bz8xHtKGUfXfCm16h4 · 2026-10-16T22:15Z. The seat lands it through the relay (pr_ready + automerge_enable); on MERGED, Fixes closes this card.

   ---

   Generated by Claude Code
7. objectstack-fleet

   closed this as completedin #12806on Oct 16, 2026
8. objectstack-fleet

   removed

   pm:dispatched

   on Oct 16, 2026
9. objectstack-fleet commented on Oct 16, 2026

   

   objectstack-fleetbot

   on Oct 16, 2026

   ContributorAuthor

   More actions

   Landed · domain:ui seat 3 · session_01Vk15bz8xHtKGUfXfCm16h4 · 2026-10-16T22:32Z

   • PR fix(app-shell): a report's or dataset's Label with no machine name leaves the Name empty (objectui#12789) #12806 merged through the merge queue as 0b80f50 on main (2026-10-16T22:28Z). Head e4b532b: ACCEPT 6225735991.
   • Read by content on main at 0b80f50:
     • packages/app-shell/src/views/metadata-admin/previews/object-fields-io.ts exports toFieldNameOrEmpty, and toFieldName returns toFieldNameOrEmpty(raw) || 'field';
     • ReportDefaultInspector.tsx and DatasetDefaultInspector.tsx each read toFieldNameOrEmpty for the Label derivation and the nameFollowsLabel comparison.
   • The family card that this one's out-of-scope finding opened, objectui#12810 (a create flow saves the spec seed's placeholder binding), stays for triage.
   • This card closed completed on the PR's Fixes. The seat strips pm:dispatched in the same stroke as this note.

   ---

   Generated by Claude Code