Repository navigation
pm-dispatch(review): the seat requests the approvers in the same round as its ACCEPT, large-diff PRs included, and never reports "awaiting approval" before the request is sent - #30045
Merged
Conversation
…as the seat's ACCEPT, a large-diff PR is requested too, and a seat never reports "awaiting your approval" before the request is on the PR The hand-off rule (path fork step 3) already makes the review request the seat's own stroke after ACCEPT + a same-head contract PASS. Measured on the open PRs: a PR whose ACCEPT and PASS were both on its current head carried no requested reviewer, and the >3000-line split PRs, which take the same end-of-review steps, carried none either, while the chat told the maintainer they were waiting for approval. - Step 3: the request is sent in the same round the record completes. - The >3000-line rule names step 3 explicitly, so "Tier S hands off to nobody" no longer reads as covering a large ungoverned diff. - Step 4: the round report reads the requested reviewers live, and a seat does not report a PR as awaiting approval before the request is sent. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGufzgFA14BKgQ96yvMZbA
os-zhuang
marked this pull request as ready for review
November 4, 2026 10:34
os-zhuang
enabled auto-merge
November 4, 2026 10:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Yibo Wang · project thread
No card: maintainer-directed in the project thread (「修改 pm-dispatch/os-dev 技能」, after 「为什么等我批的现在没有推送給 os-zhuang,是技能的问题吗」).
维护者速读
SKILL.md〈路径分叉〉三行就地改写(行数不变):③ 请审在席位 ACCEPT + 现 head PASS 落案的同一轮发出;>3000 行 PR 明写也走 ③ 请审;④ 轮报现读请审人,没请审就不许在聊天里说「等你批」。.claude/skills/pm-dispatch/SKILL.mdL187、L197、L201。pnpm check:pm-skill-ratchet && pnpm check:pm-skill-id-lint && pnpm check:skill-frame-sync,三条皆绿(行数 319/319,每行 ≤120 字节)。.claude/**属 Tier S,但这是 PM 自身规则 PR,按〈路径分叉〉末行留给维护者)。What changes
.claude/skills/pm-dispatch/SKILL.md, three lines rewritten in place (319 lines before and after, each ≤120 bytes):pr_request_reviewers) goes out in the same round that the seat's ACCEPT and a same-head contract PASS are both on record, not "after" at some later point.os-dev.mdis unchanged: a dev'spr_createstill carries no assignees and requests nobody. That is the rule the maintainer asked for on 2026-10-29 (「这个是技能的bug,应该是开发完了你审核通过才会推送给我审核」, 「审核人是 os-zhuang 和 hotlong」), landed in #27385, and this PR keeps it. Only the seat-side hand-off is tightened.Why
Measured on 2026-11-04 ~10:10Z, the six PRs reported in chat as waiting for the maintainer:
#30028 was a due hand-off with no request. The two splits are over 3000 lines and owe the same end-of-review steps, but L198's "Tier S hands off to nobody" plus a patrol (H43) that reads only register paths left them with no request and no warning. As a one-off,
os-zhuangwas requested on #30028, #29993, #29998 and #30030 from the project thread; #29968 and #30004 already carry anos-zhuangapproval, so they wait on the seat's landing, not on a review.Out of scope, follow-up if wanted: H43 in
scripts/pm/check-half-states.mjsreads governed-register PRs only, so it cannot flag a >3000-line PR whose request is missing.Verification
The 20 commands
node scripts/pm/dispatch-gates.mjs --commandsderives for this diff, run on head262327bc, all exit 0 (pnpm --filter @objectstack/lint run check:doc-formula-expressionsafterturbo run build --filter=@objectstack/formula --filter=@objectstack/lint). Key lines:check-skill-line-ratchet: green, SKILL.md at its 319 ceiling.check-skill-id-lint: 110 files clean.check-skill-frame-syncandcheck-governed-prose: green.Clause-②: no
Metadata-protocol: none
Human Minimum
packages/specholds no runtime logic. (not touched)pnpm lintpasses. (no formatter ran;pnpm lintnot run for a three-line skill text edit)main, one pull request.skip-changeset)packages/spectouched: its generated artifacts are regenerated and committed. (not touched)content/docs/references/,packages/*/CHANGELOG.mdorcontent/docs/releases/.Generated by Claude Code