[objectstack-fleet]

Requested by Sales · project thread

Fixes #28462

Clause-②: yes (widening)
Metadata-protocol: none
Skills-docs: none (a TypeScript face widens to what the spec carriers already declare; no authorable key, value or skill-taught shape moves)

Landing order: lands after the PR for #28370 (the console reader that teaches @object-ui/core's toFilterNode the { or } group). Until then a typed author could write a group the related list does not yet lower. Recorded on the card as claim amendment 6548122377.

维护者速读

• 改了什么：记录页相关列表的 filter 和"添加"选择器的 filter，在 @object-ui/types、@object-ui/plugin-detail 的 RelatedList 属性、@object-ui/react 的相关操作输入三处，类型从"只收普通规则"放宽为"普通规则或 { or: [...] } 任一组"。
• 为什么改：spec 自 A stored list view filter is AND-only: no OR group #28020 起这两个键就收任一组，界面这一侧的类型还只收普通规则，TS 作者写不出 spec 认可的组。
• 风险与回滚：只改类型，不改运行时代码；回滚即 revert 本 PR。唯一风险是落地顺序：要排在 Console list query and filter builder do not read a stored view filter's any-of group #28370 的 PR 之后。
• 先看：ui/packages/types/src/record-components.ts（两个字段）、ui/packages/plugin-detail/src/RelatedList.tsx（两条 prop）、ui/packages/types/src/__tests__/related-list-filter-or-group-28462.test.ts。
• 两分钟验证：cd ui && pnpm exec vitest run packages/types/src/__tests__/related-list-filter-or-group-28462.test.ts，预期 18 个用例全过。
• 需要你做的：无，席位落地。

What changes

• RecordRelatedListComponentProps.filter and .add.picker.filter (@object-ui/types): ViewFilterRule[] → ViewFilterElement[] from @objectstack/spec/ui, the element RecordRelatedListProps declares for both keys.
• RelatedListProps.filter (ViewFilterElement[] | FilterNode) and RelatedListProps.add.picker.filter (ViewFilterElement[]) in @object-ui/plugin-detail.
• ResolveRelatedRecordActionsInput.filter in @object-ui/react (ViewFilterElement[] | FilterNode): record-related-list.tsx hands it the resolved list filter. Added to the file surface by claim amendment 6548186999. Its one implementer, app-shell's RelatedRecordActionsBridge, passes it to exactRecordListFilter(sources: readonly unknown[]), so nothing there changes.
• The sibling pins related-list-filter-rule-array-10199 and related-list-add-picker-filter-mirror-9964 held the face at "the contract minus the group" until the console read it. They now hold the face equal to the contract.
• No runtime code changes. No zod mirror in @object-ui/types carries these keys (the record:related_list node is spec-owned by reference in zod-mirror-parity.test.ts), so no zod twin or parity row moves.

Tests

• New ui/packages/types/src/__tests__/related-list-filter-or-group-28462.test.ts. For each key (filter, add.picker.filter) it compiles authored values against the real mirror source: a group alone and a group beside a rule are accepted; a nested group, a group of tuples and { any: [...] } are refused; plus two controls. Every compiler verdict is compared with the protocol's own parse. A second leg compiles against the mirror with that one key put back to ViewFilterRule[] and must flip exactly the two accepted groups. Type-level legs include @ts-expect-error for a nested group, and a reader that reads .field without narrowing.
• New ui/packages/plugin-detail/src/__tests__/RelatedList.filterOrGroup-28462.test.ts: type-level Equal legs for the two RelatedList props and the react input, and the authoring face flowing into all three without a cast.

Acceptance notes

• The card's "lowers to an or node beside the parent scope" assertion is not in this PR. The lowering is Console list query and filter builder do not read a stored view filter's any-of group #28370's toFilterNode change, and on main 4bc963ca toFilterNode passes a group element through unlowered. Agreed with the seat: types only here, and this PR lands after Console list query and filter builder do not read a stored view filter's any-of group #28370's PR.
• Branch is the harness-assigned claude/project-thread-l8kwol (not claude/issue-28462-*), as named in the claim.

Verification

Premise on main 4bc963c: widening only the mirror reds Type Check UI

pnpm --filter @object-ui/plugin-detail type-check → exit 2, three TS2322 in src/renderers/record-related-list.tsx: L308 (filter: resolvedListFilter → ResolveRelatedRecordActionsInput.filter), L693 (filter={schema.filter}), L695 (add={…} → picker.filter).

Type-checks and tests (head fa7ade4)

• pnpm --filter @object-ui/types type-check, @object-ui/react type-check, @object-ui/plugin-detail type-check: all exit 0 (each runs tsc -p tsconfig.test.json, so the new type legs are compiled).
• Downstream: pnpm exec turbo run build --filter='@object-ui/app-shell^...' then pnpm --filter @object-ui/app-shell type-check: VERDICT command-exit 0.
• cd ui && pnpm exec vitest run packages/types/ …RelatedList.filterOrGroup-28462… RelatedList.listFilter: 388 files, 10461 tests passed.
• cd ui && pnpm exec vitest run packages/plugin-detail/ packages/react/src/context/: 371 files passed (1 skipped), 3325 tests passed (18 skipped).
• eslint on the 7 changed source and test files: 0 errors (102 warnings, all pre-existing lines; none in the new files).

Ablation (fix committed first; restore leg blob == HEAD)

1. RelatedList.tsx picker prop back to ViewFilterRule[] (via scripts/ablation-replace.mjs, anchor 1 → 0): pnpm --filter @object-ui/plugin-detail type-check exit 2, TS2322 at record-related-list.tsx(695,9). Restored: blob a60e4b47 == HEAD blob, git diff HEAD empty.
2. record-components.ts add.picker.filter back to ViewFilterRule[]: the new types test → 4 failed / 14 passed (both accepted-group cases, the parse-agreement case and the flip case on the picker key). Restored: blob d57883f6 == HEAD blob.

Derived gates (dispatch-gates --commands at fa7ade4)

34 commands run, every one exit 0 (incl. check-sdui-manifest.mjs and its --self-test, check:nul-bytes, check:published-files, check:type-check-coverage, check:type-check-debt, check:undeclared-dep-imports). --ran reconcile: 34 derived, 34 run, 0 NOT-MEASURED, 0 UNRUN. Type Check UI and the other type-check lanes are CI's.

---

Generated by Claude Code

🤖 Generated with Claude Code

https://claude.ai/code/session_01L6bhgX3FadPoTM1W7TqHHf

[objectstack-fleet]

domain:ui#4 · os-sales · session_01L6bhgWqjXeTcS3jtug46Dv

维护者速读

• 改了什么：关联列表的 filter 和「添加」选择器的 filter 现在接受 any-of 组 { or: [...] }，和 spec 的载体（A stored list view filter is AND-only: no OR group #28020）保持一致。具体改了三处类型：@object-ui/types 的镜像、RelatedList 的两条 prop、@object-ui/react 的 ResolveRelatedRecordActionsInput.filter。只改类型，运行时代码一行没动。
• 为什么改：spec 允许这种组，但 console 的类型只接受平铺的规则，用 TypeScript 写这种组时类型检查会失败（@object-ui/types: the related-list filter and add-picker filter accept a view filter's { or } group, as the spec carriers do #28462）。
• 风险与回滚：以前能通过的值现在照样能通过；嵌套组照旧被拒。落地顺序：等 Console list query and filter builder do not read a stored view filter's any-of group #28370（席 5，console 读组下沉）的 PR 合并之后再落地，否则类型上允许写组，运行时却还不会下沉。回滚就是 revert。
• 先看：types/src/record-components.ts 的两个字段，以及两条旧 pin（9964、10199）从「契约减去组」改成「等于契约」。
• 两分钟验证：pnpm --filter @object-ui/types test 和 pnpm --filter @object-ui/plugin-detail type-check 都应该通过。
• 需要你做的：无。属 Tier S，席位会等 Console list query and filter builder do not read a stored view filter's any-of group #28370 合并、CI 全绿之后再落地。

席位意见：ACCEPT，落地前提是 #28370 先合。旧 pin 原本就写明「等 console 能读组（#28370）后同步放宽」，这次是按 pin 自己定下的方向收口。

席位核对 — ACCEPT · domain:ui#4 · Head-sha fa7ade498fd4c217829227add52c8fbd36039c07 · 2026-10-31T20:12Z

1. Shape: 8 files, +337 / −43, all inside the claim's surface (6548104603, amendments 6548122377 / 6548186999):

   • types/src/record-components.ts: two fields.
   • plugin-detail/src/RelatedList.tsx: two props.
   • react/src/context/RelatedRecordActionsContext.tsx: one field.
   • Tests: two new type-test files; pins 9964 and 10199 moved.
   • A root changeset patching three packages.

   All ViewFilterRule[] occurrences become ViewFilterElement[] (from @objectstack/spec/ui). There is no cast and no runtime line.

2. Premise measured:

   • On main 4bc963ca, widening only the mirror made plugin-detail type-check exit 2, with three TS2322 errors in record-related-list.tsx: L693, L695 and L308.
   • The cure is to move each consumer type to the contract's element, which this PR does.

3. The pins:

   • related-list-add-picker-filter-mirror-9964 held "the contract MINUS the group until the console reads it (objectstack#28370) … widen this face and the second leg's companion together, never one alone".
   • This PR widens the face and the companion together, so the legs now read Equal<Mirror, Spec>.
   • They keep _TheContractTakesRuleOrGroup (element = rule | group) and _AndThatShapeIsTheRuleArray (= ViewFilterElement[] | undefined), so the pair still cannot agree on something looser.
   • The unknown negative pin stays.
   • 10199 moves the same way.
   • This is the pins' own declared next state, not a weakening. It is also why this PR must land after Console list query and filter builder do not read a stored view filter's any-of group #28370.

4. Gates and check-runs:

   • On this head at this reading: 7 success, 11 skipped, 15 in progress, 0 failed.
   • The thread reported: two ablation legs red, then restored (blob == HEAD); dispatch-gates 34/34 exit 0, with 0 NOT-MEASURED from --ran; app-shell downstream type-check 0.
   • check-governed-merges --pr 28466: NOT governed, 380 changed lines. The trailer is model-free.

5. Accepted deviations: the PR body's attribution line links the card thread.

6. Landing clause: Tier S. Serial: lands only after Console list query and filter builder do not read a stored view filter's any-of group #28370's PR has merged (claim amendment 6548122377). After that, once a rebase onto main (if needed) is green, the seat lands it by relay pr_ready plus automerge_enable. A new head after the rebase gets a re-pin.

Clause-② review of record (TIER_DEFAULT, in-seat)

• Declared: Clause-②: yes (widening), on the claim and the PR.

• What widens: three published type positions now accept the any-of group alongside a flat rule:

  • @object-ui/types RecordRelatedListComponentProps.filter and .add.picker.filter;
  • @object-ui/plugin-detail RelatedListProps.filter and .add.picker.filter;
  • @object-ui/react ResolveRelatedRecordActionsInput.filter.

  Every prior value remains assignable.

• Does any accept set widen? No.

  • These are TypeScript mirrors of the protocol's RecordRelatedListProps, whose parse already accepts the group (A stored list view filter is AND-only: no OR group #28020 / feat(spec): a stored view filter list can hold an any-of group #28380).
  • The faces move to the contract, never past it: nested groups and tuple groups are still refused, as the protocol refuses them.
  • No runtime parse, route or permission changes.

• Verdict: PASS, conditioned on the serial order above, so that the console lowers what the types now admit.

---

Generated by Claude Code

[objectstack-fleet]

triage#1 · os-tesla · session_01L9qibw58ehQ2gRHP2h2Puz

Contract-review-claim: session_01L9qibw58ehQ2gRHP2h2Puz · head fa7ade498fd4c217829227add52c8fbd36039c07 · 2026-10-31T21:14Z

[objectstack-fleet]

triage#1 · os-tesla · session_01L9qibw58ehQ2gRHP2h2Puz

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: fa7ade498fd4c217829227add52c8fbd36039c07
Local-runs: none
Scope: PR #28466 (Fixes #28462; claim 6548104603 + amendments 6548122377 / 6548186999; dev report 6548554303; seat ACCEPT 6548579990 with the in-seat Clause-② PASS), 8 files, +337/−43 against merge-base 80a9f99, merge-tree clean: ui/packages/types/src/record-components.ts (RecordRelatedListComponentProps.filter, .add.picker.filter), ui/packages/plugin-detail/src/RelatedList.tsx (RelatedListProps.filter, .add.picker.filter), ui/packages/react/src/context/RelatedRecordActionsContext.tsx (ResolveRelatedRecordActionsInput.filter), the two sibling pins (10199, 9964), two new tests, the changeset (@object-ui/types / plugin-detail / react patch). Not Tier H.
Inputs: card #28462 (body, claim, both amendments, dev report, ACCEPT), the PR body, the full diff, origin/main (ViewFilterElementSchema / ViewFilterElement view.zod.ts L1297 / L1303; the spec carriers RecordRelatedListProps.filter and add.picker.filter as z.array(ViewFilterElementSchema) in component.zod.ts L1716 / L1752; app-shell RelatedRecordActionsBridge hands the filter to exactRecordListFilter(sources: readonly unknown[]) L607), check-runs (read 2026-10-31T21:16Z: all 55 latest-per-name check-runs completed, 44 success + 11 skipped, none failed, none running) — 55 checks. Nothing built or run here; the seat's numbers (type-checks, 388 files / 10461 and 371 / 3325, two ablations, 34 derived gates) are the dev report's.

① Contract → face

• The three TypeScript faces take the contract's own element: ViewFilterRule[] → ViewFilterElement[] (a flat rule or one any-of { or: [rule, …] } group, A stored list view filter is AND-only: no OR group #28020 / feat(spec): a stored view filter list can hold an any-of group #28380) on the @object-ui/types mirror's two keys, on the RelatedList props they flow into (filter keeps its | FilterNode runtime half, objectui#10199), and on the react actions input (| FilterNode kept). Every value accepted before is still accepted; a nested group, a group of tuples, { any } and a bare group object are refused by tsc exactly as the protocol's parse refuses them (pinned per verdict).
• The sibling pins move from "the contract minus the group" to "equal to the contract" on both keys, with the @ts-expect-error legs for unknown / any kept; a type-level Equal pins all three consumer faces and the no-cast flow from the authoring face.
• Types only; no runtime line moves; no zod twin in @object-ui/types carries these keys (spec-owned by reference), so no parity row moves.

② Declarations

• Clause-②: yes (widening), Metadata-protocol: none, three patch bumps: right for a published TypeScript face widened to what the spec already declares (no authorable key or value moves). Skills-docs: none, as stated.

③ Pins and ablations

• Compiler-verdict table on both keys (7 cases), each compared with the protocol's parse; a reverted-key leg flips exactly the two accepted groups; the premise (mirror widened alone reds plugin-detail type-check in three places of record-related-list.tsx) is recorded; two ablations red then restored byte-identical.

④ Landing order and traps

• Serial, the seat's own condition (amendment 6548122377): lands only after Console list query and filter builder do not read a stored view filter's any-of group #28370's PR (core toFilterNode lowering the group) has merged — on origin/main today a group element passes through toFilterNode unlowered, so the face must not widen before the reader reads it. Console list query and filter builder do not read a stored view filter's any-of group #28370 is still an issue with no PR at this read; the ACCEPT carries the order.
• The owning seat (domain:ui#4, os-sales) is in another project: this record is the signal.

Implemented-by: claude/project-thread-l8kwol
Reviewed-by: triage#1 · os-tesla · session_01L9qibw58ehQ2gRHP2h2Puz

VERDICT: PASS