Skip to content

docs(adr-0143): D5 records manage_connector_connections' default holders (ruling B) - #28456

Merged
os-zhuang merged 5 commits into
mainfrom
claude/project-thread-jtzyzv
Oct 31, 2026
Merged

os-zhuang merged 5 commits into
mainfrom
claude/project-thread-jtzyzv

Conversation

@objectstack-fleet

Copy link
Copy Markdown
Contributor

Requested by Tesla · project thread

Fixes #28427

Clause-②: no
Metadata-protocol: none

Tier H. The diff touches docs/adr/** only, a governed surface (CODEOWNERS @os-zhuang @hotlong). It lands only on an authorized approval; no seat merges, queues or arms it before that.

维护者速读

What changes

ADR-0143 D5 already said who may connect is "a capability check the server slice declares". It now records that capability and its default holders, per ruling B (record 6545223261 on #28327): manage_connector_connections, organization-scoped, held by default by platform administrators and both organization-administrator sets (organization_admin, and organization_admin_no_bypass through its derivation). Every other position holds it only by explicit grant. The behaviour shipped in #28441 (squash 8e87403); this line is its record.

Acceptance notes

Verification

Local, on the PR head: node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstack derived 21 families for the 1-path change set. Each was run with stdin from /dev/null, and its exit was captured by redirect before any pipe. All 21 exit 0, including check:adr-links, check:adr-index, check:adr-anchors, check:adr-symbol-anchors, check:doc-authoring and check:pm-governed-merges. --ran: 21 derived famil(ies) accounted for — 21 run, 0 NOT-MEASURED.


Generated by Claude Code

…ections by default (WIP)

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L9qibxkKcPULsq3fo4JFAX
…ault holders of manage_connector_connections

The shipped-set pin names admin_full_access and both organization-admin
sets as the only holders and member_default / viewer_readonly as
withheld; the no-bypass variant's list equals its parent's. The grant
goldens gain the capability on every organization-admin envelope inside
the organization (and the agent acting on its behalf), never outside it.
The connection door admits the shipped organization-admin grant for its
own organization and refuses the same person active in another one.
Docs: connectors.mdx names organization admins as default holders.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L9qibxkKcPULsq3fo4JFAX
…mmit-trail pin carries manage_connector_connections

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L9qibxkKcPULsq3fo4JFAX
…s (ruling B)

Platform administrators and both organization-administrator sets hold
manage_connector_connections by default; every other position only by
explicit grant.

Co-Authored-By: Claude <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L9qibxkKcPULsq3fo4JFAX
@objectstack-fleet objectstack-fleet Bot added the skip-changeset PR has no user-facing published change; bypasses the changeset gate label Oct 31, 2026
@github-actions github-actions Bot added size/xs documentation Improvements or additions to documentation labels Oct 31, 2026
@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

triage#1 · os-tesla · session_01L9qibw58ehQ2gRHP2h2Puz

Contract-review-claim: session_01L9qibw58ehQ2gRHP2h2Puz · head 94355f4ffc090cdcc439643aef7c7b21a4197fb8 · 2026-10-31T17:48Z

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

triage#1 · os-tesla · session_01L9qibw58ehQ2gRHP2h2Puz

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 94355f4ffc090cdcc439643aef7c7b21a4197fb8
Local-runs: none
Scope: docs/adr/0143-outbound-connector-auth-is-open-tier.md, one four-line bullet under D5 naming manage_connector_connections and its default holders. 1 file, +4/−0. Fixes #28427 item 4 (ruling B 6545223261 on #28327; claim 6545275282; code half PR #28441 merged 8e874038, landing record 6546606809). Tier H by path (docs/adr/**), skip-changeset.
Inputs: card #28427 body, claim, dev report 6545987804 and landing record, the PR body, the whole PR diff, the ruling record 6545223261 and this lane's own PASS on #28441 (6546313449: organization_admin gains the capability in default-permission-sets.ts, organization_admin_no_bypass through deriveWallLessOrgAdmin, admin_full_access already held it; member_default / viewer_readonly withheld), check-runs (read 2026-10-31T17:52Z: all 41 latest-per-name check-runs completed, 23 success + 18 skipped, none failed, none running) — 41 checks. Nothing built or run here; the seat's 21 derived gates are the PR body's.

① Derived judgments

  • The line records what shipped. The bullet names the capability (manage_connector_connections, organization-scoped), the three default holders (platform administrators, organization_admin, and organization_admin_no_bypass through its derivation) and the rule that every other position holds it only by explicit grant. That is exactly the set feat(plugin-security): organization administrators hold manage_connector_connections by default (ADR-0143 D5, ruling B) #28441's pins assert and the set the ruling B record names; nothing wider, nothing narrower.
  • Placement. It sits under D5 directly after the sentence it completes ("Who may connect, reconnect or revoke is a capability check the server slice declares"), before D6; the existing anchor link in the previous bullet is untouched. The ADR's status block is not amended: this is a decision record filled in, not a reversal of any D5 clause.
  • Declarations. Clause-②: no, Metadata-protocol: none, skip-changeset: a docs-only diff, nothing published, nothing served. Correct.
  • Card closure. Fixes #28427 is right here: items 1–3 landed with feat(plugin-security): organization administrators hold manage_connector_connections by default (ADR-0143 D5, ruling B) #28441 (Part of), item 4 is this line, so the merge closes the card.

② Rulings cited

③ Narrowing / widening

  • None; prose only.

④ Behaviour / flags

Implemented-by: claude/project-thread-jtzyzv
Reviewed-by: session_01L9qibw58ehQ2gRHP2h2Puz
VERDICT: PASS

@objectstack-fleet

Copy link
Copy Markdown
Contributor Author

domain:server#1 · os-tesla · session_01L9qibz3ZUbZ8Qcn1rDw9yc

维护者速读

席位意见:契约复审 PASS,记录的内容与已上线的代码一致。可以批准。

席位核对

ACCEPT · seat domain:server#1 · head 94355f4f · 2026-10-31T17:53Z

  1. Shape: Fixes #28427 (item 4; items 1–3 landed with feat(plugin-security): organization administrators hold manage_connector_connections by default (ADR-0143 D5, ruling B) #28441). Draft, base main, 1 file, +4/−0, skip-changeset. No packages/spec path.
  2. Ruling: B 6545223261. The bullet names manage_connector_connections, its three default holders and the explicit-grant rule for everyone else. That is the set feat(plugin-security): organization administrators hold manage_connector_connections by default (ADR-0143 D5, ruling B) #28441's pins assert.
  3. Contract review: lane PASS 6547038977 at this head.
  4. Gates / check-runs: the PR body reports 21/21 derived gates exit 0 and --ran with 0 NOT-MEASURED. On head 94355f4f, all 41 check-runs completed: 23 success, 18 skipped, 0 failed.
  5. Accepted deviation: the head is the old jtzyzv tip, plus a merge of main, plus the ADR commit. A restart from main was not possible because the remote branch had been auto-deleted and the lease push was refused. The diff against main is the ADR file alone, and the PR squashes to one commit.
  6. Landing: GOVERNED, Tier H (docs/adr/**). The seat readies the PR, and the relay requests os-zhuang and hotlong. No auto-merge is armed by the seat. After an authorized approval, the seat lands it, or the maintainer enqueues it.

@objectstack-fleet
objectstack-fleet Bot marked this pull request as ready for review October 31, 2026 17:54
@os-zhuang
os-zhuang added this pull request to the merge queue Oct 31, 2026
Merged via the queue into main with commit 52306d4 Oct 31, 2026
55 checks passed
@os-zhuang
os-zhuang deleted the claude/project-thread-jtzyzv branch October 31, 2026 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/xs skip-changeset PR has no user-facing published change; bypasses the changeset gate

Projects

None yet

2 participants