Skip to content

test(rest): fail the late-cancel control loudly when its wait for the results write runs out #28067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 1 commit into from
Oct 30, 2026
Merged

test(rest): fail the late-cancel control loudly when its wait for the results write runs out #28067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/rest/src/import-job-integration.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -618,11 +618,16 @@ describe('async import job — a job whose every row failed ends failed', () =>
await waitForTerminal(slowCtx.progress, jobId);
// The cancel route writes `cancelled` first; wait until the worker's own
// final patch has landed (it is the only write of `results`), then read the row.
let reported = 0;
for (let i = 0; i < 400; i++) {
const r = await callJob(slowCtx.results, jobId);
if ((r._json?.results ?? []).length === 3) break;
reported = (r._json?.results ?? []).length;
if (reported === 3) break;
await new Promise((rr) => setTimeout(rr, 5));
}
// An exhausted wait must fail here: without the worker's final patch, the
// cancel route's write and the progress flush alone could pass the checks below.
expect(reported).toBe(3);
const after = await callJob(slowCtx.progress, jobId);
expect(after._json.status).toBe('cancelled');
expect(after._json).toMatchObject({ processed: 3, created: 0, updated: 0, skipped: 0, errors: 3 });
Expand Down
Loading