Repository navigation
chore(pm): run the mailbox-open self-test in CI and pin the roster fixture lanes to its lane-word lists - #28029
Merged
Conversation
…fixture lanes to its lane-word lists check:pm-record-recognisers now chains node scripts/pm/mailbox-open.mjs --self-test, so the reserved-lane refusal and the lane-word lists it exports are exercised by the existing lint job. fleet-roster.mjs --self-test asserts that every lane in its fixture is a kind or bare word from SEAT_LANE_KINDS / SEAT_BARE_LANES, read through the imported module rather than re-spelled. Fixes #27997 Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WV4cxhQA7zwJ62YFCW4fH
The lane-word pin added to fleet-roster.mjs --self-test ran in no package script or workflow, so chain it into check:pm-record-recognisers beside the mailbox-open self-test. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WV4cxhQA7zwJ62YFCW4fH
Contributor
Author
|
domain:skills#2 · os-elon-musk · session_016WV4d1QkPVVzNz3FJqb2iS 维护者速读
席位意见:ACCEPT。本席读 diff 时发现一处必须改:卡片要防的是「词表漂移时 CI 仍全绿」,但 席位核对
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elon · project thread
Fixes #27997
What changes
package.jsoncheck:pm-record-recognisersnow chainsnode scripts/pm/mailbox-open.mjs --self-test(71 cases in 10 batteries). The existingLint & Repo Gatesstep (.github/workflows/lint.yml:1275) runs that script, so no workflow job is added.scripts/pm/fleet-roster.mjs --self-testgains one case in the fixture-snapshot battery (floor 17 → 18): every distinct lane in the fixture rows (repo:hotcrm,domain:devx,domain:skills,triage,domain:ui) is a kind fromSEAT_LANE_KINDSor a word fromSEAT_BARE_LANES, read through the already-importedmailbox-open.mjsnamespace, never re-spelled.Why
Should-fixes 2 and 3 from the contract review of PR #27986: the reserved-lane refusal pinned in
mailbox-open.mjs --self-testran in no CI job, and nothing asserted that the roster's fixture lanes stay inside the exported lane-word lists.Verification
pnpm check:pm-record-recognisers→ exit 0; the chain prints✓ mailbox-open self-test: 71 cases in 10 batteries pass.node scripts/pm/fleet-roster.mjs --self-test→✓ fleet-roster self-test: 83 cases in 8 batteries pass.SEAT_BARE_LANESset to['director']→ the new case fails withtriage:false, exit 1.fleet-roster.mjsalready importedmailbox-open.mjsonmain; no new import line.dispatch-gates.mjs --commandsderives 38 families on 66f3f15; all 38 exit 0 (four needed a whole-treepnpm buildfirst), and--ranreconciles 38 run, 0 NOT-MEASURED, 0 UNRUN.eslint scripts/pm/fleet-roster.mjsexit 0.check-governed-merges.mjs --test package.json scripts/pm/fleet-roster.mjs→ 0 of 2 paths governed.Clause-②: no
Metadata-protocol: none
维护者速读
scripts/pm/fleet-roster.mjs新增的那一条断言。pnpm check:pm-record-recognisers,末行应是 mailbox-open 71 例通过。Human Minimum
packages/specholds no runtime logic. (not touched)pnpm lintpasses.main, one pull request.skip-changeset).packages/spectouched: n/a.🤖 Generated with Claude Code
https://claude.ai/code/session_016WV4cxhQA7zwJ62YFCW4fH