Repository navigation
docs(qa): re-point records-forms.crud-roundtrip and record-edit-undo from the removed History tab to the record page v3 audit read - #27716
Merged
Conversation
…from the removed History tab to the record page v3 audit read Record page v3 draws no History tab at any width. The two items now read the record's sys_audit_log field-change history under the timeline stream's Changes chip, located by width tier, the same shape records-forms.field-history-tracking took. Each item gets a revision bump and a history row. The showcase account's enable.trackHistory comment says what the flag gates now (comment only). Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016WV4cwDe31dqqFpKC87EUg
Contributor
Author
|
domain:devx#1 · os-elon-musk · session_01LKHDniRQSWjRJyDtacwpEd 席位核对Verdict: ACCEPT at head Against the card and triage 6503022089 (read line by line)
Gates at head
Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Elon · project thread
Fixes #27654
domain:devx#1 · os-elon-musk · session_016WV4cwDe31dqqFpKC87EUg (card thread)
维护者速读
records-forms.crud-roundtrip与records-forms.record-edit-undo里还让巡检去点 History 标签页的步骤和断言,改指向记录页 v3 的真实形态:记录页的sys_audit_log读取,结果在时间线「变更」筛选里(按宽度分层定位)。另改了 showcase 账户对象上一行注释。What changes
Same shape as #27651 gave
records-forms.field-history-tracking. No product code.records-forms.crud-roundtrip(revision 15 → 16): steps[5] and acceptance[4] (clause and verify) no longer open a History tab. The step reads the account's field-change history under the timeline stream's Changes chip, located by width tier (recordPageTierFor), at 1440×900 like the live spec. The verify names the gate (RecordDetailViewhistoryEnabled), the stream mapping (auditEntriesToFeedItems), thesys_activityrows the chip also lists, and the live specrecord-history-display.spec.ts. The clause's contract (display values, real actor, no raw payloads) is unchanged. History row added.records-forms.record-edit-undo(revision 5 → 6): steps[2] and acceptance[2] (clause, verify, evidence). The revert's oracle is the record'ssys_audit_logread over the API, with the Changes chip as the screenshot. The item staysblocked(fixture). History row added.examples/app-showcase/src/data/objects/account.object.ts: the comment onenable: { trackHistory: true }now says the flag gates the record page'ssys_audit_logread and the Changes chip lines, not a tab. Comment only, no behaviour. This file is outsidedomain:devx; it is declared here under triage's cross-domain grant (qa checklist: records-forms.crud-roundtrip and record-edit-undo still send the runner to a History tab that record page v3 removed (same family as #27492) #27654, comment 6503022089).Why
Record page v3 (#27055) draws no History tab at any width (
buildDefaultTabsemits Details / Timeline / Related / Approvals;buildDefaultPageSchema.test.tsasserts it). A runner following the old steps finds no tab and scores a working product red or BLOCKED.Verification
git grep -n -i 'history tab' -- docs/qa/platform-checklist/areas examples/app-showcase, history rows excluded: 0 hits in this card's locations. Two hits remain, both inrecords-forms.field-history-tracking(steps[3] and acceptance[2].verify, landed by docs(qa): re-point records-forms.field-history-tracking to the record page v3 sys_audit_log gate; the live history spec reads the Changes chip #27651); they are negations ("Record page v3 has no History tab", "Nor is a History tab"), not instructions, and that item is outside this card's file surface. The new text here avoids the literal phrase.node scripts/check-platform-checklist.mjs: exit 0.node scripts/pm/dispatch-gates.mjs --commandsderived 40 commands at the committed head. 34 exit 0 in a fresh worktree; the 6 that exit 3 (prerequisite: builtdist) are re-run after a whole-tree build and reported in the os-dev report comment.Clause-②: no
Metadata-protocol: none
Changeset: none (
skip-changeset): docs and an example comment, nothing publishes.Human Minimum
packages/specholds no runtime logic. (not touched)pnpm lintwas not run locally (a JSON and a comment change); CI runs it.main, one pull request.packages/spectouched: no.content/docs/references/,packages/*/CHANGELOG.mdorcontent/docs/releases/.🤖 Generated with Claude Code
https://claude.ai/code/session_016WV4cwDe31dqqFpKC87EUg