[objectstack-fleet]

Requested by Warren · project thread

Fixes #25915

Clause-②: no (narrowing)
Metadata-protocol: none

维护者速读

• 改了什么:从 @object-ui/components 的发布入口删掉两个没人用的组件:ViewSkeleton(按 variant 分发的骨架屏包装,连同它的两个类型)和 ShimmerSkeleton(连同其 props 类型)。
• 为什么改:裁决 B 收尾本卡;两者在整个工作区零导入,只是挂在公开面上的死导出。
• 风险与回滚:对外是破坏性变更(外部宿主若导入会编译失败),changeset 带 BREAKING 说明与逐个 FROM → TO 迁移;仓内零调用方。回滚即恢复两处导出。GridSkeleton 等其余骨架屏照常导出。
• 先看:ui/packages/components/src/custom/view-skeleton.tsx(只删分发器);.changeset/25915-retire-view-and-shimmer-skeleton.md(迁移说明与 ADR-0087 标记)。
• 两分钟验证:git grep -nwE "ViewSkeleton|ShimmerSkeleton" -- ui ':!*CHANGELOG.md',预期零命中。
• 需要你做的:无,席位落地(合并前需 CONTRACT_REVIEW_TIER 契约复核,席位转交分诊)。

What changes

• ui/packages/components/src/custom/view-skeleton.tsx: the ViewSkeleton variant dispatcher leaves, with ViewSkeletonVariant and ViewSkeletonDispatchProps. The file stays and keeps exporting GridSkeleton, KanbanSkeleton, FormSkeleton, ListSkeleton, ChartSkeleton and the ViewSkeletonProps / GridSkeletonProps / KanbanSkeletonProps types. GridSkeleton and ChartSkeleton have live importers (plugin-dashboard, plugin-charts).
• ui/packages/components/src/custom/shimmer-skeleton.tsx is deleted (ShimmerSkeleton, ShimmerSkeletonProps), and so is its custom/index.ts line.
• ui/packages/app-shell/src/styles.css: the animate-shimmer usage comment no longer points at ShimmerSkeleton. The keyframe and utility stay.
• Changeset @object-ui/components patch: a BREAKING note, a FROM → TO line for each of the five retired exports, and an adr-0087: not-required (runtime-export-retired …) marker naming all five. patch because Metadata-protocol: none (AGENTS.md Post-Task Checklist step 3: a non-protocol change, breaking included, ships patch and keeps its BREAKING banner).

Not touched, per ruling B (6486367718): KanbanSkeleton, FormSkeleton and ListSkeleton lose their only caller (the dispatcher) but stay exported. The Studio empty states and DataEmptyState are not touched either.

Tests

No new test. The removal is proven once on the built package (below), not pinned by a permanent file. The claim's file surface names no test file.

Acceptance notes

• Owes one CONTRACT_REVIEW_TIER contract review of the whole non-prose diff before the queue: pm-dispatch references/contract-review.md puts a Clause-②: no (narrowing) declaration at that tier. The seat hands it to triage. It is not Tier H, because no governed path is touched.
• ADR-0145 does not govern this: it covers ?: never tombstones on the ui authoring face, not React runtime exports.

Verification

All readings at head 8e055464 (base c4c515ad, #27366's merge).

Build, type-check, tests and the removal proof

• pnpm --filter @object-ui/components build under os-verify-lock: VERDICT command-exit 0. pnpm --filter @object-ui/components type-check: VERDICT command-exit 0, 0 error TS.
• pnpm --dir ui exec vitest run --maxWorkers=2 packages/components/ under the lock: VERDICT command-exit 0, Test Files 447 passed | 1 skipped (448), Tests 4327 passed | 24 skipped. This includes chart-primitives-removed-7397.test.ts, which reads the package barrel and requires ChartSkeleton to stay exported.
• Removal proof on the built dist/: grep -cw reads 0 for each of ViewSkeleton, ViewSkeletonVariant, ViewSkeletonDispatchProps, ShimmerSkeleton and ShimmerSkeletonProps, in index.js and in custom/view-skeleton.d.ts. custom/shimmer-skeleton.d.ts is not emitted, and custom/index.d.ts has no shimmer line. Control: GridSkeleton reads 2 in custom/view-skeleton.d.ts and 1 in index.js.
• Importers before the change, git grep -w over ui, packages, apps and examples (CHANGELOGs and the two files themselves excluded): 0 for all five. The only other hit was the styles.css comment this PR rewords.
• node scripts/check-platform-checklist.mjs --changed-from origin/main: exit 0, with no anchored file in the change set.

Gates and dogfood

• dispatch-gates --commands --repo objectstack-ai/objectstack derived 28 families. All 28 ran, each with its exit code captured before any pipe, and all exited 0. check-adr-0087-registration --base origin/main verified the runtime-export-retired marker for all five operands. --ran reconciliation: 28 derived, 28 run, 0 NOT-MEASURED.
• pnpm --dir ui exec vitest run scripts/ first read 1 failed. The failure was quick-reference-commands-4149 naming apps/site: a leftover ui/apps/site directory holding only ignored files from this worktree's install, before docs(ui-merge): fold objectui.org into objectstack docs, K4 — retire the site, host 301s, links #27329 retired the site on main. With the directory removed, the rerun gave VERDICT command-exit 0, Test Files 169 passed | 2 skipped.
• dispatch-gates --tier: no path-derived mandate. Changed lines: 111 (+21 / -90).
• Full dogfood, required because the title carries ! and Clause-② has the (narrowing) arm. The closure was built with pnpm --filter '@objectstack/dogfood^...' build (VERDICT 0), then pnpm --filter @objectstack/dogfood test ran under the lock with no shard and no path: VERDICT command-exit 0, Test Files 348 passed | 3 skipped (351), Tests 2806 passed | 20 skipped (2826).

---

Generated by Claude Code

[objectstack-fleet]

domain:ui#1 · os-warren · session_01JQwxbZeBv2y91towxasSUT

Seat note · contract review owed · seat domain:ui#1 · 2026-10-29T04:55Z

PR #27388 (Fixes #25915, slice 4 of maintainer ruling B 6486367718) declares Clause-②: no (narrowing): it retires five published operands of @object-ui/components — ViewSkeleton, ViewSkeletonVariant, ViewSkeletonDispatchProps (custom/view-skeleton.tsx) and ShimmerSkeleton, ShimmerSkeletonProps (custom/shimmer-skeleton.tsx, deleted, with its custom/index.ts line) — so one CONTRACT_REVIEW_TIER review of the whole non-prose diff is owed before the queue (claim amendment 6487017457).

Seat reading at 8e055464 (5 files, +21/−90): the five had 0 importers outside their own files on origin/main (seat-measured before the claim); GridSkeleton / KanbanSkeleton / FormSkeleton / ListSkeleton / ChartSkeleton and their prop types stay exported. The changeset is a @object-ui/components patch with a BREAKING note, FROM → TO lines for all five, and an adr-0087: not-required (runtime-export-retired …) marker the gate verified per operand; the app-shell/src/styles.css comment no longer names ShimmerSkeleton. Dev's run (report 6488314437): components build + type-check exit 0, 447 component test files green, the retired names read 0 in the built dist (control GridSkeleton present), 28/28 derived gates exit 0, full dogfood at the head 348 files / 2806 tests passed. Not Tier H (no governed path).

Contract-review-handoff: triage — CONTRACT_REVIEW_TIER review of a narrowing (published export retirement), whole non-prose diff · head 8e055464efa15842ec992e8cd6316f5c6c35f193

The PR stays draft and no reviewer is requested until a PASS is on file and the seat's ACCEPT is posted.

---

Generated by Claude Code

[objectstack-fleet]

triage#1 · os-zhuang · session_01AavokzJ5DndAwitDXvKy4U

Contract-review-claim: session_01AavokzJ5DndAwitDXvKy4U · head 8e055464efa15842ec992e8cd6316f5c6c35f193 · 2026-10-29T05:52Z

Triage seat, taking the hand-off and needs:contract-review on this head (#27062 (a)). The review runs at CONTRACT_REVIEW_TIER. If the lane claims or posts a record on this head first, triage withdraws.

---

Generated by Claude Code

[objectstack-fleet]

Contract review

Served-tier: CONTRACT_REVIEW_TIER
Head-sha: 8e055464efa15842ec992e8cd6316f5c6c35f193
Local-runs: none
Scope: ui/packages/components/src/custom/view-skeleton.tsx, ui/packages/components/src/custom/shimmer-skeleton.tsx, ui/packages/components/src/custom/index.ts, ui/packages/app-shell/src/styles.css + ui/packages/components/package.json (the exports map), ui/packages/components/src/index.ts (the barrel), ui/packages/components/src/__tests__/chart-primitives-removed-7397.test.ts, ui/packages/plugin-dashboard/src/DatasetWidget.tsx and ui/packages/plugin-charts/src/ObjectChart.tsx (the live GridSkeleton / ChartSkeleton importers), scripts/sdui-manifest.record.json, AGENTS.md Post-Task Checklist step 3 and docs/adr/0087-metadata-protocol-upgrade-contract.md (the runtime-export-retired category), docs/adr/0145-ui-deprecation-tombstones-retire-on-the-spec-window.md. The changeset .changeset/25915-retire-view-and-shimmer-skeleton.md is the prose face: read for ②, not reviewed. Inputs: card #25915 body and all 15 comments (ruling B 6486367718, dispatch order 6486381447, claim 6486419404, amendment 6487017457, dev reports 6487003112 and 6488314437), PR #27388 body, file list, both PR comments, the net diff against main at the head, and the 60 check-runs on the head. Read with git show prr-27388:... and git grep on prr-27388 and origin/main (45c9be5, 15 commits past the PR's base c4c515a); nothing built, run or re-run.

① Derived judgments

• Public surface of @object-ui/components (exports is . only, dist/index.d.ts / dist/index.js, reached through src/index.ts to custom/index.ts): five names leave the entry. Runtime values ViewSkeleton and ShimmerSkeleton; types ViewSkeletonVariant, ViewSkeletonDispatchProps, ShimmerSkeletonProps. Right: these are exactly the five ruling B 6486367718 item (2) and amendment 6487017457 name; the retired set is a narrowing of the published accept-set, declared as such.
• custom/index.ts at the head keeps export * from './view-skeleton' and drops only the shimmer-skeleton line. Right: GridSkeleton, KanbanSkeleton, FormSkeleton, ListSkeleton, ChartSkeleton and the ViewSkeletonProps / GridSkeletonProps / KanbanSkeletonProps types are still in the export { ... } block and the interfaces at the head of the file. GridSkeleton (DatasetWidget.tsx) and ChartSkeleton (ObjectChart.tsx, DatasetWidget.tsx, pinned by chart-primitives-removed-7397.test.ts toContain('ChartSkeleton')) keep their live importers.
• Importers of the five at the head, git grep -w over the whole tree excluding CHANGELOGs: only the changeset names them. On origin/main at 45c9be5 (15 commits past the PR base) the only hits are the two retired files themselves and the styles.css comment this PR rewords, so no importer appeared on main after the dev measured. Right: AGENTS.md step 4 (a removal that breaks ui/ ships with the fix) has nothing to ship; Type Check UI, Build & E2E UI, Test UI (16/16 shards) and Type Check · consumer gates are green on the head.
• data-slot="shimmer-skeleton" leaves the DOM vocabulary. Right: no test, stylesheet or selector in the tree names it.
• ui/packages/app-shell/src/styles.css: comment-only hunk; @keyframes shimmer and @utility animate-shimmer stay. Right: @object-ui/app-shell is private: true, nothing publishes, and the utility is the migration target the changeset's ShimmerSkeleton FROM → TO line points an external host at, so keeping it is coherent. Observation, not a finding: after this PR nothing in the workspace carries animate-shimmer; the utility exists for hosts only.
• scripts/sdui-manifest.record.json: unchanged between the PR's base and the head (the 4-line delta against current origin/main is main's own drift). Right: the record never names components/src/custom, view-skeleton or shimmer; the custom skeletons are outside the registry closure, so no manifest-hash token is owed.
• No governed path, no packages/spec, no metadata key: the queue guard (Governed Surface Queue Guard success) and the dev's "not Tier H" reading agree with the file list. Right.
• Side effect the PR names as out of scope: KanbanSkeleton, FormSkeleton, ListSkeleton lose their only caller (the dispatcher) and stay exported. Right per ruling: amendment 6487017457 forbids widening the retirement (option B); carried as an out-of-scope finding on components, app-shell: 17 EmptyState implementations, 23 Skeletons and 5 error-boundary classes; the shared DataErrorState has one importer and ViewSkeleton none — make the shared vocabulary the only one #25915 in report 6488314437.

② Semver level

• Changeset '@object-ui/components': patch, body carries Clause-②: no (narrowing) and Metadata-protocol: none at line start, a **BREAKING** banner, one FROM → TO line for each of the five retired operands, and exactly one ADR-0087 marker not-required (runtime-export-retired @object-ui/components#ViewSkeleton, ... #ShimmerSkeletonProps). The PR body carries the same two declaration lines (lines 6 and 7). Matches AGENTS.md Post-Task Checklist step 3: the level follows the protocol kind alone, none takes patch, and "a non-protocol change, widening or breaking, ships patch and keeps its BREAKING banner and ADR-0087 disposition". Metadata-protocol: none is correct: no key, accepted value or metadata type an author writes moves. Check Changeset (both runs) and Lint & Repo Gates are green on the head, so check-adr-0087-registration verified predicate 1 (retired-from-entry) for all five operands, predicate 2 (no metadata surface) and predicate 3 (FROM operands named), and check-changeset-no-major holds.
• Clause-②: no (narrowing) is the right arm: the accept-set of a published package shrinks and nothing is added; (narrowing) is BREAKING, which the ! in the title and the banner both say. ADR-0145 does not apply, as the dev states and the ADR's own Governs line confirms: it covers ?: never tombstones on the ui authoring face (ui/packages/types and published .d.ts keys), not React runtime exports; no tombstone is owed for a component.
• FROM → TO accuracy against the tree: GridSkeletonProps carries columns, KanbanSkeletonProps carries columns and cardsPerColumn, FormSkeleton / ListSkeleton take ViewSkeletonProps, ShimmerSkeletonProps aliased React.HTMLAttributes of a div — all true at the head. One nit in the dispatcher line: ChartSkeleton takes Omit of rows, so a host that passed rows with variant: "chart" gets a type error after migrating (the dispatcher used to forward rows onto the chart's root div as an unknown attribute). Prose face, should-fix at most, not blocking.

③ Boundary flags

• Report 6488314437 open_questions: none. Earlier open question 1 of 6487003112 (may slice 4 open as a narrowing, on what surface) was answered by amendment 6487017457 (option A, sequencing A); the diff is that option exactly, styles.css comment included.
• Deviation "no permanent absence pin; removal proven once on the built dist": accepted. The claim surface names no test file; the five are proven absent from the entry by check-adr-0087-registration predicate 1 while the changeset lives, and a re-introduction would be a new export owing its own Clause-②: yes declaration. Not escalated.
• Deviation "ui scripts/ gate recorded at its rerun after removing a stale local ui/apps/site directory": the CI check-runs on the head are the gate verdicts here (Lint UI, Lint & Repo Gates, Lint · PM dispatch-gates all success), so the local rerun carries nothing. Not escalated.
• Dev flag "KanbanSkeleton, FormSkeleton, ListSkeleton become uncalled exports": answered by the amendment (kept), carried as out-of-scope on the card. Not escalated; the seat owns whether a follow-up card is cut when components, app-shell: 17 EmptyState implementations, 23 Skeletons and 5 error-boundary classes; the shared DataErrorState has one importer and ViewSkeleton none — make the shared vocabulary the only one #25915 closes.
• Check-runs on 8e055464: 60 listed, all completed; conclusions are success or skipped (opt-in harnesses, matrix placeholders, schedule gate), none failure, none pending.
• Card closure: Fixes #25915. Ruling B item (1) landed as fix(app-shell): announce the route object-read and page record-load failures #27366 (c4c515ad), item (2) is this PR; the Studio panes and objectui#13386 are placed by the ruling. The Fixes is consistent with the dispatch order. Not escalated.

④ Design judgment

The narrowing, read against the published surface on main (@object-ui/components exports ., src/index.ts, custom/index.ts, the two source files) and the cited code:

• Does it take a declared capability away at the consumer? No. The capability (a variant-dispatching skeleton, and a shimmer variant of Skeleton) is removed at the producer, the package entry, not papered over at a call site. Every workspace consumer measured on main is zero, and the one surface that could call a skeleton by variant (DatasetWidget.tsx) already calls GridSkeleton / ChartSkeleton directly, which is what the FROM → TO prescribes. No published doc, skill or release note on main teaches ViewSkeleton or ShimmerSkeleton (content/docs/**, skills/, .claude/skills/, READMEs and every CHANGELOG read 0), so no declared promise outlives the code.
• Does it make a refusal real that the spec already made? Not applicable: these are React runtime exports with no packages/spec schema, registered node type or stored shape; the reader of a removed export is the compiler, which is the ADR-0087 D7 / runtime-export-retired argument the changeset makes and the gate verified.
• Implementation gap versus narrowing: the card body's own task line 3 says delete both "if still unused after the migration"; ruling B closed the migration at the Studio panes and left both at zero importers. Retiring them is the retire branch of "implemented or retired", not a consumer-side narrowing.
• Attempts to break it: (a) a third workspace package importing either name on main after the dev's measurement — none at 45c9be5; (b) the removal breaking the ChartSkeleton barrel pin — the pin still passes (Test UI green), and the test's own message names view-skeleton.tsx as the file that legitimately stays; (c) the sdui registry closure moving — the record does not list the custom skeletons, so no hash moves; (d) the shimmer keyframe left orphaned — it stays by design as the host migration target; (e) the dispatcher silently forwarding rows to ChartSkeleton's root div disappears with the dispatcher, a latent attribute leak removed rather than introduced.
• Findings: no must-fix. Should-fix (non-blocking, prose face): the dispatcher FROM → TO line says "each taking the same remaining props", which is one prop short for variant: "chart" (rows is refused there). Observation: animate-shimmer has no in-workspace consumer after this PR; a later card may retire it if the host-facing prescription ages out.

Implemented-by: claude/project-thread-jplskw
Reviewed-by: session_01AavokzJ5DndAwitDXvKy4U

VERDICT: PASS

---

Generated by Claude Code

[objectstack-fleet]

domain:ui#1 · os-warren · session_01JQwxbZeBv2y91towxasSUT

席位核对

ACCEPT · seat domain:ui#1 · head 8e055464 · 2026-10-29T06:06Z

席位意见：#25915 裁定 B 的第二步：从 @object-ui/components 撤下已无人使用的 ViewSkeleton（含两个类型）和 ShimmerSkeleton（含 props 类型）共五个导出；GridSkeleton、KanbanSkeleton、FormSkeleton、ListSkeleton、ChartSkeleton 保留。属于收窄（narrowing），契约复核 6489318444 已在同一 head 给出 PASS。第一步 #27366 已合并，本 PR 落地后 #25915 完成。

1. Shape: Fixes #25915; 5 files, +21/−90: custom/view-skeleton.tsx (dispatcher and its two types removed), custom/shimmer-skeleton.tsx deleted with its custom/index.ts line, a comment-only app-shell/src/styles.css hunk, and .changeset/25915-retire-view-and-shimmer-skeleton.md (@object-ui/components patch, BREAKING banner, FROM → TO for all five, one ADR-0087 runtime-export-retired marker).
2. Contract review: triage CONTRACT_REVIEW_TIER review 6489318444 on 8e055464: PASS, no must-fix. Importers of the five on origin/main 45c9be5: 0. Clause-②: no (narrowing) + Metadata-protocol: none → patch per AGENTS.md step 3; ADR-0145 does not apply (runtime exports, not authoring-face keys).
3. Gates / check-runs: PR check-runs on 8e055464: 45 success, 15 skipped, 0 failure; mergeable_state clean. Dev's run (report 6488314437): components build + type-check exit 0, 447 component test files green, retired names read 0 in the built dist, 28/28 derived gates exit 0, dogfood 348 files / 2806 tests passed.
4. Accepted deviations: no permanent absence pin (the ADR-0087 gate proves absence per operand while the changeset lives; review ③ accepted it). The review's one should-fix is prose only: the dispatcher FROM → TO line says each successor takes "the same remaining props", but ChartSkeleton refuses rows. The seat accepts it as is rather than move the reviewed head; a host migrating variant: "chart" gets a compile error that names the prop.
5. Out of scope: KanbanSkeleton / FormSkeleton / ListSkeleton now have no in-workspace caller (kept by amendment 6487017457); animate-shimmer has no in-workspace consumer (kept as the host migration target); four other hand-drawn load failures (AuditPanel, ResourceEditPage, DirectoryPage, chrome ErrorBoundary). None filed by this landing. Skills-docs: none — no skill or doc teaches the five.
6. Landing: not Tier H. The seat removes needs:contract-review, readies the PR and arms auto-merge.

---

Generated by Claude Code