Repository navigation
test(spec): tombstoned-row-status floor at two thirds of the measured population (48 → 32) - #26575
Merged
Merged
Conversation
… population (48 → 32) Retiring one tombstoned key no longer reds the liveness non-vacuity check; emptying the population still does. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WGufzf9arQbsfoQ2s2hFtP
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contributor
Author
席位核对 · ACCEPT ·
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Yibo Wang · project thread
Fixes #26541
Clause-②: no
Metadata-protocol: none
维护者速读
tombstoned-row-status活性测试的防空底线从 40 降到 32,只改这一个测试文件。dead、必须never类型)不动;回滚即还原这一行。packages/spec/scripts/liveness/tombstoned-row-status.test.ts的TOMBSTONE_FLOOR一行。pnpm --filter @objectstack/spec exec vitest run scripts/liveness/tombstoned-row-status.test.ts,预期 3 个用例全绿。What changes
TOMBSTONE_FLOORinpackages/spec/scripts/liveness/tombstoned-row-status.test.tsmoves from 40 to 32, with a comment naming the measured value and the date. This follows the parent #26444 rule (about two thirds of the measured population, rounded down; precedentvite-dts-wiring-ratchet, measured 22, floor 15). The stale inline comment "40 was the measured population" is reworded. The file header's history paragraph (40 at pin time) is left as the historical record it is.Measured population on base
1c632311: 48 top-level[REMOVED]keys, all 48dead. The floor is floor(48 × 2/3) = 32. Margin: 16 tombstones (one third) can be retired before the floor is reached.No changeset: the file lives under
packages/spec/scripts/, which is not in@objectstack/spec'sfiles[](dist,json-schema,liveness,prompts,src/**/*.zod.ts, …), so nothing publishes. Labelledskip-changeset.Tests
pnpm exec vitest run scripts/liveness/inpackages/specon the change: Test Files 12 passed (12), Tests 358 passed (358).Acceptance notes
Non-vacuity kept. Two one-off mutations of
collectTombstones()'sreturn out;on the committed fix, each restored withgit checkout HEAD --and proved restored by an emptygit diff HEAD(no test file left behind):Mutation legs
return [];AssertionError: expected 0 to be greater than or equal to 32, Tests 1 failed / 2 passedreturn out.slice(1);(47)Verification
Local derived gate subset (
node scripts/pm/dispatch-gates.mjs --commands) is reported in the os-dev report comment on #26541; every CI family reads from this PR's check-runs.Human Minimum
packages/specholds no runtime logic.pnpm lintpasses.main, one pull request.packages/spectouched: its generated artifacts are regenerated and committed.content/docs/references/,packages/*/CHANGELOG.mdorcontent/docs/releases/.🤖 Generated with Claude Code
https://claude.ai/code/session_01WGufzf9arQbsfoQ2s2hFtP
Generated by Claude Code