Repository navigation
test(cli): set the command-population vacuity floors at about two thirds of the measured counts - #26555
Conversation
…s at about two thirds of the measured counts Each anti-vacuity floor in the two command-population pins now sits at about two thirds of its count measured on 185512c (72/164/53 and 72/64/3), so deleting one command is a green change while an emptied population still reds. The `this.error` population (3 modules) keeps a non-empty floor. Each floor is written once, with its measured value and date beside it. Co-authored-by: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01FEkQ5m4bTCRGQcuJTsnyfD
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
席位核对ACCEPT · The maintainer's standing authorisation for landing reviewed PRs, verbatim: 「按照 pm-dispatch 规则复核过的都授权」.
Generated by Claude Code |
Requested by Leehom · project thread
Fixes #26523
Part of #26444 (the CLI half; the ui half and the two-sided baselines are other lanes' children, and the spec liveness floor is the spec seat's).
Clause-②: no
Metadata-protocol: none
维护者速读
this.error只有 3 个模块,保留为非空底线),每个底线旁注明实测值与测量日期。vite-dts-wiring-ratchet:实测 22,底线 15)改为防空值。packages/cli/test/refusal-renders-once.test.ts的三个常量(ERROR_FILE_FLOOR是原先唯一等于实测的那个),再看packages/cli/test/exit-signal.pin.test.ts的三个常量。pnpm --filter @objectstack/cli exec vitest run --maxWorkers=2 test/exit-signal.pin.test.ts test/refusal-renders-once.test.ts,预期 2 个文件、127 个用例全绿。What changes
Each anti-vacuity floor in the two command-population pins moves to about two thirds of its count, re-measured on
origin/main185512cc(2026-10-27), rounded down:exit-signal.pin.test.tsPOPULATION_FLOOR(command modules)exit-signal.pin.test.tsSITE_FLOOR(signal-raising calls inside atry)exit-signal.pin.test.tsJSON_FACE_FLOOR(JSON-capable commands)refusal-renders-once.test.tsFILE_FLOOR(command modules)refusal-renders-once.test.tsPRINTER_FILE_FLOOR(modules calling a refusal printer)refusal-renders-once.test.tsERROR_FILE_FLOOR(modules raisingthis.error)ERROR_FILE_FLOORis 1 under the existingtoBeGreaterThanOrEqual, which is> 0.Why
A floor equal to today's count turns every legitimate deletion of a command into a red run and a floor bump (#26444, after #26343 needed five bumps for one deletion). A vacuity floor only needs to catch a discovery or scan that silently resolves nothing.
Tests
scripts/ablation-replace.mjson committedf78d7c29. Each landed (anchor 1 to 0), turned exactly one test red with the floor's own message, and was restored to the HEAD blob withgit diff HEADempty.src/commands/datasource/introspect.tswas deleted and both files were run. It is the worst single deletion for these floors: it is a command module, a refusal-printer module, and one of the threethis.errormodules. Result: 2 files, 126 of 126 tests green. The file was then restored to its HEAD blob.185512ccredsERROR_FILE_FLOOR(expected 2 to be greater than or equal to 3). This is the defect the card describes.Ablations, one per floor (f78d7c2)
One-command deletion dry run, and the base control
Acceptance notes
185512cc, five of the six floors already sat below today's counts (65 of 72, 131 of 164, 46 of 53, 60 of 72, 50 of 64). The card's "equal to the measured values" matches the counts the old docblocks recorded, not today's. OnlyERROR_FILE_FLOORstill equalled its count (3 of 3), and the base control shows that one deletion red it. All six were moved anyway, by the parent's rule ("every anti-vacuity floor moves to roughly two thirds of today's value") and this card's acceptance (every floor below its re-measured value by a stated margin).git grepfor the two file names outside themselves finds only prose references inrefusal-renders-once.e2e.test.ts, and no ledger carries their values. No open PR touched either file at start or before this PR was opened.packages/clifloors, not edited.test/option-b-reader-acceptance.pin.test.ts:312has floor 38 and measured 38. It equals its count on purpose: its comment says "⛔ never lower it", so it is a raise-only ratchet.test/platform-page-i18n-parity.test.ts:845has floor 38, measured 40.test/print-metadata-stats-zero-row.test.ts:258has floor 18, measured 19.Verification
pnpm --filter @objectstack/cli exec vitest run --project unit --maxWorkers=2under the verify lock: 336 files passed and 2 failed, becausepackages/cliitself was not built yet (published-subpath-console.pin,published-subpath-hook-body.pinsay "packages/cli is not built"). Afterpnpm --filter @objectstack/cli build, those two pass (2 files, 29 tests). That makes 338 of 338 files green, 4890 tests passed and 29 skipped. Theintegrationtier is left to CI: the diff touches only two unit-tier files and no spawn entry.pnpm --filter @objectstack/cli typecheck: exit 0 (check:test-typecheck: OK).eslint --no-inline-config packages/cli: exit 0.node scripts/pm/dispatch-gates.mjs --commands --repo objectstack-ai/objectstackderived 48 commands onf78d7c29. 47 ran with exit 0.pnpm check:dual-build-cjs-loadsexited 3 (PREREQUISITE NOT MET: it needs every package's dist), so it is NOT MEASURED.check-plugin-teardown-shape --self-testfirst exited 3 on the shallow clone and exited 0 after fetching its positive-control commit. Reconciliation:✓ dispatch-gates --ran: 48 derived famil(ies) accounted for — 47 run, 1 NOT-MEASURED.Human Minimum
packages/specholds no runtime logic. (not touched)pnpm lintpasses. (eslint overpackages/cliexit 0)main, one pull request.skip-changeset)packages/spectouched: its generated artifacts are regenerated and committed. (not touched)content/docs/references/,packages/*/CHANGELOG.mdorcontent/docs/releases/.Generated by Claude Code