Repository navigation
test(dogfood): re-measure the authz census for the approval record-lock read - #26406
Merged
Merged
Conversation
…ck read The record-lock route added one ledger row (80 -> 81, family `approvals`, blind spot 0) and one direct registration site in approvals-routes.ts outside registerMetadataEndpoints (rest-server.ts row 69/19/50 -> 70/19/51, register 62 -> 63, enforceAuth 115 -> 116; totals 64/69 -> 65/70). The matrix docblock's REST ledger figure moves to 81 rows / 18 families. Claude-Session: https://claude.ai/code/session_01WGufzfNhdx3xRKeaa8e7JB Co-authored-by: Claude <noreply@anthropic.com>
Contributor
📓 Docs Drift CheckNothing in this diff resolved to a documentable surface (no symbol, route or SDK anchor derived from 0 changed package(s)), so this run has no opinion about the docs. What this run could not see
Coarse fallback — 0 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): |
Contributor
Author
席位核对 · ACCEPT ·
|
This was referenced Oct 27, 2026
zhuangjianguo
pushed a commit
that referenced
this pull request
Oct 27, 2026
Brings in main's re-measured authz census (#26406), the fix for main's own dogfood red (#26400) that the full battery on this branch showed. Main's automation skill change (#26390) left the approvals reference two bytes under its token ceiling, so the queue approver row is shortened to fit (members of the named ownership queue at node entry; an empty queue adds nobody). Claude-Session: https://claude.ai/code/session_01GTntg542RUmmRRbMY6wMZD Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Yibo Wang · project thread
Fixes #26400
Clause-②: no
Metadata-protocol: none
维护者速读
{ locked }for every caller who can read the record #26361 新增的审批记录锁读取路由(81 行台账、rest-server 行 70 / 19 / 51、总盲点 65 / 70)。{ locked }for every caller who can read the record #26361 加了一条路由但没同步普查,main的 Dogfood Regression Gate (1/3) 和 (3/3) 从那以后一直红,发版闸门读的正是这两条。main会回到红。packages/qa/dogfood/test/authz-probe-blind-spot.census.ts的 rest-server.ts 行(新盲点 50 → 51 的判定),其次台账行,再看authz-conformance.matrix.ts第 27 行。pnpm --filter @objectstack/dogfood exec vitest run test/authz-probe-blind-spot.test.ts test/authz-conformance.test.ts,预期 2 个文件、108 个测试全绿(main上是 10 个红)。What changes
Census bookkeeping for the route #26361 added,
GET {basePath}/approvals/records/:object/:recordId/lockinpackages/rest/src/approvals-routes.ts. Each figure below was measured withderiveProbeFileCensus()on this tree, not copied from the card or from the server seat's reading (6431978738). The reading agreed with the server seat on every figure it gave.rest-route-ledger.tspopulation / reachable / blindSpotfamily: 'approvals', a family the other approval rows already carryrest-route-ledger.tskeysrest-route-ledger.tscontrolsroute: '/family: 'rest-server.tspopulation / reachable / blindSpotthis.routeManager.register(site inregisterApprovalsEndpoints, outsideregisterMetadataEndpointsand the/metasubset, the same as its seven siblingsrest-server.tscontrolsthis.routeManager.register(/approvals-routes.ts: …/enforceAuththis.enforceAuth(…)(the onlyenforceAuthline #26361 added)BLIND_SPOT_TOTAL_STATIC/_RUNTIMEauthz-conformance.matrix.tsdocblock (the figure #17111 parses)Every edited figure has a provenance comment in the row, in the shape the earlier re-measurements use.
Why
Dogfood Regression Gate (1/3)and(3/3)have been red on everymainpush run that runs them since #26361 (6a2866af). This is the main-red stop-bleed under convention ①. It moves the census forward and does not revert #26361.Tests
Both files, under the verify lock, on
1cc4fa20:before (origin/main b33dd25): 2 files failed, 10 tests failed, 98 passed
after (1cc4fa2): 2 files passed, 108 tests passed
Acceptance notes
packages/rest/src/rest-route-ledger.ts. The figure the [finding]authz-conformance.matrix.ts:27states the route ledger holds "94 rows / 19 families" in the present tense — measured 91 today, and the cause is #14503, not the gate move it sits next to #17111 pin reads is inauthz-conformance.matrix.tsline 27, so that is the one that moved. Nopackages/rest/**file changes, as the claim requires.!and no(narrowing)arm, so the full battery is not owed. The two files above hold all 10 failures. The card's acceptance (the firstmainpush run and the next scheduled run green) can only be read after landing.{ locked }for every caller who can read the record #26361 merged green. Seat 1 answered that question on the card (6432031749). It is not in this PR.Verification
Local derived gate set (
dispatch-gates.mjson1cc4fa20, 50 families): 48 exit 0, 2 NOT MEASURED, 0 red.NOT MEASURED (exit 3, prerequisite not met in this container)
node scripts/check-plugin-teardown-shape.mjs --self-test: its positive control is pinned to a commit that this shallow clone cannot reach.pnpm check:dual-build-cjs-loads: it reads built output, and seven packages outside this diff have nodist/.Both run in CI's
Lint & Repo Gates.--ranreconciliation:50 derived famil(ies) accounted for — 48 run, 2 NOT-MEASURED.Human Minimum
packages/specholds no runtime logic. (not touched)pnpm lintpasses. (CI-owned)main, one pull request.@objectstack/dogfoodis private, test files only:skip-changeset)packages/spectouched: n/a.content/docs/references/,packages/*/CHANGELOG.mdorcontent/docs/releases/.🤖 Generated with Claude Code
Generated by Claude Code