Skip to content

test(app-shell): re-point the ObjectSchema corpus guards to 48 after sharing was adopted #26231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
objectstack-fleet merged 1 commit into from
Oct 26, 2026
Merged

test(app-shell): re-point the ObjectSchema corpus guards to 48 after sharing was adopted #26231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ui/packages/app-shell/src/services/MetadataService.retiredObjectEnabled.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,11 @@ describe('objectui#6238 · the schema oracle — both tombstone keys are refused
// (objectstack#25513; measured against the 915e9404 pin: the spec's own
// `authorable-surface/data.json` gains exactly `data/Object:membershipKeys`
// between the two commits, none lost; objectui#13440). Re-pointed the same way.
// 48 on the objectstack `main` pin after objectstack#26005 (5e113b39), which adopted
// `sharing` (measured against its parent fbb75998: gained set exactly `['sharing']`,
// lost set empty; unchanged at 43b47156). Re-pointed the same way.
const accept = new Set(Object.keys(ObjectSchema.shape as Record<string, unknown>));
expect(accept.size).toBe(47);
expect(accept.size).toBe(48);
expect(accept.has('enable')).toBe(true);
expect(accept.has('enabled')).toBe(false);
expect(accept.has('_deleted')).toBe(false);
Expand Down
5 changes: 4 additions & 1 deletion ui/packages/app-shell/src/services/MetadataService.specKeyObjectPayload.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,8 +171,11 @@ describe('the instrument', () => {
// (objectstack#25513; measured against the 915e9404 pin: the spec's own
// `authorable-surface/data.json` gains exactly `data/Object:membershipKeys`
// between the two commits, none lost; objectui#13440). Re-pointed the same way.
// 48 on the objectstack `main` pin after objectstack#26005 (5e113b39), which adopted
// `sharing` (measured against its parent fbb75998: gained set exactly `['sharing']`,
// lost set empty; unchanged at 43b47156). Re-pointed the same way.
const accept = new Set(Object.keys(ObjectSchema.shape as Record<string, unknown>));
expect(accept.size).toBe(47);
expect(accept.size).toBe(48);
// `fieldGroups` is the only grouping key on the object, and it groups the
// FIELDS INSIDE one object — it is not a category for objects themselves,
// so `group` has no mapping target here.
Expand Down
Loading